Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass after 2028 #4403

Merged
merged 1 commit into from Jan 6, 2021
Merged

Make tests pass after 2028 #4403

merged 1 commit into from Jan 6, 2021

Conversation

bmwiedemann
Copy link
Contributor

This PR was done while working on reproducible builds for openSUSE.

This PR was done while working on reproducible builds for openSUSE.
@jacobtomlinson
Copy link
Member

Thanks for this. Seems sensible to bump these dates out.

Out of curiosity how does this change make builds reproducible?

@bmwiedemann
Copy link
Contributor Author

As part of my work on reproducible builds for openSUSE, I check that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect some software will be used in some places.
This showed up failing tests in our python-distributed package build.
See https://reproducible-builds.org/ for why this matters.

So in the end it is about getting identical build results anytime anywhere and expirations break the anytime part.

@jacobtomlinson
Copy link
Member

Really interesting thanks!

CI failures appear to be related to #4404.

@jacobtomlinson jacobtomlinson merged commit a07fc39 into dask:master Jan 6, 2021
1 check failed
@bmwiedemann bmwiedemann deleted the ssl branch January 6, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants