New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test setup fixture #5242
Add test setup fixture #5242
Conversation
The changes here have caused some tests to start failing. Interestingly if I run EDIT: Nvm, the test failures were due to updating the Dask config with the original values without completely clearing it beforehand. I've pushed up a fix |
cc @ian-r-rose if you get a chance to take a look at this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it
Thanks for reviewing @fjetter! |
This reverts commit b0c9dc4.
This PR adds a new
initialize_test
fixture which is automatically applied to each test in our test suite. This fixture does a few things:I should note that points 2 and 3 above were previously being done in our
clean
content manager (so all tests usinggen_cluster
,gen_test
, orcleanup
). This PR just broadens their reach to all tests.Closes #5240
cc @mrocklin