Handle UCXNotConnected error
#5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an issue that occurs non-deterministically, generally during `client._reconnect` at shutdown when peers have already begun closing. Therefore it needs to be catched and raise `CommClosedError`to prevent unhandled errors.
quasiben
approved these changes
Oct 21, 2021
|
Thanks for the review @quasiben . I don't think errors are related, they're all on Windows runs and this PR exclusively modifies UCX which isn't even supported on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is an issue that occurs non-deterministically, generally during
client._reconnectat shutdown when peers have already begun closing.Therefore it needs to be catched and raise
CommClosedErrorto preventunhandled errors.
Given the non-deterministic nature of the issue, testing it is very challenging and unfortunately there's no known test that can be added currently.
Error handling depends on rapidsai/ucx-py#799 , but the change is backwards-compatible.