Support configuring TLS min/max version#5594
Merged
jrbourbeau merged 2 commits intodask:mainfrom Jan 6, 2022
Merged
Conversation
This adds support for configuring minimum/maximum versions of TLS to support for a connection. Note that we also drop support for TLS versions < 1.2. These versions are insecure, are deprecated in openSSL (and python 3.10), and shouldn't be used. With this PR `distributed` requires TLS 1.2+. I don't anticipate user issues from this change - TLS 1.2 was released in 2008 and should be supported everywhere at this point.
jrbourbeau
reviewed
Jan 4, 2022
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @jcrist. I left a few small comments, but overall this looks good. Just to confirm, setting our minimum tls version to 1.2 shouldn't be too limiting for users given our current set of supported Python versions?
Member
Author
Yeah, TLS 1.2 should be supported everywhere (definitely every Python environment that we currently support). I wouldn't expect any issues from this change. |
jrbourbeau
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for configuring minimum/maximum versions of TLS to
support for a connection.
Note that we also drop support for TLS versions < 1.2. These versions
are insecure, are deprecated in openSSL (and python 3.10), and shouldn't
be used. With this PR
distributedrequires TLS 1.2+. I don'tanticipate user issues from this change - TLS 1.2 was released in 2008
and should be supported everywhere at this point.
Fixes #5553.