Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring TLS min/max version #5594

Merged
merged 2 commits into from Jan 6, 2022
Merged

Conversation

jcrist
Copy link
Member

@jcrist jcrist commented Dec 13, 2021

This adds support for configuring minimum/maximum versions of TLS to
support for a connection.

Note that we also drop support for TLS versions < 1.2. These versions
are insecure, are deprecated in openSSL (and python 3.10), and shouldn't
be used. With this PR distributed requires TLS 1.2+. I don't
anticipate user issues from this change - TLS 1.2 was released in 2008
and should be supported everywhere at this point.

Fixes #5553.

This adds support for configuring minimum/maximum versions of TLS to
support for a connection.

Note that we also drop support for TLS versions < 1.2. These versions
are insecure, are deprecated in openSSL (and python 3.10), and shouldn't
be used. With this PR `distributed` requires TLS 1.2+. I don't
anticipate user issues from this change - TLS 1.2 was released in 2008
and should be supported everywhere at this point.
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcrist. I left a few small comments, but overall this looks good. Just to confirm, setting our minimum tls version to 1.2 shouldn't be too limiting for users given our current set of supported Python versions?

distributed/security.py Show resolved Hide resolved
distributed/security.py Outdated Show resolved Hide resolved
distributed/security.py Outdated Show resolved Hide resolved
@jcrist
Copy link
Member Author

jcrist commented Jan 5, 2022

Just to confirm, setting our minimum tls version to 1.2 shouldn't be too limiting for users given our current set of supported Python versions?

Yeah, TLS 1.2 should be supported everywhere (definitely every Python environment that we currently support). I wouldn't expect any issues from this change.

@jrbourbeau jrbourbeau merged commit a9905b1 into dask:main Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dask security: The TLS protocol version can be selected.
2 participants