Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test_dump_cluster_unresponsive_remote_worker #5679

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

crusaderky
Copy link
Collaborator

The test occasionally fails (e.g. https://github.com/dask/distributed/runs/4896454662) with the Client failing to connect.

Increase timeout from 200ms to 600ms.
After this change, the test runs in 1.8s on my machine. Without any config, it runs successfully in 6.2s.

@crusaderky crusaderky changed the title Fix flaky test_dump_cluster_state_unresponsive_local_worker Fix flaky test_dump_cluster_unresponsive_remote_worker Jan 21, 2022
@crusaderky crusaderky self-assigned this Jan 21, 2022
@crusaderky crusaderky added the flaky test Intermittent failures on CI. label Jan 21, 2022
@crusaderky
Copy link
Collaborator Author

All test failures are unrelated; ready for review and merge

@jrbourbeau jrbourbeau changed the title Fix flaky test_dump_cluster_unresponsive_remote_worker Fix flaky test_dump_cluster_unresponsive_remote_worker Jan 21, 2022
@jrbourbeau jrbourbeau merged commit 337f152 into dask:main Jan 21, 2022
@crusaderky crusaderky deleted the test_dump_unresponsive branch January 21, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky test Intermittent failures on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants