Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test_exit_callback test #5713

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

jcrist
Copy link
Member

@jcrist jcrist commented Jan 26, 2022

This test seems to fail on CI only. Try bumping the timeouts a bit
higher, presuming the errors are just due to things running a bit slower
than they do locally. If this doesn't work I'll have to debug further.

This test seems to fail on CI only. Try bumping the timeouts a bit
higher, presuming the errors are just due to things running a bit slower
than they do locally. If this doesn't work I'll have to debug further.
@jcrist
Copy link
Member Author

jcrist commented Jan 27, 2022

The mac jobs never ran, but all green on windows. Rerunning now to double check, but this may have been sufficient.

@jcrist
Copy link
Member Author

jcrist commented Feb 1, 2022

There are a bunch of other failures, but I haven't seen test_exit_callback in any of them. Merging for now, since it can't make things worse (and may have fixed things).

@jcrist jcrist merged commit 713204b into dask:main Feb 1, 2022
@jcrist jcrist deleted the squash-test-exit-callback-error branch February 1, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant