Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pragma - cli files #5800

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

scharlottej13
Copy link
Contributor

Pragma no cover

  • We have cases with relatively long switch-like statements ending in a final exception, e.g. ValueError "unknown value"
  • Conditional imports may need be covered with pragma statements and/or a dedicated job

Moved this into a separate PR from #5749. Copying @fjetter's comment:

I'm wondering if the entire CLI module should be ignored. Can we get reliable coverage information from this?

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@github-actions
Copy link
Contributor

Unit Test Results

       17 files   -        1         17 suites   - 1   10h 0m 7s ⏱️ - 24m 4s
  2 596 tests ±       0    2 512 ✔️  -        5       80 💤 +    1  2 +2  2 🔥 +2 
21 864 runs   - 1 366  20 529 ✔️  - 1 229  1 331 💤  - 141  2 +2  2 🔥 +2 

For more details on these failures and errors, see this check.

Results for commit e9c8e4b. ± Comparison against base commit 91f899e.

@fjetter fjetter merged commit cd368c0 into dask:main Feb 15, 2022
@scharlottej13 scharlottej13 deleted the improve-coverage-cli branch February 15, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants