Cluster dump now excludes run_spec by default#5803
Merged
crusaderky merged 1 commit intodask:mainfrom Feb 15, 2022
Merged
Conversation
Contributor
Member
Author
|
Test failures are all unrelated |
fjetter
force-pushed
the
fix_cluster_dump_exclude
branch
from
de4ed0b to
f1be76d
Compare
crusaderky
approved these changes
Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_specattribute name in worker to scheduler. I consider this private API and don't intend to implement a deprecation mechanismrun_specby default for dump_cluster since this includes pickled user functions which might be considered sensitive, is typically useless for debugging and increases dump size significantly.