Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pragma: no cover from distributed.cli.dask_ssh #5809

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

graingert
Copy link
Member

@graingert graingert commented Feb 15, 2022

Linting is failing on the main branch: https://github.com/dask/distributed/runs/5199810275?check_suite_focus=true
The # pragma: no cover introduced in #5800 overran the line length limit

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

@fjetter
Copy link
Member

fjetter commented Feb 15, 2022

my bad. should've caught this. It is confusing lately that the test summary pops up under linting :/

Comment on lines 219 to 218
) # pragma: no cover

# Monitor the output of remote processes. This blocks until the user issues a KeyboardInterrupt.
c.monitor_remote_processes()
Copy link
Member Author

@graingert graingert Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why doesn't line 222 need a # pragma: no cover? - for line 222 to be covered then 219 needs to have been covered

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the pragmas. We shouldn't spend too much time on this

they overran the line length limit
@graingert graingert changed the title format distrbuted.cli.dask_ssh remove pragma: no cover from distributed.cli.dask_ssh Feb 15, 2022
@fjetter fjetter merged commit f25f1fc into dask:main Feb 15, 2022
@fjetter
Copy link
Member

fjetter commented Feb 15, 2022

Thanks @graingert for spotting this!

@graingert graingert deleted the apply-pre-commit branch February 15, 2022 13:39
@github-actions
Copy link
Contributor

Unit Test Results

       17 files  ±    0         17 suites  ±0   10h 8m 41s ⏱️ + 38m 36s
  2 597 tests ±    0    2 515 ✔️  -   1       79 💤  -     2  3 +3 
22 042 runs  +188  20 555 ✔️ +57  1 484 💤 +128  3 +3 

For more details on these failures, see this check.

Results for commit 9c9f05b. ± Comparison against base commit 00040a5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants