Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazily get dask version information #5822

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

graingert
Copy link
Member

@graingert graingert commented Feb 16, 2022

this uses "importlib.metadata:version" - for version which is much faster than git

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2022

Unit Test Results

       11 files  ±  0         11 suites  ±0   6h 8m 4s ⏱️ - 24m 53s
  2 620 tests +  2    2 539 ✔️ +  4    81 💤 ±0  0  - 2 
14 443 runs  +12  13 605 ✔️ +14  838 💤 ±0  0  - 2 

Results for commit 8947abd. ± Comparison against base commit 9a266a0.

♻️ This comment has been updated with latest results.

@graingert graingert marked this pull request as ready for review February 17, 2022 10:09
distributed/__init__.py Outdated Show resolved Hide resolved
@fjetter
Copy link
Member

fjetter commented Feb 18, 2022

Your file formatting is a bit off. I would suggest to install pre-commit, see http://distributed.dask.org/en/stable/develop.html#code-formatting

this uses "importlib.metadata:version" - for __version__ which is much faster than git
@fjetter fjetter merged commit 158a3e7 into dask:main Feb 23, 2022
@graingert graingert deleted the faster-dunder-version branch February 23, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

importing distributed runs 4 git subprocesses in CI (when installed with -e)
2 participants