Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix track_features for distributed pre-releases #5927

Merged
merged 4 commits into from
Mar 11, 2022

Conversation

charlesbluca
Copy link
Member

@charlesbluca charlesbluca commented Mar 10, 2022

The Jinja template for track_features in the Distributed pre-release recipe is incorrect, making it so builds with Cython enabled / disabled both have the cythonized-scheduler feature.

This PR should resolve the issue (which I think is that cython_enabled is interpreted as a string True/False in Jinja?) and make it so this feature only applies to Cython builds.

cc @jakirkham @jrbourbeau

  • Closes #xxxx
  • Tests added / passed
  • Passes pre-commit run --all-files

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2022

Unit Test Results

       12 files  ±0         12 suites  ±0   5h 29m 47s ⏱️ - 13m 23s
  2 639 tests ±0    2 557 ✔️ +1    80 💤 ±0  2  - 1 
12 977 runs  ±0  12 333 ✔️  - 3  640 💤 +3  4 ±0 

For more details on these failures, see this check.

Results for commit 818daee. ± Comparison against base commit f9d2f91.

♻️ This comment has been updated with latest results.

@jakirkham
Copy link
Member

Thanks Charles! 😄

Had a couple questions above 🙂

Co-authored-by: jakirkham <jakirkham@gmail.com>
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Charles! 😄

One last comment. Otherwise think we should be good here 🙂

continuous_integration/recipes/distributed/meta.yaml Outdated Show resolved Hide resolved
continuous_integration/recipes/distributed/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: jakirkham <jakirkham@gmail.com>
@jakirkham jakirkham merged commit 60ce843 into dask:main Mar 11, 2022
@charlesbluca charlesbluca deleted the fix-cython-track-features branch July 20, 2022 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants