docs: mention default value of Client's timeout#5933
Conversation
I got confused by the `no_default` in the docs, and had to read the code to see that `no_default` actually gets replaced with the value of the `distributed.comm.timeouts.connect` configuration. Let's mention it in the docs to save the next person from having to do the same :)
Collaborator
|
Can one of the admins verify this patch? |
Contributor
Member
|
Thank you @1ace and congratulations for your first contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got confused by the
no_defaultin the docs, and had to read the code to see thatno_defaultactually gets replaced with the value of thedistributed.comm.timeouts.connectconfiguration.Let's mention it in the docs to save the next person from having to do the same 🙂