Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention default value of Client's timeout #5933

Merged
merged 1 commit into from Mar 25, 2022
Merged

docs: mention default value of Client's timeout #5933

merged 1 commit into from Mar 25, 2022

Conversation

1ace
Copy link
Contributor

@1ace 1ace commented Mar 11, 2022

I got confused by the no_default in the docs, and had to read the code to see that no_default actually gets replaced with the value of the distributed.comm.timeouts.connect configuration.

Let's mention it in the docs to save the next person from having to do the same 馃檪

I got confused by the `no_default` in the docs, and had to read the code to see that `no_default` actually gets replaced with the value of the `distributed.comm.timeouts.connect` configuration.

Let's mention it in the docs to save the next person from having to do the same :)
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@github-actions
Copy link
Contributor

Unit Test Results

鈦熲勨仧鈥勨堚仧鈥12 files鈥 卤0鈥傗冣仧鈥勨仧鈥勨堚仧鈥12 suites鈥 卤0鈥傗冣5h 30m 20s 鈴憋笍 - 10m 52s
鈦熲2鈥639 tests 卤0鈥傗冣仧鈥2鈥557 鉁旓笍 +3鈥傗冣仧鈥80 馃挙 卤0鈥傗2 鈥-鈥3鈥
12鈥977 runs鈥 卤0鈥傗12鈥338 鉁旓笍 +6鈥傗636 馃挙 鈥-鈥2鈥傗3 鈥-鈥4鈥

For more details on these failures, see this check.

Results for commit 8f3c3f5.鈥兟 Comparison against base commit 2d68dfc.

@fjetter
Copy link
Member

fjetter commented Mar 25, 2022

Thank you @1ace and congratulations for your first contribution! 馃帀

@fjetter fjetter merged commit d667a90 into dask:main Mar 25, 2022
@1ace 1ace deleted the patch-1 branch March 25, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants