Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove check_python_3 (broken with click>=8.1.0) #6018

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

graingert
Copy link
Member

@graingert graingert commented Mar 29, 2022

fixes #6013

  • check_python_3 is redundant on Python 3.7+ and distributed only supports 3.8+
  • _unicodefun was removed on click 8.1.0 which causes check_python_3 to fail

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2022

Unit Test Results

       12 files  +         7         12 suites  +7   6h 4m 10s ⏱️ + 4h 53m 12s
  2 674 tests +  1 472    2 592 ✔️ +  1 434    81 💤 +  46  1  -   8 
15 948 runs  +12 357  15 086 ✔️ +11 649  861 💤 +726  1  - 18 

For more details on these failures, see this check.

Results for commit 00d81dc. ± Comparison against base commit fb78273.

♻️ This comment has been updated with latest results.

@fjetter
Copy link
Member

fjetter commented Mar 29, 2022

Something is broken in the conda build that looks related. There is a traceback that go cannot be imported

@graingert graingert requested a review from fjetter March 29, 2022 12:55
@crusaderky crusaderky merged commit ed48736 into dask:main Mar 29, 2022
@graingert graingert deleted the remove-check-python-3 branch March 29, 2022 14:31
@mrocklin
Copy link
Member

Thanks all for handling this quickly

@jakirkham
Copy link
Member

@graingert do we need to require click 8.1.0+ after this change or will this still work with earlier versions of click?

@graingert
Copy link
Member Author

@graingert do we need to require click 8.1.0+ after this change or will this still work with earlier versions of click?

generally this will still work with earlier versions of click. The code that I removed in the PR was trying to replace a hard failure that was a regular occurrence on python 3.6 and "very rare" on python 3.7+ with a warning. This "very rare" hard failure case is now possible again when running on an old click and a new distributed.

@jakirkham
Copy link
Member

Thanks for clarifying. How old of a version of click is still stable? Perhaps that should determine the lower bound

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name '_unicodefun' from 'click'
5 participants