-
-
Notifications
You must be signed in to change notification settings - Fork 749
remove check_python_3 (broken with click>=8.1.0) #6018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unit Test Results 12 files + 7 12 suites +7 6h 4m 10s ⏱️ + 4h 53m 12s For more details on these failures, see this check. Results for commit 00d81dc. ± Comparison against base commit fb78273. ♻️ This comment has been updated with latest results. |
|
Something is broken in the conda build that looks related. There is a traceback that |
46ba6c6 to
00d81dc
Compare
|
Thanks all for handling this quickly |
|
@graingert do we need to require |
generally this will still work with earlier versions of click. The code that I removed in the PR was trying to replace a hard failure that was a regular occurrence on python 3.6 and "very rare" on python 3.7+ with a warning. This "very rare" hard failure case is now possible again when running on an old click and a new distributed. |
|
Thanks for clarifying. How old of a version of |
fixes #6013
pre-commit run --all-files