Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More idiomatic mypy configuration #6022

Merged
merged 2 commits into from Mar 30, 2022
Merged

More idiomatic mypy configuration #6022

merged 2 commits into from Mar 30, 2022

Conversation

crusaderky
Copy link
Collaborator

Move awkward-looking command-line argument from pre-config to setup.cfg
Now it is possible to run mypy directly from the command line and obtain the same results as in pre-commit (as long as all type stubs are installed).

@crusaderky crusaderky self-assigned this Mar 29, 2022
additional_dependencies:
# Type stubs
- types-docutils
- types-requests
- types-paramiko
- types-PyYAML
- types-psutil
- types-setuptools
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert #6017 - this is still used by mypy to validate setup.py (you can see it by setting ignore_missing_imports = false below)

.pre-commit-config.yaml Show resolved Hide resolved
@crusaderky crusaderky merged commit e6911d9 into dask:main Mar 30, 2022
@crusaderky crusaderky deleted the mypy branch March 30, 2022 01:39
@github-actions
Copy link
Contributor

Unit Test Results

       12 files  ±0         12 suites  ±0   6h 39m 55s ⏱️ + 26m 25s
  2 675 tests ±0    2 589 ✔️  - 3    82 💤  - 1  4 +4 
15 954 runs  ±0  15 093 ✔️ +1  857 💤  - 5  4 +4 

For more details on these failures, see this check.

Results for commit ed91fb2. ± Comparison against base commit 852d5f5.

mrocklin pushed a commit to mrocklin/distributed that referenced this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants