Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use w for writeable branch in pickle_loads #6314

Merged
merged 1 commit into from
May 11, 2022

Conversation

jakirkham
Copy link
Member

Saves the attribute access as it is not needed. Also a bit clearer from a code readability perspective (make writeable when w is True otherwise make readonly when w is False).

  • Tests added / passed
  • Passes pre-commit run --all-files

Saves the attribute access as it is not needed. Also a bit clearer from
a code readability perspective (make writeable when `w is True`
otherwise make readonly when `w is False`).
@jakirkham
Copy link
Member Author

Planning on merging EOD tomorrow if no comments

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2022

Unit Test Results

       16 files  ±    0         16 suites  ±0   7h 17m 3s ⏱️ + 11m 43s
  2 767 tests  -     2    2 689 ✔️ +    1       78 💤  -   2  0  - 1 
22 098 runs  +276  21 078 ✔️ +263  1 020 💤 +17  0  - 4 

Results for commit cc41b3b. ± Comparison against base commit fb1f7d1.

♻️ This comment has been updated with latest results.

@jakirkham jakirkham merged commit e390609 into dask:main May 11, 2022
@jakirkham jakirkham deleted the chk_w_pkl_loads branch May 11, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant