Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to memory trimming documentation #6317

Merged
merged 1 commit into from
May 10, 2022
Merged

Fix link to memory trimming documentation #6317

merged 1 commit into from
May 10, 2022

Conversation

maawoo
Copy link
Contributor

@maawoo maawoo commented May 10, 2022

There is no #memtrim section in https://distributed.dask.org/en/latest/worker.html.
I was looking for the right information when I got this warning message and assume that it moved to https://distributed.dask.org/en/latest/worker-memory.html#memory-not-released-back-to-the-os, right?

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@github-actions
Copy link
Contributor

Unit Test Results

       16 files  ±0         16 suites  ±0   7h 29m 24s ⏱️ + 1m 52s
  2 767 tests ±0    2 687 ✔️ ±0       79 💤 ±0  1 ±0 
22 098 runs  ±0  21 077 ✔️ +1  1 020 💤  - 1  1 ±0 

For more details on these failures, see this check.

Results for commit 7b3387a. ± Comparison against base commit fb1f7d1.

@jrbourbeau jrbourbeau changed the title Fix documentation reference Fix link to memory trimming documentation May 10, 2022
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maawoo, this looks correct to me. Thanks for fixing

Also, I noticed this is your first code contribution to this repository. Welcome!

@jrbourbeau jrbourbeau merged commit 5551a1f into dask:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants