Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_signal and test_terminate occasionally return SIGKILL on MacOS #6671

Merged
merged 2 commits into from Jul 6, 2022
Merged

test_signal and test_terminate occasionally return SIGKILL on MacOS #6671

merged 2 commits into from Jul 6, 2022

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Jul 4, 2022 •
edited

Works around #6393 by xfailing the test in this specific case

@crusaderky crusaderky changed the title Clean up and debug test_signal et al Flaky test_signal and test_terminate Jul 4, 2022
@crusaderky crusaderky changed the title Flaky test_signal and test_terminate test_signal and test_terminate occasionally return SIGKILL on MaOSX Jul 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2022 •
edited

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 36m 40s ⏱️ + 4m 17s
  2 918 tests +1    2 836 ✔️ +  6    79 💤 ±0  3 ❌  - 2 
21 605 runs  +6  20 666 ✔️ +11  936 💤 +3  3 ❌  - 5 

For more details on these failures, see this check.

Results for commit 60123fe. ± Comparison against base commit 1a28011.

♻️ This comment has been updated with latest results.

@crusaderky crusaderky mentioned this pull request Jul 5, 2022
Closed
@crusaderky crusaderky marked this pull request as ready for review July 5, 2022 15:02
@crusaderky crusaderky linked an issue Jul 5, 2022 that may be closed by this pull request
distributed/tests/test_asyncprocess.py::test_signal flaky #6393
Closed
@crusaderky crusaderky changed the title test_signal and test_terminate occasionally return SIGKILL on MaOSX test_signal and test_terminate occasionally return SIGKILL on MacOS Jul 5, 2022
@pentschev pentschev mentioned this pull request Jul 5, 2022
Merged
2 tasks
@crusaderky crusaderky merged commit d88c1d2 into dask:main Jul 6, 2022
@crusaderky crusaderky deleted the test_signal branch July 6, 2022 10:27
@pentschev pentschev mentioned this pull request Jul 6, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikmakait hendrikmakait hendrikmakait approved these changes

@graingert graingert Awaiting requested review from graingert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

distributed/tests/test_asyncprocess.py::test_signal flaky
2 participants
@crusaderky @hendrikmakait