Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have formatQuantLabel always show something #248

Merged
merged 4 commits into from May 12, 2019

Conversation

Projects
None yet
2 participants
@davep
Copy link
Contributor

commented May 6, 2019

The vertical scale of a track can be a little unhelpful if the min and max values are both very small. An example would be this:

image

The min and max values for that track are something like -0.03 and 0.03, but confusingly just show as -0.0 and 0.0.

This change modifies formatQuantLabel in a way that attempts to maintain current functionality while also allowing smaller values to appear.

I've also made this change such that it can handle having a string passed to it. I was far from certain if this was something that happens; a brief test suggested it didn't but I wanted to err on the safe side. If this change is useful and this particular aspect of it isn't necessary, do please feel free to correct.

The PR also includes a correction of the module name in the header comment.

davep added some commits May 6, 2019

Modify formatQuantLabel so it attempts to always show something
As it stood, formatQuantLabel would simply show 0.0 for values in the
browser where the value was "too small". This meant that the upper and lower
values in the vertical "ruler" wouldn't be very helpful for tracks where the
min and max values were rather small.

This change attempts to retain the existing formatting for values that are
significant enough to show something sensible, but also work for smaller
values.

Also, because I'm not 100% sure that the value passed to formatQuantLabel
is *always* numeric, I've attempted to handle being passed a string
representation of a value too.
Correct a handful of module names mentioned in headers
While not really useful to the running of Biodalliance, I noticed them so
decided to "fix" them. Also, as a side-effect of my changes, remove some
trailing whitespace along the way.
@davep

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

Not that it really adds to the main point of this PR, in a1011ec I've also corrected some file names as mentioned in the header comments of the files, where they didn't match the actual file name.

@dasmoth dasmoth merged commit d33c817 into dasmoth:master May 12, 2019

@dasmoth

This comment has been minimized.

Copy link
Owner

commented May 12, 2019

Thank you -- very near solution!

@davep

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

My pleasure; thanks for accepting the PR.

@davep davep deleted the davep:fix-formatQuantLabel branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.