Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up.line-loading animation take +/- 50% CPU #413
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
yoshuawuyts
Jun 4, 2017
Contributor
|
dang yeah, that's no good. Cc/ @Kriesse - should this be turned off?
…On Sun, Jun 4, 2017 at 2:41 PM Geoffrey Bonneville ***@***.***> wrote:
When disabling animation on .line-loading, CPU load is low.
When the animation is enabled, it takes +/- 50% on my 4 threads CPU.
I think chromium/electron GPU acceleration is not enabled on Linux. I
don't know if GPU accel could help much, but still, 50% is high!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#413>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWleo1rLYeMMhkHTMkO7ckcbbk9TWQkks5sAqXigaJpZM4NvXMK>
.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
juliangruber
Jun 7, 2017
Member
we also have a web version of this animation here: http://datproject.github.io/design/
can you see if this gives you the same kind of performance in a regular browser on your machine?
|
we also have a web version of this animation here: http://datproject.github.io/design/ can you see if this gives you the same kind of performance in a regular browser on your machine? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Kriesse
Jun 7, 2017
Collaborator
@juliangruber @yoshuawuyts Looking into this –I can reproduce high CPU load when downloading a dat, but not sure it's tied to the animation, but maybe the fact that we have a full repaint every time the download speed updates – trying to figure out what is happening exactly. @juliangruber let's debug together?
|
@juliangruber @yoshuawuyts Looking into this –I can reproduce high CPU load when downloading a dat, but not sure it's tied to the animation, but maybe the fact that we have a full repaint every time the download speed updates – trying to figure out what is happening exactly. @juliangruber let's debug together? |
Kriesse
added
Priority: Medium
Type: Bug
labels
Jun 7, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@G-Ray what's your linux setup? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
let's first try to reproduce :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
G-Ray
Jun 8, 2017
@juliangruber @Kriesse I confirm that when I open http://datproject.github.io/design/ my cpu is around 50%.
My setup: Fedora 25 + chromium 58 on a xps-13 (i7-7500u)
G-Ray
commented
Jun 8, 2017
|
@juliangruber @Kriesse I confirm that when I open http://datproject.github.io/design/ my cpu is around 50%. My setup: Fedora 25 + chromium 58 on a xps-13 (i7-7500u) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
cool, i'll try later with my ubuntu vm! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
juliangruber
Jun 9, 2017
Member
I can confirm, this is the same on my ubuntu vm. @Kriesse shall we disable the animation on linux?
|
I can confirm, this is the same on my ubuntu vm. @Kriesse shall we disable the animation on linux? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@juliangruber Yup, works for me! |
G-Ray commentedJun 4, 2017
When disabling animation on .line-loading, CPU load is low.
When the animation is enabled, it takes +/- 50% on my 4 threads CPU.
I think chromium/electron GPU acceleration is not enabled on Linux. I don't know if GPU accel could help much, but still, 50% is high!