New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.line-loading animation take +/- 50% CPU #413

Open
G-Ray opened this Issue Jun 4, 2017 · 10 comments

Comments

Projects
None yet
4 participants
@G-Ray

G-Ray commented Jun 4, 2017

When disabling animation on .line-loading, CPU load is low.
When the animation is enabled, it takes +/- 50% on my 4 threads CPU.

I think chromium/electron GPU acceleration is not enabled on Linux. I don't know if GPU accel could help much, but still, 50% is high!

@yoshuawuyts

This comment has been minimized.

Show comment
Hide comment
@yoshuawuyts

yoshuawuyts Jun 4, 2017

Contributor
Contributor

yoshuawuyts commented Jun 4, 2017

@juliangruber

This comment has been minimized.

Show comment
Hide comment
@juliangruber

juliangruber Jun 7, 2017

Member

we also have a web version of this animation here: http://datproject.github.io/design/

can you see if this gives you the same kind of performance in a regular browser on your machine?

Member

juliangruber commented Jun 7, 2017

we also have a web version of this animation here: http://datproject.github.io/design/

can you see if this gives you the same kind of performance in a regular browser on your machine?

@Kriesse

This comment has been minimized.

Show comment
Hide comment
@Kriesse

Kriesse Jun 7, 2017

Collaborator

@juliangruber @yoshuawuyts Looking into this –I can reproduce high CPU load when downloading a dat, but not sure it's tied to the animation, but maybe the fact that we have a full repaint every time the download speed updates – trying to figure out what is happening exactly. @juliangruber let's debug together?

Collaborator

Kriesse commented Jun 7, 2017

@juliangruber @yoshuawuyts Looking into this –I can reproduce high CPU load when downloading a dat, but not sure it's tied to the animation, but maybe the fact that we have a full repaint every time the download speed updates – trying to figure out what is happening exactly. @juliangruber let's debug together?

@juliangruber

This comment has been minimized.

Show comment
Hide comment
@juliangruber

juliangruber Jun 7, 2017

Member

@G-Ray what's your linux setup?

Member

juliangruber commented Jun 7, 2017

@G-Ray what's your linux setup?

@juliangruber

This comment has been minimized.

Show comment
Hide comment
@juliangruber

juliangruber Jun 7, 2017

Member

let's first try to reproduce :)

Member

juliangruber commented Jun 7, 2017

let's first try to reproduce :)

@G-Ray

This comment has been minimized.

Show comment
Hide comment
@G-Ray

G-Ray Jun 8, 2017

@juliangruber @Kriesse I confirm that when I open http://datproject.github.io/design/ my cpu is around 50%.

My setup: Fedora 25 + chromium 58 on a xps-13 (i7-7500u)

G-Ray commented Jun 8, 2017

@juliangruber @Kriesse I confirm that when I open http://datproject.github.io/design/ my cpu is around 50%.

My setup: Fedora 25 + chromium 58 on a xps-13 (i7-7500u)

@juliangruber

This comment has been minimized.

Show comment
Hide comment
@juliangruber

juliangruber Jun 9, 2017

Member

cool, i'll try later with my ubuntu vm!

Member

juliangruber commented Jun 9, 2017

cool, i'll try later with my ubuntu vm!

@juliangruber

This comment has been minimized.

Show comment
Hide comment
@juliangruber

juliangruber Jun 9, 2017

Member

I can confirm, this is the same on my ubuntu vm. @Kriesse shall we disable the animation on linux?

Member

juliangruber commented Jun 9, 2017

I can confirm, this is the same on my ubuntu vm. @Kriesse shall we disable the animation on linux?

@Kriesse

This comment has been minimized.

Show comment
Hide comment
@Kriesse

Kriesse Jun 14, 2017

Collaborator

@juliangruber Yup, works for me!

Collaborator

Kriesse commented Jun 14, 2017

@juliangruber Yup, works for me!

@juliangruber

This comment has been minimized.

Show comment
Hide comment
@juliangruber
Member

juliangruber commented Jun 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment