Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed makefile and added "offsets" output format #2

Merged
merged 1 commit into from Jan 18, 2013

Conversation

Projects
None yet
2 participants
Contributor

seanlavelle commented Nov 16, 2012

The makefile had a hardcoded path to servlet-api.jar in /opt/tomcat which is not where my tomcat lives. I committed the jar to the repo instead so it should work for anyone. The makefile also uses pushd and popd which made it fail on my system until I added "SHELL = /bin/bash"

I made it so you can set "outputFormat=offsets" in a post and it will output the results of the classifyToCharacterOffsets() method. This makes it tell you the positions in the document where it finds things, instead of adding markup to the text of the document.

I also made it wrap exceptions when rethrowing so the stacktraces contain as much info as possible (almost always a good idea).

dat added a commit that referenced this pull request Jan 18, 2013

Merge pull request #2 from seanlavelle/master
Fixed makefile and added "offsets" output format

@dat dat merged commit ca65e85 into dat:master Jan 18, 2013

Owner

dat commented Jan 18, 2013

Thanks! I've merged your request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment