Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Circle's radius argument to area #409

Open
wants to merge 3 commits into
base: master
from

Conversation

@adnanhemani
Copy link
Collaborator

commented Aug 13, 2019

[N/A] Wrote test for feature (re-ran tests and all pass, including the tests that should trigger a warning now)
[X] Added changes to CHANGELOG.md
[X] Bumped version number (delete if unneeded)

Changes proposed:
Closes #407. The reasoning behind this change is also listed in the same PR.

adnanhemani added 2 commits Aug 13, 2019

@adnanhemani adnanhemani requested a review from davidwagner Aug 13, 2019

@davidwagner

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

Unfortunately there are now some conflicts, and the proper method for merging is not entirely obvious to me. @adnanhemani , can you update this PR accordingly, and then ping me for another review? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.