Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libgfortran dependency #412

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@davidwagner
Copy link
Member

commented Sep 16, 2019

Changes proposed:
Builds on Travis were failing because of a dependency on installing libgfortran via conda. I'm not sure that we ever used that for anything, so I removed it; everything still seems to work.

@davidwagner davidwagner requested a review from adnanhemani Sep 16, 2019
@davidwagner

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2019

@adnanhemani , could you review this to check that I'm not doing something stupid or that there's some reason I'm missing why we need a libgfortran dependency? Thanks!

@adnanhemani

This comment has been minimized.

Copy link
Collaborator

commented Sep 16, 2019

So I looked through the Git blame...seems like @SamLau95 add it in a commit for the Linux environment (seems like it was done on purpose). I'm not sure of any reason why we'd need it (I don't see any code that would be dependent on it) - but I'm guessing only @SamLau95 can tell us why it was added?

@SamLau95

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

Sadly I don't remember why it was added. Chances are it was autogenerated from conda. If it makes the build work, then I say let's remove it.

@davidwagner davidwagner merged commit ec024b2 into master Sep 17, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on travis_doesnt_like_libgfortran at 75.967%
Details
@davidwagner davidwagner deleted the travis_doesnt_like_libgfortran branch Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.