Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug from previous version #413

Merged
merged 4 commits into from Sep 17, 2019

Conversation

@adnanhemani
Copy link
Collaborator

commented Sep 16, 2019

[N/A] Wrote test for feature
[X] Added changes to CHANGELOG.md
[X] Bumped version number (delete if unneeded)

Changes proposed:
Fixed a bug and cleaned up code inadvertently introduced by v0.15.1. The issue related to the fact that slicing NumPy arrays only provides a view into the original array rather than creating a copy. This caused the overall bins to get written every time the particular line of code was run. Also cleans up print statements that were probably left behind from debugging.

adnanhemani added 2 commits Sep 16, 2019
@adnanhemani adnanhemani requested review from rameshvs and davidwagner Sep 16, 2019
@@ -2638,9 +2638,15 @@ def prepare_hist_with_group(group):
values_dict = collections.OrderedDict(values_dict)
if left_end is not None or right_end is not None:
if left_end is None:
left_end = min([min(self.column(k)) for k in self.labels if np.issubdtype(self.column(k).dtype, np.number)])
if bins[0]:

This comment has been minimized.

Copy link
@adnanhemani

adnanhemani Sep 16, 2019

Author Collaborator

These new checks are for making sure that if the user specifies bins, then the histogram shading goes all the way to the edge of the first/last bin

adnanhemani added 2 commits Sep 16, 2019
Accidentally added
Accidentally added
@davidwagner davidwagner merged commit 23b4f5f into master Sep 17, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
@davidwagner davidwagner deleted the fix_version_15_2 branch Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.