Skip to content

Conversation

@ev-br
Copy link
Member

@ev-br ev-br commented Nov 24, 2025

Implement the suggestion from HypothesisWorks/hypothesis#4606 (comment)

Note: this PR is fully drafted by Copilot. The full history of prompts is at ev-br#2
My act is only to provide prompts and review the resulting PR.

The patch itself is fairly trivial. The trick is that it's a first patch prepared by a bot. So this should probably serve as a blueprint of how we want to deal with bot-authored commits.
Yay/nay @rgommers @kgryte @asmeurer ?

If we go with it, my plan is to squash-merge the PR, edit the commit message and keep copilot's authorship.

Copilot AI and others added 6 commits November 24, 2025 14:44
Co-authored-by: ev-br <2133832+ev-br@users.noreply.github.com>
Co-authored-by: ev-br <2133832+ev-br@users.noreply.github.com>
Co-authored-by: ev-br <2133832+ev-br@users.noreply.github.com>
@ev-br
Copy link
Member Author

ev-br commented Nov 24, 2025

To clarify my position: I think it's OK to merge this kind of bot-generated patches, provided

  • they are reviewed with the same level of scrutiny as PRs from a human I never met behind a github username I never seen.
  • The reviewer information is somehow recorded in the commit message. Specific way TBD: reviewed-by or signed-off-by from one of us with the commit bit.

The remaining concern is around copyright, as detailed at length at the Discourse thread.

@rgommers
Copy link
Member

rgommers commented Dec 1, 2025

I think it's OK to merge this kind of bot-generated patches, provided

That seems fine to me for this project.

The remaining concern is around copyright

Yes, copyrightable contributions need separate discussion I think. This one isn't copyrightable though, the only nontrivial content comes directly from Hypothesis and a review comment by a Hypothesis maintainer. So all good to move ahead here.

@ev-br ev-br merged commit b4038ce into data-apis:master Dec 1, 2025
5 checks passed
ev-br added a commit to ev-br/array-api-tests that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants