From 192901abc04dbce839bcdaddb33aefcc33cd6db1 Mon Sep 17 00:00:00 2001
From: Marco Edward Gorelli <marcogorelli@protonmail.com>
Date: Fri, 4 Aug 2023 12:34:01 +0100
Subject: [PATCH] Don't let Column.name be None (#223)

* unnunnable-ify name

* allow default empty string name

* optionality

* fixup
---
 spec/API_specification/dataframe_api/__init__.py      | 6 +++---
 spec/API_specification/dataframe_api/column_object.py | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/spec/API_specification/dataframe_api/__init__.py b/spec/API_specification/dataframe_api/__init__.py
index 70b826bb..1160eb9a 100644
--- a/spec/API_specification/dataframe_api/__init__.py
+++ b/spec/API_specification/dataframe_api/__init__.py
@@ -63,7 +63,7 @@ def concat(dataframes: Sequence[DataFrame]) -> DataFrame:
     """
     ...
 
-def column_from_sequence(sequence: Sequence[Any], *, name: str | None, dtype: Any) -> Column[Any]:
+def column_from_sequence(sequence: Sequence[Any], *, dtype: Any, name: str = '') -> Column[Any]:
     """
     Construct Column from sequence of elements.
 
@@ -109,7 +109,7 @@ def dataframe_from_dict(data: Mapping[str, Column[Any]]) -> DataFrame:
     ...
 
 
-def column_from_1d_array(array: Any, *, name: str, dtype: Any) -> Column[Any]:
+def column_from_1d_array(array: Any, *, dtype: Any, name: str = '') -> Column[Any]:
     """
     Construct Column from 1D array.
 
@@ -123,7 +123,7 @@ def column_from_1d_array(array: Any, *, name: str, dtype: Any) -> Column[Any]:
     ----------
     array : array
         array-API compliant 1D array
-    name : str
+    name : str, optional
         Name to give columns.
     dtype : DType
         Dtype of column.
diff --git a/spec/API_specification/dataframe_api/column_object.py b/spec/API_specification/dataframe_api/column_object.py
index 4bb9c6fe..dab7328f 100644
--- a/spec/API_specification/dataframe_api/column_object.py
+++ b/spec/API_specification/dataframe_api/column_object.py
@@ -47,7 +47,7 @@ def column(self) -> Any:
         ...
     
     @property
-    def name(self) -> str | None:
+    def name(self) -> str:
         """Return name of column."""
 
     def __len__(self) -> int:
@@ -724,7 +724,7 @@ def to_array_object(self, dtype: Any) -> Any:
         ``array-api-compat`` package to convert it to a Standard-compliant array.
         """
 
-    def rename(self, name: str | None) -> Column[DType]:
+    def rename(self, name: str) -> Column[DType]:
         """
         Rename column.