Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chris Denniston Final Project #31

Closed

Conversation

Projects
None yet
5 participants
@octopuscabbage
Copy link
Contributor

commented Apr 30, 2019

Contains code for both of my projects

joelthe1 and others added some commits Apr 12, 2019

@SachitNayak

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

Bro you have conflicting files here! Please do not change the named_entity/ner.py, because all of others' code are dependent on it, as it is a shared file on the group!! Please make an edit to your PR.

@SachitNayak
Copy link
Contributor

left a comment

Please remove the conflicts with group 6's shared ner.py file! Entire group 6 is sharing the same ner.py file and changes made by PR will affect the rest of us badly, as our code depends on the shared ner.py file.

@ken-dall

This comment has been minimized.

Copy link

commented Apr 30, 2019

+1 from @SachitNayak . looks like this would delete the parent class [ner.py] file outright

@ken-dall
Copy link

left a comment

This PR would remove /extraction/named_entity/ner.py [which is the parent class that everyone should be inheriting]. Not acceptable, Please do not allow.

@Lakshya-Kejriwal

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

I am also using the original ner.py file. Since I am doing a relative import accepting this PR will cause my code to crash. Please update your PR.

@octopuscabbage

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

I am in the middle of changing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.