Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upChris Denniston Final Project #31
Conversation
joelthe1
and others
added some commits
Apr 12, 2019
This comment has been minimized.
This comment has been minimized.
|
Bro you have conflicting files here! Please do not change the named_entity/ner.py, because all of others' code are dependent on it, as it is a shared file on the group!! Please make an edit to your PR. |
SachitNayak
suggested changes
Apr 30, 2019
|
Please remove the conflicts with group 6's shared ner.py file! Entire group 6 is sharing the same ner.py file and changes made by PR will affect the rest of us badly, as our code depends on the shared ner.py file. |
This comment has been minimized.
This comment has been minimized.
ken-dall
commented
Apr 30, 2019
|
+1 from @SachitNayak . looks like this would delete the parent class [ner.py] file outright |
ken-dall
suggested changes
Apr 30, 2019
ken-dall left a comment
|
This PR would remove /extraction/named_entity/ner.py [which is the parent class that everyone should be inheriting]. Not acceptable, Please do not allow. |
This comment has been minimized.
This comment has been minimized.
|
I am also using the original |
This comment has been minimized.
This comment has been minimized.
|
I am in the middle of changing it |
octopuscabbage commentedApr 30, 2019
Contains code for both of my projects