add support for accessing cloud/restricted environments #18
Conversation
docs/Elasticsearch-batchsink.md
Outdated
| **es.idField:** The field that will determine the id for the document; it should match a fieldname | ||
| in the Structured Record of the input. (Macro-enabled) | ||
|
|
||
| **additionalProperties:** Additional properties to use with the es-hadoop client when writing the data, |
There was a problem hiding this comment.
Can we change it to "Additional Properties"
There was a problem hiding this comment.
Also, can we add a KV with K drop-down so that it becomes easier for user ?
There was a problem hiding this comment.
@nitinmotgi do you mean instead of a JSON text box, we should use a KV dropdown component? Can you point me to any doc I can refer to add it?
There was a problem hiding this comment.
@nitinmotgi please ignore the above. I got the reference from other plugins. Let me make the changes.
shubhampatil17
force-pushed
the
PLUGIN-169-es-restricted-env-support
branch
2 times, most recently
from
8854049 to
a0eecb7
Compare
|
@nitinmotgi I have replaced the JSON widget with KeyValue widget but I am not able to figure out the K-dropdown part. I referred to the documentation (https://docs.cask.co/cdap/6.1.1/en/developer-manual/pipelines/developing-plugins/presentation-plugins.html#plugin-widgets). I see I can use the KeyValueDropdown widget but it will be V-dropdown KV. Can you please point me in the right direction on how to achieve K-dropdown KV ? |
shubhampatil17
force-pushed
the
PLUGIN-169-es-restricted-env-support
branch
from
a0eecb7 to
8f852e5
Compare
shubhampatil17
force-pushed
the
PLUGIN-169-es-restricted-env-support
branch
from
8f852e5 to
bd4dcdf
Compare
|
@ajainaryan could you plz help shubham |
|
@nitinmotgi As Ajai mentioned on the slack channel, we currently don't have keydropdown-value widget supported and it will need to be developed in cdap-ui (probably in current dev version 6.3.0-SNAPSHOT). I am working on it in parallel but will take some time as I am not much familiar with UI dev and will involve some learning curve. What do you suggest as the next plan of action? Should we wait till that part is complete or should we go ahead with keyvalue widget for now and then I can come back and modify it to keydropdown-value in the next version (probably 1.10.1-SNAPSHOT) ? Also one more question, how can we push this keydropdown-value widget to older CDAP version (<=6.2.0) ? I am using 6.1.1 in production where this plugin is required. |
|
@nitinmotgi All code changes done as discussed. Please review once more. |
|
Thanks for the PR. Merging. |
2 participants
No description provided.