Skip to content

Conversation

@pan93412
Copy link
Member

@pan93412 pan93412 commented Nov 30, 2025

  • chore: upgrade dependencies
  • chore: update schema

Summary by CodeRabbit

  • New Features
    • Questions now support visibility scope settings, allowing you to control who can view each question and filter questions based on visibility preferences.

✏️ Tip: You can customize this high-level summary in your review settings.

@pan93412 pan93412 self-assigned this Nov 30, 2025
@vercel
Copy link

vercel bot commented Nov 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
admin-frontend Ready Ready Preview Comment Nov 30, 2025 5:20am

@coderabbitai
Copy link

coderabbitai bot commented Nov 30, 2025

Walkthrough

The changes extend the Question type in the GraphQL schema and generated TypeScript types to support visibility scope configuration. This includes input fields for creating and updating questions with a visibility scope, output representation of the field, and comprehensive filtering predicates in the where input. Package dependencies are also updated to newer versions across development and runtime tooling.

Changes

Cohort / File(s) Summary
GraphQL Schema & Generated Types
schema.graphql, gql/graphql.ts
Added visibility scope support to Question type: CreateQuestionInput and UpdateQuestionInput now accept visibleScope and clearVisibleScope; Question type exposes visibleScope; QuestionWhereInput gains 15 visibleScope predicates (contains, containsFold, equalFold, GT, GTE, HasPrefix, HasSuffix, In, IsNil, LT, LTE, NEQ, NotIn, NotNil, and base field).
Package Dependencies
package.json
Updated 13 dependencies and devDependencies including @graphql-codegen/\* packages, React/React DOM canary builds, Next.js, lucide-react, react-hook-form, zod, and related ESLint/TypeScript tooling to newer versions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Dependency updates follow a straightforward version-bump pattern with no breaking changes indicated
  • Schema and GraphQL type additions follow a repetitive, consistent pattern of adding the same visibleScope field and its filtering predicates across three input/output entities
  • Changes are homogeneous and predictable, requiring primarily verification of version compatibility and schema consistency

Poem

🐰 A scope of sight, both wide and bright,
Questions now can hide from sight!
With predicates to filter and find,
Visibility becomes by design—designed!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes, which are dependency upgrades and schema updates across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upgrade-dependencies-1130

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbc8e80 and cdcbe71.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • gql/graphql.ts (5 hunks)
  • package.json (3 hunks)
  • schema.graphql (5 hunks)
🔇 Additional comments (4)
schema.graphql (1)

74-77: LGTM! Clean schema extension for question visibility.

The visibleScope field addition is well-structured and consistent across all relevant types (CreateQuestionInput, Question, QuestionWhereInput, UpdateQuestionInput). The field is optional throughout, maintaining backward compatibility, and includes comprehensive filtering predicates as expected from ent-generated schemas.

Also applies to: 747-750, 888-903, 1192-1192, 1203-1206

package.json (2)

24-24: LGTM! Routine dependency upgrades.

The remaining dependency upgrades are minor and patch-level updates that should be low-risk. These include GraphQL codegen tools, UI libraries, and dev tooling upgrades.

Also applies to: 48-48, 53-53, 60-60, 64-77


38-38: The package versions referenced in the review do not exist. The @swc-contrib/plugin-graphql-codegen-client-preset package currently publishes versions in the 0.3.x–0.4.x range (latest 0.4.3), not 0.9 or 0.12.1. Verify that the package.json entry is correct or refers to a different package.

Likely an incorrect or invalid review comment.

gql/graphql.ts (1)

80-81: LGTM! Generated TypeScript types align with schema changes.

The generated TypeScript types correctly reflect the visibleScope field additions from schema.graphql. All types (CreateQuestionInput, Question, QuestionWhereInput, UpdateQuestionInput) include the appropriate nullable/optional field definitions and comprehensive predicates.

Also applies to: 864-865, 1016-1031, 1327-1327, 1338-1339

@pan93412 pan93412 merged commit c06f20f into main Nov 30, 2025
4 checks passed
@pan93412 pan93412 deleted the upgrade-dependencies-1130 branch November 30, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants