-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade dependencies (2025/11/30) #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThe changes extend the Question type in the GraphQL schema and generated TypeScript types to support visibility scope configuration. This includes input fields for creating and updating questions with a visibility scope, output representation of the field, and comprehensive filtering predicates in the where input. Package dependencies are also updated to newer versions across development and runtime tooling. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
gql/graphql.ts(5 hunks)package.json(3 hunks)schema.graphql(5 hunks)
🔇 Additional comments (4)
schema.graphql (1)
74-77: LGTM! Clean schema extension for question visibility.The
visibleScopefield addition is well-structured and consistent across all relevant types (CreateQuestionInput, Question, QuestionWhereInput, UpdateQuestionInput). The field is optional throughout, maintaining backward compatibility, and includes comprehensive filtering predicates as expected from ent-generated schemas.Also applies to: 747-750, 888-903, 1192-1192, 1203-1206
package.json (2)
24-24: LGTM! Routine dependency upgrades.The remaining dependency upgrades are minor and patch-level updates that should be low-risk. These include GraphQL codegen tools, UI libraries, and dev tooling upgrades.
Also applies to: 48-48, 53-53, 60-60, 64-77
38-38: The package versions referenced in the review do not exist. The@swc-contrib/plugin-graphql-codegen-client-presetpackage currently publishes versions in the 0.3.x–0.4.x range (latest 0.4.3), not 0.9 or 0.12.1. Verify that the package.json entry is correct or refers to a different package.Likely an incorrect or invalid review comment.
gql/graphql.ts (1)
80-81: LGTM! Generated TypeScript types align with schema changes.The generated TypeScript types correctly reflect the
visibleScopefield additions from schema.graphql. All types (CreateQuestionInput, Question, QuestionWhereInput, UpdateQuestionInput) include the appropriate nullable/optional field definitions and comprehensive predicates.Also applies to: 864-865, 1016-1031, 1327-1327, 1338-1339
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.