From 229f277293a57ba2d91ba274e4833146acb6b876 Mon Sep 17 00:00:00 2001 From: BohuTANG Date: Thu, 18 Sep 2025 13:39:08 +0800 Subject: [PATCH] fix(query): reduce redundant result-set-spill logs during query waits During long-running SQL queries, the system repeatedly logs empty pages with rows=0 which creates excessive log noise. This change only logs non-empty pages and final completion status. Changes: - Skip logging empty pages (rows=0) during query execution - Only log when pages contain actual data (rows>0) - Log final completion status when query ends with empty page - Preserve all error and cleanup logs for debugging This significantly reduces log volume while maintaining visibility into actual data processing and query completion. --- .../src/servers/http/v1/query/page_manager.rs | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/query/service/src/servers/http/v1/query/page_manager.rs b/src/query/service/src/servers/http/v1/query/page_manager.rs index bba28b16444f4..503f493e21748 100644 --- a/src/query/service/src/servers/http/v1/query/page_manager.rs +++ b/src/query/service/src/servers/http/v1/query/page_manager.rs @@ -80,17 +80,20 @@ impl PageManager { let duration_ms = start_time.elapsed().as_millis(); log::debug!(num_row, wait_type:? = wait; "collect_new_page"); - log::info!( - target: "result-set-spill", - "[RESULT-SET-SPILL] Page received page_no={}, rows={}, total_rows={}, end={}, duration_ms={}", - self.total_pages, num_row, self.total_rows + num_row, end, duration_ms - ); - if num_row == 0 { + // Only log non-empty pages to avoid spam during long SQL waits + if num_row > 0 { + log::info!( + target: "result-set-spill", + "[RESULT-SET-SPILL] Page received page_no={}, rows={}, total_rows={}, end={}, duration_ms={}", + self.total_pages, num_row, self.total_rows + num_row, end, duration_ms + ); + } else if end { + // Only log empty page when query ends log::info!( target: "result-set-spill", - "[RESULT-SET-SPILL] Empty page page_no={}, end={}", - self.total_pages, end + "[RESULT-SET-SPILL] Query completed with empty final page page_no={}, total_rows={}", + self.total_pages, self.total_rows ); }