Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename setup_logger #8

Closed
nsheff opened this issue May 13, 2019 · 2 comments
Closed

rename setup_logger #8

nsheff opened this issue May 13, 2019 · 2 comments
Assignees
@vreuter
Labels
question Further information is requested

Comments

@nsheff
Copy link
Member

nsheff commented May 13, 2019

should we rename setup_logger to set_up_logger ?

I think of setup as a noun and set_up as a verb, so setup_logger feels strange to me. not a big deal but since we're early enough in use might be worth it...
@nsheff nsheff added the question Further information is requested label May 13, 2019
@nsheff
Copy link
Member Author

nsheff commented May 13, 2019

or maybe init_logger

@vreuter vreuter self-assigned this May 13, 2019
@vreuter
Copy link
Member

vreuter commented May 13, 2019

sounds good to me

@nsheff nsheff closed this as completed in 06761c7 Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vreuter vreuter

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nsheff @vreuter