Fix databricks configure if new profile is specified
#1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ified The code included the to-be-created profile in the configuration and that triggered the SDK to try and load it. Instead, we must use the specified host and token directly.
andrewnester
approved these changes
Nov 30, 2023
| @@ -42,7 +42,11 @@ func configureInteractive(cmd *cobra.Command, flags *configureFlags, cfg *config | |||
|
|
|||
| // Ask user to specify a cluster if not already set. | |||
| if flags.ConfigureCluster && cfg.ClusterID == "" { | |||
| w, err := databricks.NewWorkspaceClient((*databricks.Config)(cfg)) | |||
| // Create workspace client with configuration without the profile name set. | |||
| w, err := databricks.NewWorkspaceClient(&databricks.Config{ | |||
There was a problem hiding this comment.
Are there any other fields from cfg which we might potentially need?
There was a problem hiding this comment.
No, because we only set Host and Token in the rest of the command.
When we do a more involved auth wizard, we should carry over all relevant attributes except the profile.
pietern
added a commit
that referenced
this pull request
Nov 30, 2023
This is a bugfix release to address issues with v0.210.0. CLI: * Fix `panic: $HOME is not set` ([#1027](#1027)). * Fix `databricks configure` if new profile is specified ([#1030](#1030)). * Filter out system clusters for `--configure-cluster` ([#1031](#1031)). Bundles: * Fixed panic when job has trigger and in development mode ([#1026](#1026)). Internal: * Use `fetch-tags` option in release workflows ([#1025](#1025)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
This is a bugfix release to address issues with v0.210.0. CLI: * Fix `panic: $HOME is not set` ([#1027](#1027)). * Fix `databricks configure` if new profile is specified ([#1030](#1030)). * Filter out system clusters for `--configure-cluster` ([#1031](#1031)). Bundles: * Fixed panic when job has trigger and in development mode ([#1026](#1026)). Internal: * Use `fetch-tags` option in release workflows ([#1025](#1025)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The code included the to-be-created profile in the configuration and that triggered the SDK to try and load it. Instead, we must use the specified host and token directly.
Tests
Manually. More integration test coverage tbd.