Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default template #1046

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Conversation

lennartkats-db
Copy link
Contributor

Changes

  • Tweak strings, documentation in template
  • Extend requirements-dev.txt with setuptools/wheel for building whl files
  • Clarify what the "_job.yml" file is for for users who are only interested in DLT pipelines (answering a question that came up recently)

Tests

Existing tests exercise this template

@lennartkats-db lennartkats-db marked this pull request as ready for review December 7, 2023 20:53
Copy link
Contributor

@PaulCornellDB PaulCornellDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. See my comments and proposed edits throughout.

@lennartkats-db
Copy link
Contributor Author

Thanks for the thorough feedback, @PaulCornellDB!

@pietern pietern changed the title Default template TLC Improve default template Dec 11, 2023
@lennartkats-db lennartkats-db removed the request for review from shreyas-goenka December 11, 2023 19:07
@lennartkats-db lennartkats-db added this pull request to the merge queue Dec 11, 2023
Merged via the queue into databricks:main with commit 8b9930a Dec 11, 2023
4 checks passed
@lennartkats-db lennartkats-db deleted the tweak-template branch December 11, 2023 19:19
andrewnester added a commit that referenced this pull request Dec 13, 2023
Bundles:
 * Improve default template ([#1046](#1046)).
 * Fix passthrough of pipeline notifications ([#1058](#1058)).

Internal:
 * Stub out Python virtual environment installation for `labs` commands ([#1057](#1057)).
 * Upgrade Terraform schema version to v1.31.1 ([#1055](#1055)).

Dependency updates:
 * Bump github.com/hashicorp/hc-install from 0.6.1 to 0.6.2 ([#1054](#1054)).
 * Bump github.com/databricks/databricks-sdk-go from 0.26.1 to 0.26.2 ([#1053](#1053)).
@andrewnester andrewnester mentioned this pull request Dec 13, 2023
github-merge-queue bot pushed a commit that referenced this pull request Dec 13, 2023
Bundles:
* Improve default template
([#1046](#1046)).
* Fix passthrough of pipeline notifications
([#1058](#1058)).

Internal:
* Stub out Python virtual environment installation for `labs` commands
([#1057](#1057)).
* Upgrade Terraform schema version to v1.31.1
([#1055](#1055)).


Dependency updates:
* Bump github.com/hashicorp/hc-install from 0.6.1 to 0.6.2
([#1054](#1054)).
* Bump github.com/databricks/databricks-sdk-go from 0.26.1 to 0.26.2
([#1053](#1053)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants