Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passthrough of pipeline notifications #1058

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Dec 12, 2023

Changes

Notifications weren't passed along because of a plural vs singular mismatch.

Tests

  • Added unit test coverage.
  • Manually confirmed it now works in an example bundle.

@pietern pietern added this pull request to the merge queue Dec 12, 2023
Merged via the queue into main with commit 37671d9 Dec 12, 2023
4 checks passed
@pietern pietern deleted the pipeline-notifications-fix branch December 12, 2023 11:41
andrewnester added a commit that referenced this pull request Dec 13, 2023
Bundles:
 * Improve default template ([#1046](#1046)).
 * Fix passthrough of pipeline notifications ([#1058](#1058)).

Internal:
 * Stub out Python virtual environment installation for `labs` commands ([#1057](#1057)).
 * Upgrade Terraform schema version to v1.31.1 ([#1055](#1055)).

Dependency updates:
 * Bump github.com/hashicorp/hc-install from 0.6.1 to 0.6.2 ([#1054](#1054)).
 * Bump github.com/databricks/databricks-sdk-go from 0.26.1 to 0.26.2 ([#1053](#1053)).
@andrewnester andrewnester mentioned this pull request Dec 13, 2023
github-merge-queue bot pushed a commit that referenced this pull request Dec 13, 2023
Bundles:
* Improve default template
([#1046](#1046)).
* Fix passthrough of pipeline notifications
([#1058](#1058)).

Internal:
* Stub out Python virtual environment installation for `labs` commands
([#1057](#1057)).
* Upgrade Terraform schema version to v1.31.1
([#1055](#1055)).


Dependency updates:
* Bump github.com/hashicorp/hc-install from 0.6.1 to 0.6.2
([#1054](#1054)).
* Bump github.com/databricks/databricks-sdk-go from 0.26.1 to 0.26.2
([#1053](#1053)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants