diff --git a/.codegen/service.go.tmpl b/.codegen/service.go.tmpl index c8d50adfaf..77de455983 100644 --- a/.codegen/service.go.tmpl +++ b/.codegen/service.go.tmpl @@ -113,7 +113,7 @@ func New() *cobra.Command { // Functions can be added from the `init()` function in manually curated files in this directory. var {{.CamelName}}Overrides []func( *cobra.Command, - {{- if .Request }} + {{- if not .IsLegacyEmptyRequest }} *{{.Service.Package.Name}}.{{.Request.PascalName}}, {{- end }} ) @@ -124,7 +124,7 @@ func new{{.PascalName}}() *cobra.Command { cmd := &cobra.Command{} {{- $canUseJson := and .CanUseJson (not (in $excludeFromJson .KebabName )) -}} - {{- if .Request}} + {{- if not .IsLegacyEmptyRequest}} var {{.CamelName}}Req {{.Service.Package.Name}}.{{.Request.PascalName}} {{- if .RequestBodyField }} @@ -146,7 +146,7 @@ func new{{.PascalName}}() *cobra.Command { {{- if .RequestBodyField -}} {{- $request = .RequestBodyField.Entity -}} {{- end -}} - {{if $request }}// TODO: short flags + {{if $request }} {{- if $canUseJson}} cmd.Flags().Var(&{{.CamelName}}Json, "json", `either inline JSON string or @path/to/file.json with request body`) {{- end}} @@ -188,7 +188,7 @@ func new{{.PascalName}}() *cobra.Command { {{- $wait := and .Wait (and (not .IsCrudRead) (not (eq .SnakeName "get_run"))) -}} {{- $hasRequiredArgs := and (not $hasIdPrompt) $hasPosArgs -}} {{- $hasSingleRequiredRequestBodyFieldWithPrompt := and (and $hasIdPrompt $request) (eq 1 (len $request.RequiredRequestBodyFields)) -}} - {{- $onlyPathArgsRequiredAsPositionalArguments := and .Request (eq (len .RequiredPositionalArguments) (len .Request.RequiredPathFields)) -}} + {{- $onlyPathArgsRequiredAsPositionalArguments := and (not .IsLegacyEmptyRequest) (eq (len .RequiredPositionalArguments) (len .Request.RequiredPathFields)) -}} {{- $hasDifferentArgsWithJsonFlag := and (not $onlyPathArgsRequiredAsPositionalArguments) (and $canUseJson (or $request.HasRequiredRequestBodyFields )) -}} {{- $hasCustomArgHandler := or $hasRequiredArgs $hasDifferentArgsWithJsonFlag -}} @@ -250,7 +250,7 @@ func new{{.PascalName}}() *cobra.Command { cmd.RunE = func(cmd *cobra.Command, args []string) (err error) { ctx := cmd.Context() {{if .Service.IsAccounts}}a := cmdctx.AccountClient(ctx){{else}}w := cmdctx.WorkspaceClient(ctx){{end}} - {{- if .Request }} + {{- if not .IsLegacyEmptyRequest }} {{ if $canUseJson }} if cmd.Flags().Changed("json") { diags := {{.CamelName}}Json.Unmarshal(&{{.CamelName}}Req{{ if .RequestBodyField }}.{{.RequestBodyField.PascalName}}{{ end }}) @@ -273,7 +273,7 @@ func new{{.PascalName}}() *cobra.Command { if len(args) == 0 { promptSpinner := cmdio.Spinner(ctx) promptSpinner <- "No{{range $request.RequiredFields}} {{.ConstantName}}{{end}} argument specified. Loading names for {{.Service.TitleName}} drop-down." - names, err := {{if .Service.IsAccounts}}a{{else}}w{{end}}.{{(.Service.TrimPrefix "account").PascalName}}.{{.Service.List.NamedIdMap.PascalName}}(ctx{{if .Service.List.Request}}, {{.Service.Package.Name}}.{{.Service.List.Request.PascalName}}{}{{end}}) + names, err := {{if .Service.IsAccounts}}a{{else}}w{{end}}.{{(.Service.TrimPrefix "account").PascalName}}.{{.Service.List.NamedIdMap.PascalName}}(ctx{{if not .Service.List.IsLegacyEmptyRequest}}, {{.Service.Package.Name}}.{{.Service.List.Request.PascalName}}{}{{end}}) close(promptSpinner) if err != nil { return fmt.Errorf("failed to load names for {{.Service.TitleName}} drop-down. Please manually specify required arguments. Original error: %w", err) @@ -300,7 +300,7 @@ func new{{.PascalName}}() *cobra.Command { {{- end}} {{end}} {{if $wait -}} - wait, err := {{if .Service.IsAccounts}}a{{else}}w{{end}}.{{.Service.PascalName}}.{{.PascalName}}(ctx{{if .Request}}, {{.CamelName}}Req{{end}}) + wait, err := {{if .Service.IsAccounts}}a{{else}}w{{end}}.{{.Service.PascalName}}.{{.PascalName}}(ctx{{if not .IsLegacyEmptyRequest}}, {{.CamelName}}Req{{end}}) if err != nil { return err } @@ -348,7 +348,7 @@ func new{{.PascalName}}() *cobra.Command { // Apply optional overrides to this command. for _, fn := range {{.CamelName}}Overrides { - fn(cmd{{if .Request}}, &{{.CamelName}}Req{{end}}) + fn(cmd{{if not .IsLegacyEmptyRequest}}, &{{.CamelName}}Req{{end}}) } return cmd @@ -370,7 +370,7 @@ func new{{.PascalName}}() *cobra.Command { {{- else}} {{- (.Service.TrimPrefix "account").PascalName}}. {{- end}} - {{- .PascalName}}(ctx{{if .Request}}, {{.CamelName}}Req{{end}}) + {{- .PascalName}}(ctx{{if not .IsLegacyEmptyRequest}}, {{.CamelName}}Req{{end}}) {{- if not (and .Response .Pagination) }} if err != nil { return err diff --git a/cmd/account/access-control/access-control.go b/cmd/account/access-control/access-control.go index 74ac962d2d..21af14f618 100755 --- a/cmd/account/access-control/access-control.go +++ b/cmd/account/access-control/access-control.go @@ -58,8 +58,6 @@ func newGetAssignableRolesForResource() *cobra.Command { var getAssignableRolesForResourceReq iam.GetAssignableRolesForResourceRequest - // TODO: short flags - cmd.Use = "get-assignable-roles-for-resource RESOURCE" cmd.Short = `Get assignable roles for a resource.` cmd.Long = `Get assignable roles for a resource. @@ -124,8 +122,6 @@ func newGetRuleSet() *cobra.Command { var getRuleSetReq iam.GetRuleSetRequest - // TODO: short flags - cmd.Use = "get-rule-set NAME ETAG" cmd.Short = `Get a rule set.` cmd.Long = `Get a rule set. @@ -207,7 +203,6 @@ func newUpdateRuleSet() *cobra.Command { var updateRuleSetReq iam.UpdateRuleSetRequest var updateRuleSetJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateRuleSetJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update-rule-set" diff --git a/cmd/account/billable-usage/billable-usage.go b/cmd/account/billable-usage/billable-usage.go index 69e5ba099f..201020e402 100755 --- a/cmd/account/billable-usage/billable-usage.go +++ b/cmd/account/billable-usage/billable-usage.go @@ -52,8 +52,6 @@ func newDownload() *cobra.Command { var downloadReq billing.DownloadRequest - // TODO: short flags - cmd.Flags().BoolVar(&downloadReq.PersonalData, "personal-data", downloadReq.PersonalData, `Specify whether to include personally identifiable information in the billable usage logs, for example the email addresses of cluster creators.`) cmd.Use = "download START_MONTH END_MONTH" diff --git a/cmd/account/budget-policy/budget-policy.go b/cmd/account/budget-policy/budget-policy.go index e4731b7ce2..a921d9ddfd 100755 --- a/cmd/account/budget-policy/budget-policy.go +++ b/cmd/account/budget-policy/budget-policy.go @@ -57,7 +57,6 @@ func newCreate() *cobra.Command { var createReq billing.CreateBudgetPolicyRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: policy @@ -127,8 +126,6 @@ func newDelete() *cobra.Command { var deleteReq billing.DeleteBudgetPolicyRequest - // TODO: short flags - cmd.Use = "delete POLICY_ID" cmd.Short = `Delete a budget policy.` cmd.Long = `Delete a budget policy. @@ -185,8 +182,6 @@ func newGet() *cobra.Command { var getReq billing.GetBudgetPolicyRequest - // TODO: short flags - cmd.Use = "get POLICY_ID" cmd.Short = `Get a budget policy.` cmd.Long = `Get a budget policy. @@ -243,8 +238,6 @@ func newList() *cobra.Command { var listReq billing.ListBudgetPoliciesRequest - // TODO: short flags - // TODO: complex arg: filter_by cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, `The maximum number of budget policies to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `A page token, received from a previous ListServerlessPolicies call.`) @@ -301,7 +294,6 @@ func newUpdate() *cobra.Command { updateReq.Policy = billing.BudgetPolicy{} var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: limit_config diff --git a/cmd/account/budgets/budgets.go b/cmd/account/budgets/budgets.go index f4eaf899a2..c2911784a3 100755 --- a/cmd/account/budgets/budgets.go +++ b/cmd/account/budgets/budgets.go @@ -62,7 +62,6 @@ func newCreate() *cobra.Command { var createReq billing.CreateBudgetConfigurationRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -127,8 +126,6 @@ func newDelete() *cobra.Command { var deleteReq billing.DeleteBudgetConfigurationRequest - // TODO: short flags - cmd.Use = "delete BUDGET_ID" cmd.Short = `Delete budget.` cmd.Long = `Delete budget. @@ -186,8 +183,6 @@ func newGet() *cobra.Command { var getReq billing.GetBudgetConfigurationRequest - // TODO: short flags - cmd.Use = "get BUDGET_ID" cmd.Short = `Get budget.` cmd.Long = `Get budget. @@ -245,8 +240,6 @@ func newList() *cobra.Command { var listReq billing.ListBudgetConfigurationsRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `A page token received from a previous get all budget configurations call.`) cmd.Use = "list" @@ -298,7 +291,6 @@ func newUpdate() *cobra.Command { var updateReq billing.UpdateBudgetConfigurationRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update BUDGET_ID" diff --git a/cmd/account/credentials/credentials.go b/cmd/account/credentials/credentials.go index 98a840efd6..a0873e3a0f 100755 --- a/cmd/account/credentials/credentials.go +++ b/cmd/account/credentials/credentials.go @@ -62,7 +62,6 @@ func newCreate() *cobra.Command { var createReq provisioning.CreateCredentialRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -139,8 +138,6 @@ func newDelete() *cobra.Command { var deleteReq provisioning.DeleteCredentialRequest - // TODO: short flags - cmd.Use = "delete CREDENTIALS_ID" cmd.Short = `Delete credential configuration.` cmd.Long = `Delete credential configuration. @@ -211,8 +208,6 @@ func newGet() *cobra.Command { var getReq provisioning.GetCredentialRequest - // TODO: short flags - cmd.Use = "get CREDENTIALS_ID" cmd.Short = `Get credential configuration.` cmd.Long = `Get credential configuration. diff --git a/cmd/account/csp-enablement-account/csp-enablement-account.go b/cmd/account/csp-enablement-account/csp-enablement-account.go index 00656fa80d..ce2e00fa48 100755 --- a/cmd/account/csp-enablement-account/csp-enablement-account.go +++ b/cmd/account/csp-enablement-account/csp-enablement-account.go @@ -57,8 +57,6 @@ func newGet() *cobra.Command { var getReq settings.GetCspEnablementAccountSettingRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -113,7 +111,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateCspEnablementAccountSettingRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/account/custom-app-integration/custom-app-integration.go b/cmd/account/custom-app-integration/custom-app-integration.go index 5eb1f7ce8e..7a7f82e814 100755 --- a/cmd/account/custom-app-integration/custom-app-integration.go +++ b/cmd/account/custom-app-integration/custom-app-integration.go @@ -59,7 +59,6 @@ func newCreate() *cobra.Command { var createReq oauth2.CreateCustomAppIntegration var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&createReq.Confidential, "confidential", createReq.Confidential, `This field indicates whether an OAuth client secret is required to authenticate this client.`) @@ -136,8 +135,6 @@ func newDelete() *cobra.Command { var deleteReq oauth2.DeleteCustomAppIntegrationRequest - // TODO: short flags - cmd.Use = "delete INTEGRATION_ID" cmd.Short = `Delete Custom OAuth App Integration.` cmd.Long = `Delete Custom OAuth App Integration. @@ -192,8 +189,6 @@ func newGet() *cobra.Command { var getReq oauth2.GetCustomAppIntegrationRequest - // TODO: short flags - cmd.Use = "get INTEGRATION_ID" cmd.Short = `Get OAuth Custom App Integration.` cmd.Long = `Get OAuth Custom App Integration. @@ -250,8 +245,6 @@ func newList() *cobra.Command { var listReq oauth2.ListCustomAppIntegrationsRequest - // TODO: short flags - cmd.Flags().BoolVar(&listReq.IncludeCreatorUsername, "include-creator-username", listReq.IncludeCreatorUsername, ``) cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -306,7 +299,6 @@ func newUpdate() *cobra.Command { var updateReq oauth2.UpdateCustomAppIntegration var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: redirect_urls diff --git a/cmd/account/disable-legacy-features/disable-legacy-features.go b/cmd/account/disable-legacy-features/disable-legacy-features.go index d09b73f0f9..eaadd7a5f3 100755 --- a/cmd/account/disable-legacy-features/disable-legacy-features.go +++ b/cmd/account/disable-legacy-features/disable-legacy-features.go @@ -59,8 +59,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteDisableLegacyFeaturesRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteReq.Etag, "etag", deleteReq.Etag, `etag used for versioning.`) cmd.Use = "delete" @@ -114,8 +112,6 @@ func newGet() *cobra.Command { var getReq settings.GetDisableLegacyFeaturesRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -170,7 +166,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateDisableLegacyFeaturesRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/account/enable-ip-access-lists/enable-ip-access-lists.go b/cmd/account/enable-ip-access-lists/enable-ip-access-lists.go index 5c9dca9f6e..5159563179 100755 --- a/cmd/account/enable-ip-access-lists/enable-ip-access-lists.go +++ b/cmd/account/enable-ip-access-lists/enable-ip-access-lists.go @@ -56,8 +56,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteAccountIpAccessEnableRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteReq.Etag, "etag", deleteReq.Etag, `etag used for versioning.`) cmd.Use = "delete" @@ -111,8 +109,6 @@ func newGet() *cobra.Command { var getReq settings.GetAccountIpAccessEnableRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -167,7 +163,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateAccountIpAccessEnableRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/account/encryption-keys/encryption-keys.go b/cmd/account/encryption-keys/encryption-keys.go index 91cfce57b1..23a733903d 100755 --- a/cmd/account/encryption-keys/encryption-keys.go +++ b/cmd/account/encryption-keys/encryption-keys.go @@ -73,7 +73,6 @@ func newCreate() *cobra.Command { var createReq provisioning.CreateCustomerManagedKeyRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: aws_key_info @@ -156,8 +155,6 @@ func newDelete() *cobra.Command { var deleteReq provisioning.DeleteEncryptionKeyRequest - // TODO: short flags - cmd.Use = "delete CUSTOMER_MANAGED_KEY_ID" cmd.Short = `Delete encryption key configuration.` cmd.Long = `Delete encryption key configuration. @@ -215,8 +212,6 @@ func newGet() *cobra.Command { var getReq provisioning.GetEncryptionKeyRequest - // TODO: short flags - cmd.Use = "get CUSTOMER_MANAGED_KEY_ID" cmd.Short = `Get encryption key configuration.` cmd.Long = `Get encryption key configuration. diff --git a/cmd/account/esm-enablement-account/esm-enablement-account.go b/cmd/account/esm-enablement-account/esm-enablement-account.go index b9d8203479..11e8da461c 100755 --- a/cmd/account/esm-enablement-account/esm-enablement-account.go +++ b/cmd/account/esm-enablement-account/esm-enablement-account.go @@ -55,8 +55,6 @@ func newGet() *cobra.Command { var getReq settings.GetEsmEnablementAccountSettingRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -111,7 +109,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateEsmEnablementAccountSettingRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/account/federation-policy/federation-policy.go b/cmd/account/federation-policy/federation-policy.go index 091227e4f1..0304f73f06 100755 --- a/cmd/account/federation-policy/federation-policy.go +++ b/cmd/account/federation-policy/federation-policy.go @@ -106,7 +106,6 @@ func newCreate() *cobra.Command { createReq.Policy = oauth2.FederationPolicy{} var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.PolicyId, "policy-id", createReq.PolicyId, `The identifier for the federation policy.`) @@ -176,8 +175,6 @@ func newDelete() *cobra.Command { var deleteReq oauth2.DeleteAccountFederationPolicyRequest - // TODO: short flags - cmd.Use = "delete POLICY_ID" cmd.Short = `Delete account federation policy.` cmd.Long = `Delete account federation policy. @@ -232,8 +229,6 @@ func newGet() *cobra.Command { var getReq oauth2.GetAccountFederationPolicyRequest - // TODO: short flags - cmd.Use = "get POLICY_ID" cmd.Short = `Get account federation policy.` cmd.Long = `Get account federation policy. @@ -288,8 +283,6 @@ func newList() *cobra.Command { var listReq oauth2.ListAccountFederationPoliciesRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -341,7 +334,6 @@ func newUpdate() *cobra.Command { updateReq.Policy = oauth2.FederationPolicy{} var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.UpdateMask, "update-mask", updateReq.UpdateMask, `The field mask specifies which fields of the policy to update.`) diff --git a/cmd/account/groups/groups.go b/cmd/account/groups/groups.go index d83949a827..3318a34b42 100755 --- a/cmd/account/groups/groups.go +++ b/cmd/account/groups/groups.go @@ -66,7 +66,6 @@ func newCreate() *cobra.Command { var createReq iam.Group var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.DisplayName, "display-name", createReq.DisplayName, `String that represents a human-readable group name.`) @@ -144,8 +143,6 @@ func newDelete() *cobra.Command { var deleteReq iam.DeleteAccountGroupRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete a group.` cmd.Long = `Delete a group. @@ -214,8 +211,6 @@ func newGet() *cobra.Command { var getReq iam.GetAccountGroupRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get group details.` cmd.Long = `Get group details. @@ -284,8 +279,6 @@ func newList() *cobra.Command { var listReq iam.ListAccountGroupsRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.Attributes, "attributes", listReq.Attributes, `Comma-separated list of attributes to return in response.`) cmd.Flags().Int64Var(&listReq.Count, "count", listReq.Count, `Desired number of results per page.`) cmd.Flags().StringVar(&listReq.ExcludedAttributes, "excluded-attributes", listReq.ExcludedAttributes, `Comma-separated list of attributes to exclude in response.`) @@ -343,7 +336,6 @@ func newPatch() *cobra.Command { var patchReq iam.PartialUpdate var patchJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&patchJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: Operations @@ -430,7 +422,6 @@ func newUpdate() *cobra.Command { var updateReq iam.Group var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.DisplayName, "display-name", updateReq.DisplayName, `String that represents a human-readable group name.`) diff --git a/cmd/account/ip-access-lists/ip-access-lists.go b/cmd/account/ip-access-lists/ip-access-lists.go index f738af42c2..479afc1a24 100755 --- a/cmd/account/ip-access-lists/ip-access-lists.go +++ b/cmd/account/ip-access-lists/ip-access-lists.go @@ -81,7 +81,6 @@ func newCreate() *cobra.Command { var createReq settings.CreateIpAccessList var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: ip_addresses @@ -189,8 +188,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteAccountIpAccessListRequest - // TODO: short flags - cmd.Use = "delete IP_ACCESS_LIST_ID" cmd.Short = `Delete access list.` cmd.Long = `Delete access list. @@ -259,8 +256,6 @@ func newGet() *cobra.Command { var getReq settings.GetAccountIpAccessListRequest - // TODO: short flags - cmd.Use = "get IP_ACCESS_LIST_ID" cmd.Short = `Get IP access list.` cmd.Long = `Get IP access list. @@ -369,7 +364,6 @@ func newReplace() *cobra.Command { var replaceReq settings.ReplaceIpAccessList var replaceJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&replaceJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: ip_addresses @@ -483,7 +477,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateIpAccessList var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&updateReq.Enabled, "enabled", updateReq.Enabled, `Specifies whether this IP access list is enabled.`) diff --git a/cmd/account/llm-proxy-partner-powered-account/llm-proxy-partner-powered-account.go b/cmd/account/llm-proxy-partner-powered-account/llm-proxy-partner-powered-account.go index fc983c684f..ac10c02d56 100755 --- a/cmd/account/llm-proxy-partner-powered-account/llm-proxy-partner-powered-account.go +++ b/cmd/account/llm-proxy-partner-powered-account/llm-proxy-partner-powered-account.go @@ -54,8 +54,6 @@ func newGet() *cobra.Command { var getReq settings.GetLlmProxyPartnerPoweredAccountRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -110,7 +108,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateLlmProxyPartnerPoweredAccountRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/account/llm-proxy-partner-powered-enforce/llm-proxy-partner-powered-enforce.go b/cmd/account/llm-proxy-partner-powered-enforce/llm-proxy-partner-powered-enforce.go index ce0f9d8b98..3571fdcc12 100755 --- a/cmd/account/llm-proxy-partner-powered-enforce/llm-proxy-partner-powered-enforce.go +++ b/cmd/account/llm-proxy-partner-powered-enforce/llm-proxy-partner-powered-enforce.go @@ -55,8 +55,6 @@ func newGet() *cobra.Command { var getReq settings.GetLlmProxyPartnerPoweredEnforceRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -111,7 +109,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateLlmProxyPartnerPoweredEnforceRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/account/log-delivery/log-delivery.go b/cmd/account/log-delivery/log-delivery.go index 1d79a867f4..92b0c09b6e 100755 --- a/cmd/account/log-delivery/log-delivery.go +++ b/cmd/account/log-delivery/log-delivery.go @@ -121,7 +121,6 @@ func newCreate() *cobra.Command { var createReq billing.WrappedCreateLogDeliveryConfiguration var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -209,8 +208,6 @@ func newGet() *cobra.Command { var getReq billing.GetLogDeliveryRequest - // TODO: short flags - cmd.Use = "get LOG_DELIVERY_CONFIGURATION_ID" cmd.Short = `Get log delivery configuration.` cmd.Long = `Get log delivery configuration. @@ -280,8 +277,6 @@ func newList() *cobra.Command { var listReq billing.ListLogDeliveryRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.CredentialsId, "credentials-id", listReq.CredentialsId, `The Credentials id to filter the search results with.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `A page token received from a previous get all budget configurations call.`) cmd.Flags().Var(&listReq.Status, "status", `The log delivery status to filter the search results with. Supported values: [DISABLED, ENABLED]`) @@ -337,7 +332,6 @@ func newPatchStatus() *cobra.Command { var patchStatusReq billing.UpdateLogDeliveryConfigurationStatusRequest var patchStatusJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&patchStatusJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "patch-status LOG_DELIVERY_CONFIGURATION_ID STATUS" diff --git a/cmd/account/metastore-assignments/metastore-assignments.go b/cmd/account/metastore-assignments/metastore-assignments.go index 8dc3171df1..9c45a876e8 100755 --- a/cmd/account/metastore-assignments/metastore-assignments.go +++ b/cmd/account/metastore-assignments/metastore-assignments.go @@ -59,7 +59,6 @@ func newCreate() *cobra.Command { var createReq catalog.AccountsCreateMetastoreAssignment var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: metastore_assignment @@ -137,8 +136,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteAccountMetastoreAssignmentRequest - // TODO: short flags - cmd.Use = "delete WORKSPACE_ID METASTORE_ID" cmd.Short = `Delete a metastore assignment.` cmd.Long = `Delete a metastore assignment. @@ -201,8 +198,6 @@ func newGet() *cobra.Command { var getReq catalog.GetAccountMetastoreAssignmentRequest - // TODO: short flags - cmd.Use = "get WORKSPACE_ID" cmd.Short = `Gets the metastore assignment for a workspace.` cmd.Long = `Gets the metastore assignment for a workspace. @@ -265,8 +260,6 @@ func newList() *cobra.Command { var listReq catalog.ListAccountMetastoreAssignmentsRequest - // TODO: short flags - cmd.Use = "list METASTORE_ID" cmd.Short = `Get all workspaces assigned to a metastore.` cmd.Long = `Get all workspaces assigned to a metastore. @@ -322,7 +315,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.AccountsUpdateMetastoreAssignment var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: metastore_assignment diff --git a/cmd/account/metastores/metastores.go b/cmd/account/metastores/metastores.go index 018767c650..6fa3ee645f 100755 --- a/cmd/account/metastores/metastores.go +++ b/cmd/account/metastores/metastores.go @@ -58,7 +58,6 @@ func newCreate() *cobra.Command { var createReq catalog.AccountsCreateMetastore var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: metastore_info @@ -127,8 +126,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteAccountMetastoreRequest - // TODO: short flags - cmd.Flags().BoolVar(&deleteReq.Force, "force", deleteReq.Force, `Force deletion even if the metastore is not empty.`) cmd.Use = "delete METASTORE_ID" @@ -187,8 +184,6 @@ func newGet() *cobra.Command { var getReq catalog.GetAccountMetastoreRequest - // TODO: short flags - cmd.Use = "get METASTORE_ID" cmd.Short = `Get a metastore.` cmd.Long = `Get a metastore. @@ -285,7 +280,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.AccountsUpdateMetastore var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: metastore_info diff --git a/cmd/account/network-connectivity/network-connectivity.go b/cmd/account/network-connectivity/network-connectivity.go index b7682f8780..dbec1726a5 100755 --- a/cmd/account/network-connectivity/network-connectivity.go +++ b/cmd/account/network-connectivity/network-connectivity.go @@ -72,7 +72,6 @@ func newCreateNetworkConnectivityConfiguration() *cobra.Command { createNetworkConnectivityConfigurationReq.NetworkConnectivityConfig = settings.CreateNetworkConnectivityConfiguration{} var createNetworkConnectivityConfigurationJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createNetworkConnectivityConfigurationJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create-network-connectivity-configuration NAME REGION" @@ -174,7 +173,6 @@ func newCreatePrivateEndpointRule() *cobra.Command { createPrivateEndpointRuleReq.PrivateEndpointRule = settings.CreatePrivateEndpointRule{} var createPrivateEndpointRuleJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createPrivateEndpointRuleJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: domain_names @@ -260,8 +258,6 @@ func newDeleteNetworkConnectivityConfiguration() *cobra.Command { var deleteNetworkConnectivityConfigurationReq settings.DeleteNetworkConnectivityConfigurationRequest - // TODO: short flags - cmd.Use = "delete-network-connectivity-configuration NETWORK_CONNECTIVITY_CONFIG_ID" cmd.Short = `Delete a network connectivity configuration.` cmd.Long = `Delete a network connectivity configuration. @@ -318,8 +314,6 @@ func newDeletePrivateEndpointRule() *cobra.Command { var deletePrivateEndpointRuleReq settings.DeletePrivateEndpointRuleRequest - // TODO: short flags - cmd.Use = "delete-private-endpoint-rule NETWORK_CONNECTIVITY_CONFIG_ID PRIVATE_ENDPOINT_RULE_ID" cmd.Short = `Delete a private endpoint rule.` cmd.Long = `Delete a private endpoint rule. @@ -383,8 +377,6 @@ func newGetNetworkConnectivityConfiguration() *cobra.Command { var getNetworkConnectivityConfigurationReq settings.GetNetworkConnectivityConfigurationRequest - // TODO: short flags - cmd.Use = "get-network-connectivity-configuration NETWORK_CONNECTIVITY_CONFIG_ID" cmd.Short = `Get a network connectivity configuration.` cmd.Long = `Get a network connectivity configuration. @@ -441,8 +433,6 @@ func newGetPrivateEndpointRule() *cobra.Command { var getPrivateEndpointRuleReq settings.GetPrivateEndpointRuleRequest - // TODO: short flags - cmd.Use = "get-private-endpoint-rule NETWORK_CONNECTIVITY_CONFIG_ID PRIVATE_ENDPOINT_RULE_ID" cmd.Short = `Gets a private endpoint rule.` cmd.Long = `Gets a private endpoint rule. @@ -501,8 +491,6 @@ func newListNetworkConnectivityConfigurations() *cobra.Command { var listNetworkConnectivityConfigurationsReq settings.ListNetworkConnectivityConfigurationsRequest - // TODO: short flags - cmd.Flags().StringVar(&listNetworkConnectivityConfigurationsReq.PageToken, "page-token", listNetworkConnectivityConfigurationsReq.PageToken, `Pagination token to go to next page based on previous query.`) cmd.Use = "list-network-connectivity-configurations" @@ -553,8 +541,6 @@ func newListPrivateEndpointRules() *cobra.Command { var listPrivateEndpointRulesReq settings.ListPrivateEndpointRulesRequest - // TODO: short flags - cmd.Flags().StringVar(&listPrivateEndpointRulesReq.PageToken, "page-token", listPrivateEndpointRulesReq.PageToken, `Pagination token to go to next page based on previous query.`) cmd.Use = "list-private-endpoint-rules NETWORK_CONNECTIVITY_CONFIG_ID" @@ -612,7 +598,6 @@ func newUpdatePrivateEndpointRule() *cobra.Command { updatePrivateEndpointRuleReq.PrivateEndpointRule = settings.UpdatePrivateEndpointRule{} var updatePrivateEndpointRuleJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePrivateEndpointRuleJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: domain_names diff --git a/cmd/account/network-policies/network-policies.go b/cmd/account/network-policies/network-policies.go index c22c6576bb..dd0aa95900 100755 --- a/cmd/account/network-policies/network-policies.go +++ b/cmd/account/network-policies/network-policies.go @@ -64,7 +64,6 @@ func newCreateNetworkPolicyRpc() *cobra.Command { createNetworkPolicyRpcReq.NetworkPolicy = settings.AccountNetworkPolicy{} var createNetworkPolicyRpcJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createNetworkPolicyRpcJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createNetworkPolicyRpcReq.NetworkPolicy.AccountId, "account-id", createNetworkPolicyRpcReq.NetworkPolicy.AccountId, `The associated account ID for this Network Policy object.`) @@ -136,8 +135,6 @@ func newDeleteNetworkPolicyRpc() *cobra.Command { var deleteNetworkPolicyRpcReq settings.DeleteNetworkPolicyRequest - // TODO: short flags - cmd.Use = "delete-network-policy-rpc NETWORK_POLICY_ID" cmd.Short = `Delete a network policy.` cmd.Long = `Delete a network policy. @@ -194,8 +191,6 @@ func newGetNetworkPolicyRpc() *cobra.Command { var getNetworkPolicyRpcReq settings.GetNetworkPolicyRequest - // TODO: short flags - cmd.Use = "get-network-policy-rpc NETWORK_POLICY_ID" cmd.Short = `Get a network policy.` cmd.Long = `Get a network policy. @@ -252,8 +247,6 @@ func newListNetworkPoliciesRpc() *cobra.Command { var listNetworkPoliciesRpcReq settings.ListNetworkPoliciesRequest - // TODO: short flags - cmd.Flags().StringVar(&listNetworkPoliciesRpcReq.PageToken, "page-token", listNetworkPoliciesRpcReq.PageToken, `Pagination token to go to next page based on previous query.`) cmd.Use = "list-network-policies-rpc" @@ -306,7 +299,6 @@ func newUpdateNetworkPolicyRpc() *cobra.Command { updateNetworkPolicyRpcReq.NetworkPolicy = settings.AccountNetworkPolicy{} var updateNetworkPolicyRpcJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateNetworkPolicyRpcJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateNetworkPolicyRpcReq.NetworkPolicy.AccountId, "account-id", updateNetworkPolicyRpcReq.NetworkPolicy.AccountId, `The associated account ID for this Network Policy object.`) diff --git a/cmd/account/networks/networks.go b/cmd/account/networks/networks.go index d87949c72d..55b46e89a5 100755 --- a/cmd/account/networks/networks.go +++ b/cmd/account/networks/networks.go @@ -59,7 +59,6 @@ func newCreate() *cobra.Command { var createReq provisioning.CreateNetworkRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: gcp_network_info @@ -147,8 +146,6 @@ func newDelete() *cobra.Command { var deleteReq provisioning.DeleteNetworkRequest - // TODO: short flags - cmd.Use = "delete NETWORK_ID" cmd.Short = `Delete a network configuration.` cmd.Long = `Delete a network configuration. @@ -222,8 +219,6 @@ func newGet() *cobra.Command { var getReq provisioning.GetNetworkRequest - // TODO: short flags - cmd.Use = "get NETWORK_ID" cmd.Short = `Get a network configuration.` cmd.Long = `Get a network configuration. diff --git a/cmd/account/o-auth-published-apps/o-auth-published-apps.go b/cmd/account/o-auth-published-apps/o-auth-published-apps.go index 96276a7097..b0e46d7ea1 100755 --- a/cmd/account/o-auth-published-apps/o-auth-published-apps.go +++ b/cmd/account/o-auth-published-apps/o-auth-published-apps.go @@ -54,8 +54,6 @@ func newList() *cobra.Command { var listReq oauth2.ListOAuthPublishedAppsRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, `The max number of OAuth published apps to return in one page.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `A token that can be used to get the next page of results.`) diff --git a/cmd/account/personal-compute/personal-compute.go b/cmd/account/personal-compute/personal-compute.go index 50fba97c8c..611b1dc042 100755 --- a/cmd/account/personal-compute/personal-compute.go +++ b/cmd/account/personal-compute/personal-compute.go @@ -63,8 +63,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeletePersonalComputeSettingRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteReq.Etag, "etag", deleteReq.Etag, `etag used for versioning.`) cmd.Use = "delete" @@ -118,8 +116,6 @@ func newGet() *cobra.Command { var getReq settings.GetPersonalComputeSettingRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -174,7 +170,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdatePersonalComputeSettingRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/account/private-access/private-access.go b/cmd/account/private-access/private-access.go index 14d67f8a7c..4990af8a5e 100755 --- a/cmd/account/private-access/private-access.go +++ b/cmd/account/private-access/private-access.go @@ -59,7 +59,6 @@ func newCreate() *cobra.Command { var createReq provisioning.UpsertPrivateAccessSettingsRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: allowed_vpc_endpoint_ids @@ -162,8 +161,6 @@ func newDelete() *cobra.Command { var deleteReq provisioning.DeletePrivateAccesRequest - // TODO: short flags - cmd.Use = "delete PRIVATE_ACCESS_SETTINGS_ID" cmd.Short = `Delete a private access settings object.` cmd.Long = `Delete a private access settings object. @@ -239,8 +236,6 @@ func newGet() *cobra.Command { var getReq provisioning.GetPrivateAccesRequest - // TODO: short flags - cmd.Use = "get PRIVATE_ACCESS_SETTINGS_ID" cmd.Short = `Get a private access settings object.` cmd.Long = `Get a private access settings object. @@ -360,7 +355,6 @@ func newReplace() *cobra.Command { var replaceReq provisioning.UpsertPrivateAccessSettingsRequest var replaceJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&replaceJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: allowed_vpc_endpoint_ids diff --git a/cmd/account/published-app-integration/published-app-integration.go b/cmd/account/published-app-integration/published-app-integration.go index ea6e664d6c..417ceead5f 100755 --- a/cmd/account/published-app-integration/published-app-integration.go +++ b/cmd/account/published-app-integration/published-app-integration.go @@ -59,7 +59,6 @@ func newCreate() *cobra.Command { var createReq oauth2.CreatePublishedAppIntegration var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.AppId, "app-id", createReq.AppId, `App id of the OAuth published app integration.`) @@ -132,8 +131,6 @@ func newDelete() *cobra.Command { var deleteReq oauth2.DeletePublishedAppIntegrationRequest - // TODO: short flags - cmd.Use = "delete INTEGRATION_ID" cmd.Short = `Delete Published OAuth App Integration.` cmd.Long = `Delete Published OAuth App Integration. @@ -188,8 +185,6 @@ func newGet() *cobra.Command { var getReq oauth2.GetPublishedAppIntegrationRequest - // TODO: short flags - cmd.Use = "get INTEGRATION_ID" cmd.Short = `Get OAuth Published App Integration.` cmd.Long = `Get OAuth Published App Integration. @@ -243,8 +238,6 @@ func newList() *cobra.Command { var listReq oauth2.ListPublishedAppIntegrationsRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -298,7 +291,6 @@ func newUpdate() *cobra.Command { var updateReq oauth2.UpdatePublishedAppIntegration var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: token_access_policy diff --git a/cmd/account/service-principal-federation-policy/service-principal-federation-policy.go b/cmd/account/service-principal-federation-policy/service-principal-federation-policy.go index 269ca6bd3c..faeff49071 100755 --- a/cmd/account/service-principal-federation-policy/service-principal-federation-policy.go +++ b/cmd/account/service-principal-federation-policy/service-principal-federation-policy.go @@ -113,7 +113,6 @@ func newCreate() *cobra.Command { createReq.Policy = oauth2.FederationPolicy{} var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.PolicyId, "policy-id", createReq.PolicyId, `The identifier for the federation policy.`) @@ -192,8 +191,6 @@ func newDelete() *cobra.Command { var deleteReq oauth2.DeleteServicePrincipalFederationPolicyRequest - // TODO: short flags - cmd.Use = "delete SERVICE_PRINCIPAL_ID POLICY_ID" cmd.Short = `Delete service principal federation policy.` cmd.Long = `Delete service principal federation policy. @@ -255,8 +252,6 @@ func newGet() *cobra.Command { var getReq oauth2.GetServicePrincipalFederationPolicyRequest - // TODO: short flags - cmd.Use = "get SERVICE_PRINCIPAL_ID POLICY_ID" cmd.Short = `Get service principal federation policy.` cmd.Long = `Get service principal federation policy. @@ -318,8 +313,6 @@ func newList() *cobra.Command { var listReq oauth2.ListServicePrincipalFederationPoliciesRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -381,7 +374,6 @@ func newUpdate() *cobra.Command { updateReq.Policy = oauth2.FederationPolicy{} var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.UpdateMask, "update-mask", updateReq.UpdateMask, `The field mask specifies which fields of the policy to update.`) diff --git a/cmd/account/service-principal-secrets/service-principal-secrets.go b/cmd/account/service-principal-secrets/service-principal-secrets.go index b28fa4ef23..f24e63fa56 100755 --- a/cmd/account/service-principal-secrets/service-principal-secrets.go +++ b/cmd/account/service-principal-secrets/service-principal-secrets.go @@ -69,7 +69,6 @@ func newCreate() *cobra.Command { var createReq oauth2.CreateServicePrincipalSecretRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Lifetime, "lifetime", createReq.Lifetime, `The lifetime of the secret in seconds.`) @@ -145,8 +144,6 @@ func newDelete() *cobra.Command { var deleteReq oauth2.DeleteServicePrincipalSecretRequest - // TODO: short flags - cmd.Use = "delete SERVICE_PRINCIPAL_ID SECRET_ID" cmd.Short = `Delete service principal secret.` cmd.Long = `Delete service principal secret. @@ -208,8 +205,6 @@ func newList() *cobra.Command { var listReq oauth2.ListServicePrincipalSecretsRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `An opaque page token which was the next_page_token in the response of the previous request to list the secrets for this service principal.`) cmd.Use = "list SERVICE_PRINCIPAL_ID" diff --git a/cmd/account/service-principals/service-principals.go b/cmd/account/service-principals/service-principals.go index 0a750ea7b8..e69c976777 100755 --- a/cmd/account/service-principals/service-principals.go +++ b/cmd/account/service-principals/service-principals.go @@ -65,7 +65,6 @@ func newCreate() *cobra.Command { var createReq iam.ServicePrincipal var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&createReq.Active, "active", createReq.Active, `If this user is active.`) @@ -142,8 +141,6 @@ func newDelete() *cobra.Command { var deleteReq iam.DeleteAccountServicePrincipalRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete a service principal.` cmd.Long = `Delete a service principal. @@ -212,8 +209,6 @@ func newGet() *cobra.Command { var getReq iam.GetAccountServicePrincipalRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get service principal details.` cmd.Long = `Get service principal details. @@ -283,8 +278,6 @@ func newList() *cobra.Command { var listReq iam.ListAccountServicePrincipalsRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.Attributes, "attributes", listReq.Attributes, `Comma-separated list of attributes to return in response.`) cmd.Flags().Int64Var(&listReq.Count, "count", listReq.Count, `Desired number of results per page.`) cmd.Flags().StringVar(&listReq.ExcludedAttributes, "excluded-attributes", listReq.ExcludedAttributes, `Comma-separated list of attributes to exclude in response.`) @@ -342,7 +335,6 @@ func newPatch() *cobra.Command { var patchReq iam.PartialUpdate var patchJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&patchJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: Operations @@ -430,7 +422,6 @@ func newUpdate() *cobra.Command { var updateReq iam.ServicePrincipal var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&updateReq.Active, "active", updateReq.Active, `If this user is active.`) diff --git a/cmd/account/storage-credentials/storage-credentials.go b/cmd/account/storage-credentials/storage-credentials.go index 3f5a373597..c1b5d01ef3 100755 --- a/cmd/account/storage-credentials/storage-credentials.go +++ b/cmd/account/storage-credentials/storage-credentials.go @@ -57,7 +57,6 @@ func newCreate() *cobra.Command { var createReq catalog.AccountsCreateStorageCredential var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: credential_info @@ -136,8 +135,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteAccountStorageCredentialRequest - // TODO: short flags - cmd.Flags().BoolVar(&deleteReq.Force, "force", deleteReq.Force, `Force deletion even if the Storage Credential is not empty.`) cmd.Use = "delete METASTORE_ID STORAGE_CREDENTIAL_NAME" @@ -199,8 +196,6 @@ func newGet() *cobra.Command { var getReq catalog.GetAccountStorageCredentialRequest - // TODO: short flags - cmd.Use = "get METASTORE_ID STORAGE_CREDENTIAL_NAME" cmd.Short = `Gets the named storage credential.` cmd.Long = `Gets the named storage credential. @@ -261,8 +256,6 @@ func newList() *cobra.Command { var listReq catalog.ListAccountStorageCredentialsRequest - // TODO: short flags - cmd.Use = "list METASTORE_ID" cmd.Short = `Get all storage credentials assigned to a metastore.` cmd.Long = `Get all storage credentials assigned to a metastore. @@ -318,7 +311,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.AccountsUpdateStorageCredential var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: credential_info diff --git a/cmd/account/storage/storage.go b/cmd/account/storage/storage.go index 67da73b5e5..eaca50e904 100755 --- a/cmd/account/storage/storage.go +++ b/cmd/account/storage/storage.go @@ -63,7 +63,6 @@ func newCreate() *cobra.Command { var createReq provisioning.CreateStorageConfigurationRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -136,8 +135,6 @@ func newDelete() *cobra.Command { var deleteReq provisioning.DeleteStorageRequest - // TODO: short flags - cmd.Use = "delete STORAGE_CONFIGURATION_ID" cmd.Short = `Delete storage configuration.` cmd.Long = `Delete storage configuration. @@ -207,8 +204,6 @@ func newGet() *cobra.Command { var getReq provisioning.GetStorageRequest - // TODO: short flags - cmd.Use = "get STORAGE_CONFIGURATION_ID" cmd.Short = `Get storage configuration.` cmd.Long = `Get storage configuration. diff --git a/cmd/account/usage-dashboards/usage-dashboards.go b/cmd/account/usage-dashboards/usage-dashboards.go index 21f965bc99..9a737e999c 100755 --- a/cmd/account/usage-dashboards/usage-dashboards.go +++ b/cmd/account/usage-dashboards/usage-dashboards.go @@ -56,7 +56,6 @@ func newCreate() *cobra.Command { var createReq billing.CreateBillingUsageDashboardRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().Var(&createReq.DashboardType, "dashboard-type", `Workspace level usage dashboard shows usage data for the specified workspace ID. Supported values: [USAGE_DASHBOARD_TYPE_GLOBAL, USAGE_DASHBOARD_TYPE_WORKSPACE]`) @@ -127,8 +126,6 @@ func newGet() *cobra.Command { var getReq billing.GetBillingUsageDashboardRequest - // TODO: short flags - cmd.Flags().Var(&getReq.DashboardType, "dashboard-type", `Workspace level usage dashboard shows usage data for the specified workspace ID. Supported values: [USAGE_DASHBOARD_TYPE_GLOBAL, USAGE_DASHBOARD_TYPE_WORKSPACE]`) cmd.Flags().Int64Var(&getReq.WorkspaceId, "workspace-id", getReq.WorkspaceId, `The workspace ID of the workspace in which the usage dashboard is created.`) diff --git a/cmd/account/users/users.go b/cmd/account/users/users.go index 609ad6b707..1f9913b7db 100755 --- a/cmd/account/users/users.go +++ b/cmd/account/users/users.go @@ -70,7 +70,6 @@ func newCreate() *cobra.Command { var createReq iam.User var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&createReq.Active, "active", createReq.Active, `If this user is active.`) @@ -150,8 +149,6 @@ func newDelete() *cobra.Command { var deleteReq iam.DeleteAccountUserRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete a user.` cmd.Long = `Delete a user. @@ -221,8 +218,6 @@ func newGet() *cobra.Command { var getReq iam.GetAccountUserRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Attributes, "attributes", getReq.Attributes, `Comma-separated list of attributes to return in response.`) cmd.Flags().IntVar(&getReq.Count, "count", getReq.Count, `Desired number of results per page.`) cmd.Flags().StringVar(&getReq.ExcludedAttributes, "excluded-attributes", getReq.ExcludedAttributes, `Comma-separated list of attributes to exclude in response.`) @@ -299,8 +294,6 @@ func newList() *cobra.Command { var listReq iam.ListAccountUsersRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.Attributes, "attributes", listReq.Attributes, `Comma-separated list of attributes to return in response.`) cmd.Flags().Int64Var(&listReq.Count, "count", listReq.Count, `Desired number of results per page.`) cmd.Flags().StringVar(&listReq.ExcludedAttributes, "excluded-attributes", listReq.ExcludedAttributes, `Comma-separated list of attributes to exclude in response.`) @@ -358,7 +351,6 @@ func newPatch() *cobra.Command { var patchReq iam.PartialUpdate var patchJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&patchJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: Operations @@ -446,7 +438,6 @@ func newUpdate() *cobra.Command { var updateReq iam.User var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&updateReq.Active, "active", updateReq.Active, `If this user is active.`) diff --git a/cmd/account/vpc-endpoints/vpc-endpoints.go b/cmd/account/vpc-endpoints/vpc-endpoints.go index e83073a2b9..fdd1e506f1 100755 --- a/cmd/account/vpc-endpoints/vpc-endpoints.go +++ b/cmd/account/vpc-endpoints/vpc-endpoints.go @@ -58,7 +58,6 @@ func newCreate() *cobra.Command { var createReq provisioning.CreateVpcEndpointRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.AwsVpcEndpointId, "aws-vpc-endpoint-id", createReq.AwsVpcEndpointId, `The ID of the VPC endpoint object in AWS.`) @@ -154,8 +153,6 @@ func newDelete() *cobra.Command { var deleteReq provisioning.DeleteVpcEndpointRequest - // TODO: short flags - cmd.Use = "delete VPC_ENDPOINT_ID" cmd.Short = `Delete VPC endpoint configuration.` cmd.Long = `Delete VPC endpoint configuration. @@ -232,8 +229,6 @@ func newGet() *cobra.Command { var getReq provisioning.GetVpcEndpointRequest - // TODO: short flags - cmd.Use = "get VPC_ENDPOINT_ID" cmd.Short = `Get a VPC endpoint configuration.` cmd.Long = `Get a VPC endpoint configuration. diff --git a/cmd/account/workspace-assignment/workspace-assignment.go b/cmd/account/workspace-assignment/workspace-assignment.go index 41998765a0..ce6ff71765 100755 --- a/cmd/account/workspace-assignment/workspace-assignment.go +++ b/cmd/account/workspace-assignment/workspace-assignment.go @@ -58,8 +58,6 @@ func newDelete() *cobra.Command { var deleteReq iam.DeleteWorkspaceAssignmentRequest - // TODO: short flags - cmd.Use = "delete WORKSPACE_ID PRINCIPAL_ID" cmd.Short = `Delete permissions assignment.` cmd.Long = `Delete permissions assignment. @@ -125,8 +123,6 @@ func newGet() *cobra.Command { var getReq iam.GetWorkspaceAssignmentRequest - // TODO: short flags - cmd.Use = "get WORKSPACE_ID" cmd.Short = `List workspace permissions.` cmd.Long = `List workspace permissions. @@ -186,8 +182,6 @@ func newList() *cobra.Command { var listReq iam.ListWorkspaceAssignmentRequest - // TODO: short flags - cmd.Use = "list WORKSPACE_ID" cmd.Short = `Get permission assignments.` cmd.Long = `Get permission assignments. @@ -246,7 +240,6 @@ func newUpdate() *cobra.Command { var updateReq iam.UpdateWorkspaceAssignments var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: permissions diff --git a/cmd/account/workspace-network-configuration/workspace-network-configuration.go b/cmd/account/workspace-network-configuration/workspace-network-configuration.go index dee1c53af5..b01923695c 100755 --- a/cmd/account/workspace-network-configuration/workspace-network-configuration.go +++ b/cmd/account/workspace-network-configuration/workspace-network-configuration.go @@ -61,8 +61,6 @@ func newGetWorkspaceNetworkOptionRpc() *cobra.Command { var getWorkspaceNetworkOptionRpcReq settings.GetWorkspaceNetworkOptionRequest - // TODO: short flags - cmd.Use = "get-workspace-network-option-rpc WORKSPACE_ID" cmd.Short = `Get workspace network option.` cmd.Long = `Get workspace network option. @@ -126,7 +124,6 @@ func newUpdateWorkspaceNetworkOptionRpc() *cobra.Command { updateWorkspaceNetworkOptionRpcReq.WorkspaceNetworkOption = settings.WorkspaceNetworkOption{} var updateWorkspaceNetworkOptionRpcJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateWorkspaceNetworkOptionRpcJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateWorkspaceNetworkOptionRpcReq.WorkspaceNetworkOption.NetworkPolicyId, "network-policy-id", updateWorkspaceNetworkOptionRpcReq.WorkspaceNetworkOption.NetworkPolicyId, `The network policy ID to apply to the workspace.`) diff --git a/cmd/account/workspaces/workspaces.go b/cmd/account/workspaces/workspaces.go index 1ed97595ae..577b45bb12 100755 --- a/cmd/account/workspaces/workspaces.go +++ b/cmd/account/workspaces/workspaces.go @@ -72,7 +72,7 @@ func newCreate() *cobra.Command { cmd.Flags().BoolVar(&createSkipWait, "no-wait", createSkipWait, `do not wait to reach RUNNING state`) cmd.Flags().DurationVar(&createTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach RUNNING state`) - // TODO: short flags + cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.AwsRegion, "aws-region", createReq.AwsRegion, `The AWS region of the workspace's data plane.`) @@ -196,8 +196,6 @@ func newDelete() *cobra.Command { var deleteReq provisioning.DeleteWorkspaceRequest - // TODO: short flags - cmd.Use = "delete WORKSPACE_ID" cmd.Short = `Delete a workspace.` cmd.Long = `Delete a workspace. @@ -276,8 +274,6 @@ func newGet() *cobra.Command { var getReq provisioning.GetWorkspaceRequest - // TODO: short flags - cmd.Use = "get WORKSPACE_ID" cmd.Short = `Get a workspace.` cmd.Long = `Get a workspace. @@ -414,7 +410,7 @@ func newUpdate() *cobra.Command { cmd.Flags().BoolVar(&updateSkipWait, "no-wait", updateSkipWait, `do not wait to reach RUNNING state`) cmd.Flags().DurationVar(&updateTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach RUNNING state`) - // TODO: short flags + cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.AwsRegion, "aws-region", updateReq.AwsRegion, `The AWS region of the workspace's data plane (for example, us-west-2).`) diff --git a/cmd/workspace/access-control/access-control.go b/cmd/workspace/access-control/access-control.go index 7862766621..09793fa7b2 100755 --- a/cmd/workspace/access-control/access-control.go +++ b/cmd/workspace/access-control/access-control.go @@ -58,7 +58,6 @@ func newCheckPolicy() *cobra.Command { var checkPolicyReq iam.CheckPolicyRequest var checkPolicyJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&checkPolicyJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: resource_info diff --git a/cmd/workspace/ai-builder/ai-builder.go b/cmd/workspace/ai-builder/ai-builder.go index ab8c40e092..cd3c77d993 100755 --- a/cmd/workspace/ai-builder/ai-builder.go +++ b/cmd/workspace/ai-builder/ai-builder.go @@ -63,8 +63,6 @@ func newCancelOptimize() *cobra.Command { var cancelOptimizeReq aibuilder.CancelCustomLlmOptimizationRunRequest - // TODO: short flags - cmd.Use = "cancel-optimize ID" cmd.Short = `Cancel a Custom LLM Optimization Run.` cmd.Long = `Cancel a Custom LLM Optimization Run.` @@ -117,7 +115,6 @@ func newCreateCustomLlm() *cobra.Command { var createCustomLlmReq aibuilder.CreateCustomLlmRequest var createCustomLlmJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createCustomLlmJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createCustomLlmReq.AgentArtifactPath, "agent-artifact-path", createCustomLlmReq.AgentArtifactPath, `Optional: UC path for agent artifacts.`) @@ -203,8 +200,6 @@ func newDeleteCustomLlm() *cobra.Command { var deleteCustomLlmReq aibuilder.DeleteCustomLlmRequest - // TODO: short flags - cmd.Use = "delete-custom-llm ID" cmd.Short = `Delete a Custom LLM.` cmd.Long = `Delete a Custom LLM. @@ -259,8 +254,6 @@ func newGetCustomLlm() *cobra.Command { var getCustomLlmReq aibuilder.GetCustomLlmRequest - // TODO: short flags - cmd.Use = "get-custom-llm ID" cmd.Short = `Get a Custom LLM.` cmd.Long = `Get a Custom LLM. @@ -315,8 +308,6 @@ func newStartOptimize() *cobra.Command { var startOptimizeReq aibuilder.StartCustomLlmOptimizationRunRequest - // TODO: short flags - cmd.Use = "start-optimize ID" cmd.Short = `Start a Custom LLM Optimization Run.` cmd.Long = `Start a Custom LLM Optimization Run. @@ -372,7 +363,6 @@ func newUpdateCustomLlm() *cobra.Command { var updateCustomLlmReq aibuilder.UpdateCustomLlmRequest var updateCustomLlmJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateCustomLlmJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update-custom-llm ID" diff --git a/cmd/workspace/aibi-dashboard-embedding-access-policy/aibi-dashboard-embedding-access-policy.go b/cmd/workspace/aibi-dashboard-embedding-access-policy/aibi-dashboard-embedding-access-policy.go index 3a4050ed2f..54a54f5de9 100755 --- a/cmd/workspace/aibi-dashboard-embedding-access-policy/aibi-dashboard-embedding-access-policy.go +++ b/cmd/workspace/aibi-dashboard-embedding-access-policy/aibi-dashboard-embedding-access-policy.go @@ -54,8 +54,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteAibiDashboardEmbeddingAccessPolicySettingRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteReq.Etag, "etag", deleteReq.Etag, `etag used for versioning.`) cmd.Use = "delete" @@ -110,8 +108,6 @@ func newGet() *cobra.Command { var getReq settings.GetAibiDashboardEmbeddingAccessPolicySettingRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -168,7 +164,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateAibiDashboardEmbeddingAccessPolicySettingRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/workspace/aibi-dashboard-embedding-approved-domains/aibi-dashboard-embedding-approved-domains.go b/cmd/workspace/aibi-dashboard-embedding-approved-domains/aibi-dashboard-embedding-approved-domains.go index 54024b6f08..75dfcd900a 100755 --- a/cmd/workspace/aibi-dashboard-embedding-approved-domains/aibi-dashboard-embedding-approved-domains.go +++ b/cmd/workspace/aibi-dashboard-embedding-approved-domains/aibi-dashboard-embedding-approved-domains.go @@ -54,8 +54,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteAibiDashboardEmbeddingApprovedDomainsSettingRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteReq.Etag, "etag", deleteReq.Etag, `etag used for versioning.`) cmd.Use = "delete" @@ -110,8 +108,6 @@ func newGet() *cobra.Command { var getReq settings.GetAibiDashboardEmbeddingApprovedDomainsSettingRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -166,7 +162,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateAibiDashboardEmbeddingApprovedDomainsSettingRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/workspace/alerts-legacy/alerts-legacy.go b/cmd/workspace/alerts-legacy/alerts-legacy.go index 04c2fbcb87..f598c0d128 100755 --- a/cmd/workspace/alerts-legacy/alerts-legacy.go +++ b/cmd/workspace/alerts-legacy/alerts-legacy.go @@ -68,7 +68,6 @@ func newCreate() *cobra.Command { var createReq sql.CreateAlert var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Parent, "parent", createReq.Parent, `The identifier of the workspace folder containing the object.`) @@ -142,8 +141,6 @@ func newDelete() *cobra.Command { var deleteReq sql.DeleteAlertsLegacyRequest - // TODO: short flags - cmd.Use = "delete ALERT_ID" cmd.Short = `Delete an alert.` cmd.Long = `Delete an alert. @@ -216,8 +213,6 @@ func newGet() *cobra.Command { var getReq sql.GetAlertsLegacyRequest - // TODO: short flags - cmd.Use = "get ALERT_ID" cmd.Short = `Get an alert.` cmd.Long = `Get an alert. @@ -336,7 +331,6 @@ func newUpdate() *cobra.Command { var updateReq sql.EditAlert var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().IntVar(&updateReq.Rearm, "rearm", updateReq.Rearm, `Number of seconds after being triggered before the alert rearms itself and can be triggered again.`) diff --git a/cmd/workspace/alerts-v2/alerts-v2.go b/cmd/workspace/alerts-v2/alerts-v2.go index 1e1267fc4e..e5d9994f92 100755 --- a/cmd/workspace/alerts-v2/alerts-v2.go +++ b/cmd/workspace/alerts-v2/alerts-v2.go @@ -60,7 +60,6 @@ func newCreateAlert() *cobra.Command { createAlertReq.Alert = sql.AlertV2{} var createAlertJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createAlertJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createAlertReq.Alert.CustomDescription, "custom-description", createAlertReq.Alert.CustomDescription, `Custom description for the alert.`) @@ -136,8 +135,6 @@ func newGetAlert() *cobra.Command { var getAlertReq sql.GetAlertV2Request - // TODO: short flags - cmd.Use = "get-alert ID" cmd.Short = `Get an alert.` cmd.Long = `Get an alert. @@ -203,8 +200,6 @@ func newListAlerts() *cobra.Command { var listAlertsReq sql.ListAlertsV2Request - // TODO: short flags - cmd.Flags().IntVar(&listAlertsReq.PageSize, "page-size", listAlertsReq.PageSize, ``) cmd.Flags().StringVar(&listAlertsReq.PageToken, "page-token", listAlertsReq.PageToken, ``) @@ -256,8 +251,6 @@ func newTrashAlert() *cobra.Command { var trashAlertReq sql.TrashAlertV2Request - // TODO: short flags - cmd.Use = "trash-alert ID" cmd.Short = `Delete an alert.` cmd.Long = `Delete an alert. @@ -327,7 +320,6 @@ func newUpdateAlert() *cobra.Command { updateAlertReq.Alert = sql.AlertV2{} var updateAlertJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateAlertJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateAlertReq.Alert.CustomDescription, "custom-description", updateAlertReq.Alert.CustomDescription, `Custom description for the alert.`) diff --git a/cmd/workspace/alerts/alerts.go b/cmd/workspace/alerts/alerts.go index c291ac31a4..4d34182e38 100755 --- a/cmd/workspace/alerts/alerts.go +++ b/cmd/workspace/alerts/alerts.go @@ -63,7 +63,6 @@ func newCreate() *cobra.Command { var createReq sql.CreateAlertRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: alert @@ -133,8 +132,6 @@ func newDelete() *cobra.Command { var deleteReq sql.TrashAlertRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete an alert.` cmd.Long = `Delete an alert. @@ -202,8 +199,6 @@ func newGet() *cobra.Command { var getReq sql.GetAlertRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get an alert.` cmd.Long = `Get an alert. @@ -269,8 +264,6 @@ func newList() *cobra.Command { var listReq sql.ListAlertsRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -325,7 +318,6 @@ func newUpdate() *cobra.Command { var updateReq sql.UpdateAlertRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: alert diff --git a/cmd/workspace/apps/apps.go b/cmd/workspace/apps/apps.go index 50fb6fbbef..6cf510f227 100755 --- a/cmd/workspace/apps/apps.go +++ b/cmd/workspace/apps/apps.go @@ -77,7 +77,7 @@ func newCreate() *cobra.Command { cmd.Flags().BoolVar(&createSkipWait, "no-wait", createSkipWait, `do not wait to reach ACTIVE state`) cmd.Flags().DurationVar(&createTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach ACTIVE state`) - // TODO: short flags + cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&createReq.NoCompute, "no-compute", createReq.NoCompute, `If true, the app will not be started after creation.`) @@ -188,8 +188,6 @@ func newDelete() *cobra.Command { var deleteReq apps.DeleteAppRequest - // TODO: short flags - cmd.Use = "delete NAME" cmd.Short = `Delete an app.` cmd.Long = `Delete an app. @@ -253,7 +251,7 @@ func newDeploy() *cobra.Command { cmd.Flags().BoolVar(&deploySkipWait, "no-wait", deploySkipWait, `do not wait to reach SUCCEEDED state`) cmd.Flags().DurationVar(&deployTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach SUCCEEDED state`) - // TODO: short flags + cmd.Flags().Var(&deployJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: deployment_artifacts @@ -349,8 +347,6 @@ func newGet() *cobra.Command { var getReq apps.GetAppRequest - // TODO: short flags - cmd.Use = "get NAME" cmd.Short = `Get an app.` cmd.Long = `Get an app. @@ -407,8 +403,6 @@ func newGetDeployment() *cobra.Command { var getDeploymentReq apps.GetAppDeploymentRequest - // TODO: short flags - cmd.Use = "get-deployment APP_NAME DEPLOYMENT_ID" cmd.Short = `Get an app deployment.` cmd.Long = `Get an app deployment. @@ -468,8 +462,6 @@ func newGetPermissionLevels() *cobra.Command { var getPermissionLevelsReq apps.GetAppPermissionLevelsRequest - // TODO: short flags - cmd.Use = "get-permission-levels APP_NAME" cmd.Short = `Get app permission levels.` cmd.Long = `Get app permission levels. @@ -526,8 +518,6 @@ func newGetPermissions() *cobra.Command { var getPermissionsReq apps.GetAppPermissionsRequest - // TODO: short flags - cmd.Use = "get-permissions APP_NAME" cmd.Short = `Get app permissions.` cmd.Long = `Get app permissions. @@ -585,8 +575,6 @@ func newList() *cobra.Command { var listReq apps.ListAppsRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, `Upper bound for items returned.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Pagination token to go to the next page of apps.`) @@ -638,8 +626,6 @@ func newListDeployments() *cobra.Command { var listDeploymentsReq apps.ListAppDeploymentsRequest - // TODO: short flags - cmd.Flags().IntVar(&listDeploymentsReq.PageSize, "page-size", listDeploymentsReq.PageSize, `Upper bound for items returned.`) cmd.Flags().StringVar(&listDeploymentsReq.PageToken, "page-token", listDeploymentsReq.PageToken, `Pagination token to go to the next page of apps.`) @@ -697,7 +683,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq apps.AppPermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -777,7 +762,6 @@ func newStart() *cobra.Command { cmd.Flags().BoolVar(&startSkipWait, "no-wait", startSkipWait, `do not wait to reach ACTIVE state`) cmd.Flags().DurationVar(&startTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach ACTIVE state`) - // TODO: short flags cmd.Use = "start NAME" cmd.Short = `Start an app.` @@ -859,7 +843,6 @@ func newStop() *cobra.Command { cmd.Flags().BoolVar(&stopSkipWait, "no-wait", stopSkipWait, `do not wait to reach STOPPED state`) cmd.Flags().DurationVar(&stopTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach STOPPED state`) - // TODO: short flags cmd.Use = "stop NAME" cmd.Short = `Stop an app.` @@ -938,7 +921,6 @@ func newUpdate() *cobra.Command { updateReq.App = apps.App{} var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: active_deployment @@ -1021,7 +1003,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq apps.AppPermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list diff --git a/cmd/workspace/artifact-allowlists/artifact-allowlists.go b/cmd/workspace/artifact-allowlists/artifact-allowlists.go index ff5a3c02c9..99f52f2334 100755 --- a/cmd/workspace/artifact-allowlists/artifact-allowlists.go +++ b/cmd/workspace/artifact-allowlists/artifact-allowlists.go @@ -57,8 +57,6 @@ func newGet() *cobra.Command { var getReq catalog.GetArtifactAllowlistRequest - // TODO: short flags - cmd.Use = "get ARTIFACT_TYPE" cmd.Short = `Get an artifact allowlist.` cmd.Long = `Get an artifact allowlist. @@ -121,7 +119,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.SetArtifactAllowlist var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update ARTIFACT_TYPE" diff --git a/cmd/workspace/automatic-cluster-update/automatic-cluster-update.go b/cmd/workspace/automatic-cluster-update/automatic-cluster-update.go index ae0ca36a8a..ad89283db6 100755 --- a/cmd/workspace/automatic-cluster-update/automatic-cluster-update.go +++ b/cmd/workspace/automatic-cluster-update/automatic-cluster-update.go @@ -52,8 +52,6 @@ func newGet() *cobra.Command { var getReq settings.GetAutomaticClusterUpdateSettingRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -108,7 +106,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateAutomaticClusterUpdateSettingRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/workspace/catalogs/catalogs.go b/cmd/workspace/catalogs/catalogs.go index 803f9962c1..a7e442f7dc 100755 --- a/cmd/workspace/catalogs/catalogs.go +++ b/cmd/workspace/catalogs/catalogs.go @@ -66,7 +66,6 @@ func newCreate() *cobra.Command { var createReq catalog.CreateCatalog var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Comment, "comment", createReq.Comment, `User-provided free-form text description.`) @@ -155,8 +154,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteCatalogRequest - // TODO: short flags - cmd.Flags().BoolVar(&deleteReq.Force, "force", deleteReq.Force, `Force deletion even if the catalog is not empty.`) cmd.Use = "delete NAME" @@ -216,8 +213,6 @@ func newGet() *cobra.Command { var getReq catalog.GetCatalogRequest - // TODO: short flags - cmd.Flags().BoolVar(&getReq.IncludeBrowse, "include-browse", getReq.IncludeBrowse, `Whether to include catalogs in the response for which the principal can only access selective metadata for.`) cmd.Use = "get NAME" @@ -278,8 +273,6 @@ func newList() *cobra.Command { var listReq catalog.ListCatalogsRequest - // TODO: short flags - cmd.Flags().BoolVar(&listReq.IncludeBrowse, "include-browse", listReq.IncludeBrowse, `Whether to include catalogs in the response for which the principal can only access selective metadata for.`) cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of catalogs to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -337,7 +330,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdateCatalog var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Comment, "comment", updateReq.Comment, `User-provided free-form text description.`) diff --git a/cmd/workspace/clean-room-assets/clean-room-assets.go b/cmd/workspace/clean-room-assets/clean-room-assets.go index 14242dd59b..bba557b36f 100755 --- a/cmd/workspace/clean-room-assets/clean-room-assets.go +++ b/cmd/workspace/clean-room-assets/clean-room-assets.go @@ -61,7 +61,6 @@ func newCreate() *cobra.Command { createReq.Asset = cleanrooms.CleanRoomAsset{} var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().Var(&createReq.Asset.AssetType, "asset-type", `The type of the asset. Supported values: [FOREIGN_TABLE, NOTEBOOK_FILE, TABLE, VIEW, VOLUME]`) @@ -147,8 +146,6 @@ func newDelete() *cobra.Command { var deleteReq cleanrooms.DeleteCleanRoomAssetRequest - // TODO: short flags - cmd.Use = "delete CLEAN_ROOM_NAME ASSET_TYPE NAME" cmd.Short = `Delete an asset.` cmd.Long = `Delete an asset. @@ -214,8 +211,6 @@ func newGet() *cobra.Command { var getReq cleanrooms.GetCleanRoomAssetRequest - // TODO: short flags - cmd.Use = "get CLEAN_ROOM_NAME ASSET_TYPE NAME" cmd.Short = `Get an asset.` cmd.Long = `Get an asset. @@ -281,8 +276,6 @@ func newList() *cobra.Command { var listReq cleanrooms.ListCleanRoomAssetsRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) cmd.Use = "list CLEAN_ROOM_NAME" @@ -338,7 +331,6 @@ func newUpdate() *cobra.Command { updateReq.Asset = cleanrooms.CleanRoomAsset{} var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().Var(&updateReq.Asset.AssetType, "asset-type", `The type of the asset. Supported values: [FOREIGN_TABLE, NOTEBOOK_FILE, TABLE, VIEW, VOLUME]`) diff --git a/cmd/workspace/clean-room-task-runs/clean-room-task-runs.go b/cmd/workspace/clean-room-task-runs/clean-room-task-runs.go index 30513f4c1b..f4817fb7f8 100755 --- a/cmd/workspace/clean-room-task-runs/clean-room-task-runs.go +++ b/cmd/workspace/clean-room-task-runs/clean-room-task-runs.go @@ -51,8 +51,6 @@ func newList() *cobra.Command { var listReq cleanrooms.ListCleanRoomNotebookTaskRunsRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.NotebookName, "notebook-name", listReq.NotebookName, `Notebook name.`) cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, `The maximum number of task runs to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) diff --git a/cmd/workspace/clean-rooms/clean-rooms.go b/cmd/workspace/clean-rooms/clean-rooms.go index 33808c97a5..69835a14e4 100755 --- a/cmd/workspace/clean-rooms/clean-rooms.go +++ b/cmd/workspace/clean-rooms/clean-rooms.go @@ -61,7 +61,6 @@ func newCreate() *cobra.Command { createReq.CleanRoom = cleanrooms.CleanRoom{} var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.CleanRoom.Comment, "comment", createReq.CleanRoom.Comment, ``) @@ -144,7 +143,6 @@ func newCreateOutputCatalog() *cobra.Command { createOutputCatalogReq.OutputCatalog = cleanrooms.CleanRoomOutputCatalog{} var createOutputCatalogJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createOutputCatalogJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createOutputCatalogReq.OutputCatalog.CatalogName, "catalog-name", createOutputCatalogReq.OutputCatalog.CatalogName, `The name of the output catalog in UC.`) @@ -217,8 +215,6 @@ func newDelete() *cobra.Command { var deleteReq cleanrooms.DeleteCleanRoomRequest - // TODO: short flags - cmd.Use = "delete NAME" cmd.Short = `Delete a clean room.` cmd.Long = `Delete a clean room. @@ -278,8 +274,6 @@ func newGet() *cobra.Command { var getReq cleanrooms.GetCleanRoomRequest - // TODO: short flags - cmd.Use = "get NAME" cmd.Short = `Get a clean room.` cmd.Long = `Get a clean room. @@ -333,8 +327,6 @@ func newList() *cobra.Command { var listReq cleanrooms.ListCleanRoomsRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, `Maximum number of clean rooms to return (i.e., the page length).`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -388,7 +380,6 @@ func newUpdate() *cobra.Command { var updateReq cleanrooms.UpdateCleanRoomRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: clean_room diff --git a/cmd/workspace/cluster-policies/cluster-policies.go b/cmd/workspace/cluster-policies/cluster-policies.go index 898a3622db..03fc1f5d76 100755 --- a/cmd/workspace/cluster-policies/cluster-policies.go +++ b/cmd/workspace/cluster-policies/cluster-policies.go @@ -85,7 +85,6 @@ func newCreate() *cobra.Command { var createReq compute.CreatePolicy var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Definition, "definition", createReq.Definition, `Policy definition document expressed in [Databricks Cluster Policy Definition Language](https://docs.databricks.com/administration-guide/clusters/policy-definition.html).`) @@ -161,7 +160,6 @@ func newDelete() *cobra.Command { var deleteReq compute.DeletePolicy var deleteJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "delete POLICY_ID" @@ -258,7 +256,6 @@ func newEdit() *cobra.Command { var editReq compute.EditPolicy var editJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&editJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&editReq.Definition, "definition", editReq.Definition, `Policy definition document expressed in [Databricks Cluster Policy Definition Language](https://docs.databricks.com/administration-guide/clusters/policy-definition.html).`) @@ -362,8 +359,6 @@ func newGet() *cobra.Command { var getReq compute.GetClusterPolicyRequest - // TODO: short flags - cmd.Use = "get POLICY_ID" cmd.Short = `Get a cluster policy.` cmd.Long = `Get a cluster policy. @@ -432,8 +427,6 @@ func newGetPermissionLevels() *cobra.Command { var getPermissionLevelsReq compute.GetClusterPolicyPermissionLevelsRequest - // TODO: short flags - cmd.Use = "get-permission-levels CLUSTER_POLICY_ID" cmd.Short = `Get cluster policy permission levels.` cmd.Long = `Get cluster policy permission levels. @@ -502,8 +495,6 @@ func newGetPermissions() *cobra.Command { var getPermissionsReq compute.GetClusterPolicyPermissionsRequest - // TODO: short flags - cmd.Use = "get-permissions CLUSTER_POLICY_ID" cmd.Short = `Get cluster policy permissions.` cmd.Long = `Get cluster policy permissions. @@ -573,8 +564,6 @@ func newList() *cobra.Command { var listReq compute.ListClusterPoliciesRequest - // TODO: short flags - cmd.Flags().Var(&listReq.SortColumn, "sort-column", `The cluster policy attribute to sort by. Supported values: [POLICY_CREATION_TIME, POLICY_NAME]`) cmd.Flags().Var(&listReq.SortOrder, "sort-order", `The order in which the policies get listed. Supported values: [ASC, DESC]`) @@ -627,7 +616,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq compute.ClusterPolicyPermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -715,7 +703,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq compute.ClusterPolicyPermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list diff --git a/cmd/workspace/clusters/clusters.go b/cmd/workspace/clusters/clusters.go index fd01c887d8..908f007c1a 100755 --- a/cmd/workspace/clusters/clusters.go +++ b/cmd/workspace/clusters/clusters.go @@ -101,7 +101,6 @@ func newChangeOwner() *cobra.Command { var changeOwnerReq compute.ChangeClusterOwner var changeOwnerJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&changeOwnerJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "change-owner CLUSTER_ID OWNER_USERNAME" @@ -193,7 +192,7 @@ func newCreate() *cobra.Command { cmd.Flags().BoolVar(&createSkipWait, "no-wait", createSkipWait, `do not wait to reach RUNNING state`) cmd.Flags().DurationVar(&createTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach RUNNING state`) - // TODO: short flags + cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&createReq.ApplyPolicyDefaultValues, "apply-policy-default-values", createReq.ApplyPolicyDefaultValues, `When set to true, fixed and default values from the policy will be used for fields that are omitted.`) @@ -353,7 +352,7 @@ func newDelete() *cobra.Command { cmd.Flags().BoolVar(&deleteSkipWait, "no-wait", deleteSkipWait, `do not wait to reach TERMINATED state`) cmd.Flags().DurationVar(&deleteTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach TERMINATED state`) - // TODO: short flags + cmd.Flags().Var(&deleteJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "delete CLUSTER_ID" @@ -469,7 +468,7 @@ func newEdit() *cobra.Command { cmd.Flags().BoolVar(&editSkipWait, "no-wait", editSkipWait, `do not wait to reach RUNNING state`) cmd.Flags().DurationVar(&editTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach RUNNING state`) - // TODO: short flags + cmd.Flags().Var(&editJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&editReq.ApplyPolicyDefaultValues, "apply-policy-default-values", editReq.ApplyPolicyDefaultValues, `When set to true, fixed and default values from the policy will be used for fields that are omitted.`) @@ -622,7 +621,6 @@ func newEvents() *cobra.Command { var eventsReq compute.GetEvents var eventsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&eventsJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().Int64Var(&eventsReq.EndTime, "end-time", eventsReq.EndTime, `The end time in epoch milliseconds.`) @@ -725,8 +723,6 @@ func newGet() *cobra.Command { var getReq compute.GetClusterRequest - // TODO: short flags - cmd.Use = "get CLUSTER_ID" cmd.Short = `Get cluster info.` cmd.Long = `Get cluster info. @@ -796,8 +792,6 @@ func newGetPermissionLevels() *cobra.Command { var getPermissionLevelsReq compute.GetClusterPermissionLevelsRequest - // TODO: short flags - cmd.Use = "get-permission-levels CLUSTER_ID" cmd.Short = `Get cluster permission levels.` cmd.Long = `Get cluster permission levels. @@ -866,8 +860,6 @@ func newGetPermissions() *cobra.Command { var getPermissionsReq compute.GetClusterPermissionsRequest - // TODO: short flags - cmd.Use = "get-permissions CLUSTER_ID" cmd.Short = `Get cluster permissions.` cmd.Long = `Get cluster permissions. @@ -937,8 +929,6 @@ func newList() *cobra.Command { var listReq compute.ListClustersRequest - // TODO: short flags - // TODO: complex arg: filter_by cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, `Use this field to specify the maximum number of results to be returned by the server.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Use next_page_token or prev_page_token returned from the previous request to list the next or previous page of clusters respectively.`) @@ -1081,7 +1071,6 @@ func newPermanentDelete() *cobra.Command { var permanentDeleteReq compute.PermanentDeleteCluster var permanentDeleteJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&permanentDeleteJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "permanent-delete CLUSTER_ID" @@ -1182,7 +1171,6 @@ func newPin() *cobra.Command { var pinReq compute.PinCluster var pinJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&pinJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "pin CLUSTER_ID" @@ -1282,7 +1270,7 @@ func newResize() *cobra.Command { cmd.Flags().BoolVar(&resizeSkipWait, "no-wait", resizeSkipWait, `do not wait to reach RUNNING state`) cmd.Flags().DurationVar(&resizeTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach RUNNING state`) - // TODO: short flags + cmd.Flags().Var(&resizeJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: autoscale @@ -1399,7 +1387,7 @@ func newRestart() *cobra.Command { cmd.Flags().BoolVar(&restartSkipWait, "no-wait", restartSkipWait, `do not wait to reach RUNNING state`) cmd.Flags().DurationVar(&restartTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach RUNNING state`) - // TODO: short flags + cmd.Flags().Var(&restartJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&restartReq.RestartUser, "restart-user", restartReq.RestartUser, ``) @@ -1510,7 +1498,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq compute.ClusterPermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -1646,7 +1633,7 @@ func newStart() *cobra.Command { cmd.Flags().BoolVar(&startSkipWait, "no-wait", startSkipWait, `do not wait to reach RUNNING state`) cmd.Flags().DurationVar(&startTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach RUNNING state`) - // TODO: short flags + cmd.Flags().Var(&startJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "start CLUSTER_ID" @@ -1760,7 +1747,6 @@ func newUnpin() *cobra.Command { var unpinReq compute.UnpinCluster var unpinJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&unpinJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "unpin CLUSTER_ID" @@ -1860,7 +1846,7 @@ func newUpdate() *cobra.Command { cmd.Flags().BoolVar(&updateSkipWait, "no-wait", updateSkipWait, `do not wait to reach RUNNING state`) cmd.Flags().DurationVar(&updateTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach RUNNING state`) - // TODO: short flags + cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: cluster @@ -1981,7 +1967,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq compute.ClusterPermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list diff --git a/cmd/workspace/compliance-security-profile/compliance-security-profile.go b/cmd/workspace/compliance-security-profile/compliance-security-profile.go index bcbfdcd04f..5841dd4e71 100755 --- a/cmd/workspace/compliance-security-profile/compliance-security-profile.go +++ b/cmd/workspace/compliance-security-profile/compliance-security-profile.go @@ -55,8 +55,6 @@ func newGet() *cobra.Command { var getReq settings.GetComplianceSecurityProfileSettingRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -111,7 +109,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateComplianceSecurityProfileSettingRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/workspace/connections/connections.go b/cmd/workspace/connections/connections.go index a4c31dfb1e..bae12cd8ef 100755 --- a/cmd/workspace/connections/connections.go +++ b/cmd/workspace/connections/connections.go @@ -69,7 +69,6 @@ func newCreate() *cobra.Command { var createReq catalog.CreateConnection var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Comment, "comment", createReq.Comment, `User-provided free-form text description.`) @@ -141,8 +140,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteConnectionRequest - // TODO: short flags - cmd.Use = "delete NAME" cmd.Short = `Delete a connection.` cmd.Long = `Delete a connection. @@ -211,8 +208,6 @@ func newGet() *cobra.Command { var getReq catalog.GetConnectionRequest - // TODO: short flags - cmd.Use = "get NAME" cmd.Short = `Get a connection.` cmd.Long = `Get a connection. @@ -281,8 +276,6 @@ func newList() *cobra.Command { var listReq catalog.ListConnectionsRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of connections to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -335,7 +328,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdateConnection var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.NewName, "new-name", updateReq.NewName, `New name for the connection.`) diff --git a/cmd/workspace/consumer-fulfillments/consumer-fulfillments.go b/cmd/workspace/consumer-fulfillments/consumer-fulfillments.go index 25a63e7554..62f6e0be6f 100755 --- a/cmd/workspace/consumer-fulfillments/consumer-fulfillments.go +++ b/cmd/workspace/consumer-fulfillments/consumer-fulfillments.go @@ -52,8 +52,6 @@ func newGet() *cobra.Command { var getReq marketplace.GetListingContentMetadataRequest - // TODO: short flags - cmd.Flags().IntVar(&getReq.PageSize, "page-size", getReq.PageSize, ``) cmd.Flags().StringVar(&getReq.PageToken, "page-token", getReq.PageToken, ``) @@ -107,8 +105,6 @@ func newList() *cobra.Command { var listReq marketplace.ListFulfillmentsRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) diff --git a/cmd/workspace/consumer-installations/consumer-installations.go b/cmd/workspace/consumer-installations/consumer-installations.go index d3f5420a16..d5abab4f7f 100755 --- a/cmd/workspace/consumer-installations/consumer-installations.go +++ b/cmd/workspace/consumer-installations/consumer-installations.go @@ -60,7 +60,6 @@ func newCreate() *cobra.Command { var createReq marketplace.CreateInstallationRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: accepted_consumer_terms @@ -134,8 +133,6 @@ func newDelete() *cobra.Command { var deleteReq marketplace.DeleteInstallationRequest - // TODO: short flags - cmd.Use = "delete LISTING_ID INSTALLATION_ID" cmd.Short = `Uninstall from a listing.` cmd.Long = `Uninstall from a listing. @@ -190,8 +187,6 @@ func newList() *cobra.Command { var listReq marketplace.ListAllInstallationsRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -243,8 +238,6 @@ func newListListingInstallations() *cobra.Command { var listListingInstallationsReq marketplace.ListInstallationsRequest - // TODO: short flags - cmd.Flags().IntVar(&listListingInstallationsReq.PageSize, "page-size", listListingInstallationsReq.PageSize, ``) cmd.Flags().StringVar(&listListingInstallationsReq.PageToken, "page-token", listListingInstallationsReq.PageToken, ``) @@ -299,7 +292,6 @@ func newUpdate() *cobra.Command { var updateReq marketplace.UpdateInstallationRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&updateReq.RotateToken, "rotate-token", updateReq.RotateToken, ``) diff --git a/cmd/workspace/consumer-listings/consumer-listings.go b/cmd/workspace/consumer-listings/consumer-listings.go index 5c4f8059de..a73fac1267 100755 --- a/cmd/workspace/consumer-listings/consumer-listings.go +++ b/cmd/workspace/consumer-listings/consumer-listings.go @@ -57,8 +57,6 @@ func newBatchGet() *cobra.Command { var batchGetReq marketplace.BatchGetListingsRequest - // TODO: short flags - // TODO: array: ids cmd.Use = "batch-get" @@ -113,8 +111,6 @@ func newGet() *cobra.Command { var getReq marketplace.GetListingRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get listing.` cmd.Long = `Get listing. @@ -181,8 +177,6 @@ func newList() *cobra.Command { var listReq marketplace.ListListingsRequest - // TODO: short flags - // TODO: array: assets // TODO: array: categories cmd.Flags().BoolVar(&listReq.IsFree, "is-free", listReq.IsFree, `Filters each listing based on if it is free.`) @@ -242,8 +236,6 @@ func newSearch() *cobra.Command { var searchReq marketplace.SearchListingsRequest - // TODO: short flags - // TODO: array: assets // TODO: array: categories cmd.Flags().BoolVar(&searchReq.IsFree, "is-free", searchReq.IsFree, ``) diff --git a/cmd/workspace/consumer-personalization-requests/consumer-personalization-requests.go b/cmd/workspace/consumer-personalization-requests/consumer-personalization-requests.go index 59e95f5610..47807dfb56 100755 --- a/cmd/workspace/consumer-personalization-requests/consumer-personalization-requests.go +++ b/cmd/workspace/consumer-personalization-requests/consumer-personalization-requests.go @@ -58,7 +58,6 @@ func newCreate() *cobra.Command { var createReq marketplace.CreatePersonalizationRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Comment, "comment", createReq.Comment, ``) @@ -135,8 +134,6 @@ func newGet() *cobra.Command { var getReq marketplace.GetPersonalizationRequestRequest - // TODO: short flags - cmd.Use = "get LISTING_ID" cmd.Short = `Get the personalization request for a listing.` cmd.Long = `Get the personalization request for a listing. @@ -191,8 +188,6 @@ func newList() *cobra.Command { var listReq marketplace.ListAllPersonalizationRequestsRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) diff --git a/cmd/workspace/consumer-providers/consumer-providers.go b/cmd/workspace/consumer-providers/consumer-providers.go index 214364f792..4c61c4ab85 100755 --- a/cmd/workspace/consumer-providers/consumer-providers.go +++ b/cmd/workspace/consumer-providers/consumer-providers.go @@ -55,8 +55,6 @@ func newBatchGet() *cobra.Command { var batchGetReq marketplace.BatchGetProvidersRequest - // TODO: short flags - // TODO: array: ids cmd.Use = "batch-get" @@ -111,8 +109,6 @@ func newGet() *cobra.Command { var getReq marketplace.GetProviderRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get a provider.` cmd.Long = `Get a provider. @@ -179,8 +175,6 @@ func newList() *cobra.Command { var listReq marketplace.ListProvidersRequest - // TODO: short flags - cmd.Flags().BoolVar(&listReq.IsFeatured, "is-featured", listReq.IsFeatured, ``) cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) diff --git a/cmd/workspace/credentials-manager/credentials-manager.go b/cmd/workspace/credentials-manager/credentials-manager.go index 144aef4193..3a1bc9dab9 100755 --- a/cmd/workspace/credentials-manager/credentials-manager.go +++ b/cmd/workspace/credentials-manager/credentials-manager.go @@ -59,7 +59,6 @@ func newExchangeToken() *cobra.Command { var exchangeTokenReq settings.ExchangeTokenRequest var exchangeTokenJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&exchangeTokenJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "exchange-token" diff --git a/cmd/workspace/credentials/credentials.go b/cmd/workspace/credentials/credentials.go index ce1a62124d..96b042b9b1 100755 --- a/cmd/workspace/credentials/credentials.go +++ b/cmd/workspace/credentials/credentials.go @@ -68,7 +68,6 @@ func newCreateCredential() *cobra.Command { var createCredentialReq catalog.CreateCredentialRequest var createCredentialJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createCredentialJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: aws_iam_role @@ -163,8 +162,6 @@ func newDeleteCredential() *cobra.Command { var deleteCredentialReq catalog.DeleteCredentialRequest - // TODO: short flags - cmd.Flags().BoolVar(&deleteCredentialReq.Force, "force", deleteCredentialReq.Force, `Force an update even if there are dependent services (when purpose is **SERVICE**) or dependent external locations and external tables (when purpose is **STORAGE**).`) cmd.Use = "delete-credential NAME_ARG" @@ -225,7 +222,6 @@ func newGenerateTemporaryServiceCredential() *cobra.Command { var generateTemporaryServiceCredentialReq catalog.GenerateTemporaryServiceCredentialRequest var generateTemporaryServiceCredentialJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&generateTemporaryServiceCredentialJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: azure_options @@ -310,8 +306,6 @@ func newGetCredential() *cobra.Command { var getCredentialReq catalog.GetCredentialRequest - // TODO: short flags - cmd.Use = "get-credential NAME_ARG" cmd.Short = `Get a credential.` cmd.Long = `Get a credential. @@ -370,8 +364,6 @@ func newListCredentials() *cobra.Command { var listCredentialsReq catalog.ListCredentialsRequest - // TODO: short flags - cmd.Flags().IntVar(&listCredentialsReq.MaxResults, "max-results", listCredentialsReq.MaxResults, `Maximum number of credentials to return.`) cmd.Flags().StringVar(&listCredentialsReq.PageToken, "page-token", listCredentialsReq.PageToken, `Opaque token to retrieve the next page of results.`) cmd.Flags().Var(&listCredentialsReq.Purpose, "purpose", `Return only credentials for the specified purpose. Supported values: [SERVICE, STORAGE]`) @@ -430,7 +422,6 @@ func newUpdateCredential() *cobra.Command { var updateCredentialReq catalog.UpdateCredentialRequest var updateCredentialJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateCredentialJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: aws_iam_role @@ -518,7 +509,6 @@ func newValidateCredential() *cobra.Command { var validateCredentialReq catalog.ValidateCredentialRequest var validateCredentialJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&validateCredentialJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: aws_iam_role diff --git a/cmd/workspace/dashboard-email-subscriptions/dashboard-email-subscriptions.go b/cmd/workspace/dashboard-email-subscriptions/dashboard-email-subscriptions.go index 0da11badd3..0c4069c772 100755 --- a/cmd/workspace/dashboard-email-subscriptions/dashboard-email-subscriptions.go +++ b/cmd/workspace/dashboard-email-subscriptions/dashboard-email-subscriptions.go @@ -54,8 +54,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteDashboardEmailSubscriptionsRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteReq.Etag, "etag", deleteReq.Etag, `etag used for versioning.`) cmd.Use = "delete" @@ -109,8 +107,6 @@ func newGet() *cobra.Command { var getReq settings.GetDashboardEmailSubscriptionsRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -165,7 +161,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateDashboardEmailSubscriptionsRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/workspace/dashboard-widgets/dashboard-widgets.go b/cmd/workspace/dashboard-widgets/dashboard-widgets.go index 1b4a9779ae..fa92e12063 100755 --- a/cmd/workspace/dashboard-widgets/dashboard-widgets.go +++ b/cmd/workspace/dashboard-widgets/dashboard-widgets.go @@ -62,7 +62,6 @@ func newCreate() *cobra.Command { var createReq sql.CreateWidget var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -126,8 +125,6 @@ func newDelete() *cobra.Command { var deleteReq sql.DeleteDashboardWidgetRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Remove widget.` cmd.Long = `Remove widget. @@ -185,7 +182,6 @@ func newUpdate() *cobra.Command { var updateReq sql.CreateWidget var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update ID" diff --git a/cmd/workspace/dashboards/dashboards.go b/cmd/workspace/dashboards/dashboards.go index ea50eb8d4b..75e1e4b604 100755 --- a/cmd/workspace/dashboards/dashboards.go +++ b/cmd/workspace/dashboards/dashboards.go @@ -65,7 +65,6 @@ func newCreate() *cobra.Command { var createReq sql.DashboardPostContent var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -127,8 +126,6 @@ func newDelete() *cobra.Command { var deleteReq sql.DeleteDashboardRequest - // TODO: short flags - cmd.Use = "delete DASHBOARD_ID" cmd.Short = `Remove a dashboard.` cmd.Long = `Remove a dashboard. @@ -195,8 +192,6 @@ func newGet() *cobra.Command { var getReq sql.GetDashboardRequest - // TODO: short flags - cmd.Use = "get DASHBOARD_ID" cmd.Short = `Retrieve a definition.` cmd.Long = `Retrieve a definition. @@ -263,8 +258,6 @@ func newList() *cobra.Command { var listReq sql.ListDashboardsRequest - // TODO: short flags - cmd.Flags().Var(&listReq.Order, "order", `Name of dashboard attribute to order by. Supported values: [created_at, name]`) cmd.Flags().IntVar(&listReq.Page, "page", listReq.Page, `Page number to retrieve.`) cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, `Number of dashboards to return per page.`) @@ -321,8 +314,6 @@ func newRestore() *cobra.Command { var restoreReq sql.RestoreDashboardRequest - // TODO: short flags - cmd.Use = "restore DASHBOARD_ID" cmd.Short = `Restore a dashboard.` cmd.Long = `Restore a dashboard. @@ -389,7 +380,6 @@ func newUpdate() *cobra.Command { var updateReq sql.DashboardEditContent var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Name, "name", updateReq.Name, `The title of this dashboard that appears in list views and at the top of the dashboard page.`) diff --git a/cmd/workspace/database/database.go b/cmd/workspace/database/database.go index 0a7af919cd..117887647c 100755 --- a/cmd/workspace/database/database.go +++ b/cmd/workspace/database/database.go @@ -71,7 +71,6 @@ func newCreateDatabaseCatalog() *cobra.Command { createDatabaseCatalogReq.Catalog = database.DatabaseCatalog{} var createDatabaseCatalogJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createDatabaseCatalogJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&createDatabaseCatalogReq.Catalog.CreateDatabaseIfNotExists, "create-database-if-not-exists", createDatabaseCatalogReq.Catalog.CreateDatabaseIfNotExists, ``) @@ -161,7 +160,6 @@ func newCreateDatabaseInstance() *cobra.Command { createDatabaseInstanceReq.DatabaseInstance = database.DatabaseInstance{} var createDatabaseInstanceJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createDatabaseInstanceJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createDatabaseInstanceReq.DatabaseInstance.Capacity, "capacity", createDatabaseInstanceReq.DatabaseInstance.Capacity, `The sku of the instance.`) @@ -244,7 +242,6 @@ func newCreateDatabaseTable() *cobra.Command { createDatabaseTableReq.Table = database.DatabaseTable{} var createDatabaseTableJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createDatabaseTableJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createDatabaseTableReq.Table.DatabaseInstanceName, "database-instance-name", createDatabaseTableReq.Table.DatabaseInstanceName, `Name of the target database instance.`) @@ -327,7 +324,6 @@ func newCreateSyncedDatabaseTable() *cobra.Command { createSyncedDatabaseTableReq.SyncedTable = database.SyncedDatabaseTable{} var createSyncedDatabaseTableJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createSyncedDatabaseTableJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: data_synchronization_status @@ -410,8 +406,6 @@ func newDeleteDatabaseCatalog() *cobra.Command { var deleteDatabaseCatalogReq database.DeleteDatabaseCatalogRequest - // TODO: short flags - cmd.Use = "delete-database-catalog NAME" cmd.Short = `Delete a Database Catalog.` cmd.Long = `Delete a Database Catalog.` @@ -463,8 +457,6 @@ func newDeleteDatabaseInstance() *cobra.Command { var deleteDatabaseInstanceReq database.DeleteDatabaseInstanceRequest - // TODO: short flags - cmd.Flags().BoolVar(&deleteDatabaseInstanceReq.Force, "force", deleteDatabaseInstanceReq.Force, `By default, a instance cannot be deleted if it has descendant instances created via PITR.`) cmd.Flags().BoolVar(&deleteDatabaseInstanceReq.Purge, "purge", deleteDatabaseInstanceReq.Purge, `Note purge=false is in development.`) @@ -522,8 +514,6 @@ func newDeleteDatabaseTable() *cobra.Command { var deleteDatabaseTableReq database.DeleteDatabaseTableRequest - // TODO: short flags - cmd.Use = "delete-database-table NAME" cmd.Short = `Delete a Database Table.` cmd.Long = `Delete a Database Table.` @@ -575,8 +565,6 @@ func newDeleteSyncedDatabaseTable() *cobra.Command { var deleteSyncedDatabaseTableReq database.DeleteSyncedDatabaseTableRequest - // TODO: short flags - cmd.Use = "delete-synced-database-table NAME" cmd.Short = `Delete a Synced Database Table.` cmd.Long = `Delete a Synced Database Table.` @@ -628,8 +616,6 @@ func newFindDatabaseInstanceByUid() *cobra.Command { var findDatabaseInstanceByUidReq database.FindDatabaseInstanceByUidRequest - // TODO: short flags - cmd.Flags().StringVar(&findDatabaseInstanceByUidReq.Uid, "uid", findDatabaseInstanceByUidReq.Uid, `UID of the cluster to get.`) cmd.Use = "find-database-instance-by-uid" @@ -682,7 +668,6 @@ func newGenerateDatabaseCredential() *cobra.Command { var generateDatabaseCredentialReq database.GenerateDatabaseCredentialRequest var generateDatabaseCredentialJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&generateDatabaseCredentialJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: instance_names @@ -750,8 +735,6 @@ func newGetDatabaseCatalog() *cobra.Command { var getDatabaseCatalogReq database.GetDatabaseCatalogRequest - // TODO: short flags - cmd.Use = "get-database-catalog NAME" cmd.Short = `Get a Database Catalog.` cmd.Long = `Get a Database Catalog.` @@ -803,8 +786,6 @@ func newGetDatabaseInstance() *cobra.Command { var getDatabaseInstanceReq database.GetDatabaseInstanceRequest - // TODO: short flags - cmd.Use = "get-database-instance NAME" cmd.Short = `Get a Database Instance.` cmd.Long = `Get a Database Instance. @@ -859,8 +840,6 @@ func newGetDatabaseTable() *cobra.Command { var getDatabaseTableReq database.GetDatabaseTableRequest - // TODO: short flags - cmd.Use = "get-database-table NAME" cmd.Short = `Get a Database Table.` cmd.Long = `Get a Database Table.` @@ -912,8 +891,6 @@ func newGetSyncedDatabaseTable() *cobra.Command { var getSyncedDatabaseTableReq database.GetSyncedDatabaseTableRequest - // TODO: short flags - cmd.Use = "get-synced-database-table NAME" cmd.Short = `Get a Synced Database Table.` cmd.Long = `Get a Synced Database Table.` @@ -965,8 +942,6 @@ func newListDatabaseInstances() *cobra.Command { var listDatabaseInstancesReq database.ListDatabaseInstancesRequest - // TODO: short flags - cmd.Flags().IntVar(&listDatabaseInstancesReq.PageSize, "page-size", listDatabaseInstancesReq.PageSize, `Upper bound for items returned.`) cmd.Flags().StringVar(&listDatabaseInstancesReq.PageToken, "page-token", listDatabaseInstancesReq.PageToken, `Pagination token to go to the next page of Database Instances.`) @@ -1018,7 +993,6 @@ func newUpdateDatabaseInstance() *cobra.Command { updateDatabaseInstanceReq.DatabaseInstance = database.DatabaseInstance{} var updateDatabaseInstanceJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateDatabaseInstanceJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateDatabaseInstanceReq.DatabaseInstance.Capacity, "capacity", updateDatabaseInstanceReq.DatabaseInstance.Capacity, `The sku of the instance.`) diff --git a/cmd/workspace/default-namespace/default-namespace.go b/cmd/workspace/default-namespace/default-namespace.go index 80443b7c0d..d5a24dbb7e 100755 --- a/cmd/workspace/default-namespace/default-namespace.go +++ b/cmd/workspace/default-namespace/default-namespace.go @@ -63,8 +63,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteDefaultNamespaceSettingRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteReq.Etag, "etag", deleteReq.Etag, `etag used for versioning.`) cmd.Use = "delete" @@ -122,8 +120,6 @@ func newGet() *cobra.Command { var getReq settings.GetDefaultNamespaceSettingRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -178,7 +174,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateDefaultNamespaceSettingRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/workspace/disable-legacy-access/disable-legacy-access.go b/cmd/workspace/disable-legacy-access/disable-legacy-access.go index 27df1ca8df..3447a8fb8a 100755 --- a/cmd/workspace/disable-legacy-access/disable-legacy-access.go +++ b/cmd/workspace/disable-legacy-access/disable-legacy-access.go @@ -57,8 +57,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteDisableLegacyAccessRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteReq.Etag, "etag", deleteReq.Etag, `etag used for versioning.`) cmd.Use = "delete" @@ -112,8 +110,6 @@ func newGet() *cobra.Command { var getReq settings.GetDisableLegacyAccessRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -168,7 +164,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateDisableLegacyAccessRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/workspace/disable-legacy-dbfs/disable-legacy-dbfs.go b/cmd/workspace/disable-legacy-dbfs/disable-legacy-dbfs.go index ce203f02f9..b748619f44 100755 --- a/cmd/workspace/disable-legacy-dbfs/disable-legacy-dbfs.go +++ b/cmd/workspace/disable-legacy-dbfs/disable-legacy-dbfs.go @@ -63,8 +63,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteDisableLegacyDbfsRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteReq.Etag, "etag", deleteReq.Etag, `etag used for versioning.`) cmd.Use = "delete" @@ -119,8 +117,6 @@ func newGet() *cobra.Command { var getReq settings.GetDisableLegacyDbfsRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -175,7 +171,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateDisableLegacyDbfsRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/workspace/enable-export-notebook/enable-export-notebook.go b/cmd/workspace/enable-export-notebook/enable-export-notebook.go index 9de9b20965..bd916399be 100755 --- a/cmd/workspace/enable-export-notebook/enable-export-notebook.go +++ b/cmd/workspace/enable-export-notebook/enable-export-notebook.go @@ -95,7 +95,6 @@ func newPatchEnableExportNotebook() *cobra.Command { var patchEnableExportNotebookReq settings.UpdateEnableExportNotebookRequest var patchEnableExportNotebookJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&patchEnableExportNotebookJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "patch-enable-export-notebook" diff --git a/cmd/workspace/enable-notebook-table-clipboard/enable-notebook-table-clipboard.go b/cmd/workspace/enable-notebook-table-clipboard/enable-notebook-table-clipboard.go index cd542233e1..db5e1c488a 100755 --- a/cmd/workspace/enable-notebook-table-clipboard/enable-notebook-table-clipboard.go +++ b/cmd/workspace/enable-notebook-table-clipboard/enable-notebook-table-clipboard.go @@ -95,7 +95,6 @@ func newPatchEnableNotebookTableClipboard() *cobra.Command { var patchEnableNotebookTableClipboardReq settings.UpdateEnableNotebookTableClipboardRequest var patchEnableNotebookTableClipboardJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&patchEnableNotebookTableClipboardJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "patch-enable-notebook-table-clipboard" diff --git a/cmd/workspace/enable-results-downloading/enable-results-downloading.go b/cmd/workspace/enable-results-downloading/enable-results-downloading.go index b95259fb6d..4393f8b2c0 100755 --- a/cmd/workspace/enable-results-downloading/enable-results-downloading.go +++ b/cmd/workspace/enable-results-downloading/enable-results-downloading.go @@ -95,7 +95,6 @@ func newPatchEnableResultsDownloading() *cobra.Command { var patchEnableResultsDownloadingReq settings.UpdateEnableResultsDownloadingRequest var patchEnableResultsDownloadingJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&patchEnableResultsDownloadingJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "patch-enable-results-downloading" diff --git a/cmd/workspace/enhanced-security-monitoring/enhanced-security-monitoring.go b/cmd/workspace/enhanced-security-monitoring/enhanced-security-monitoring.go index f70808bb45..2621d13604 100755 --- a/cmd/workspace/enhanced-security-monitoring/enhanced-security-monitoring.go +++ b/cmd/workspace/enhanced-security-monitoring/enhanced-security-monitoring.go @@ -57,8 +57,6 @@ func newGet() *cobra.Command { var getReq settings.GetEnhancedSecurityMonitoringSettingRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -113,7 +111,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateEnhancedSecurityMonitoringSettingRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/workspace/experiments/experiments.go b/cmd/workspace/experiments/experiments.go index ffa86cb9a7..56c3fd1374 100755 --- a/cmd/workspace/experiments/experiments.go +++ b/cmd/workspace/experiments/experiments.go @@ -101,7 +101,6 @@ func newCreateExperiment() *cobra.Command { var createExperimentReq ml.CreateExperiment var createExperimentJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createExperimentJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createExperimentReq.ArtifactLocation, "artifact-location", createExperimentReq.ArtifactLocation, `Location where all artifacts for the experiment are stored.`) @@ -190,7 +189,6 @@ func newCreateLoggedModel() *cobra.Command { var createLoggedModelReq ml.CreateLoggedModelRequest var createLoggedModelJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createLoggedModelJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createLoggedModelReq.ModelType, "model-type", createLoggedModelReq.ModelType, `The type of the model, such as "Agent", "Classifier", "LLM".`) @@ -275,7 +273,6 @@ func newCreateRun() *cobra.Command { var createRunReq ml.CreateRun var createRunJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createRunJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createRunReq.ExperimentId, "experiment-id", createRunReq.ExperimentId, `ID of the associated experiment.`) @@ -352,7 +349,6 @@ func newDeleteExperiment() *cobra.Command { var deleteExperimentReq ml.DeleteExperiment var deleteExperimentJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteExperimentJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "delete-experiment EXPERIMENT_ID" @@ -434,8 +430,6 @@ func newDeleteLoggedModel() *cobra.Command { var deleteLoggedModelReq ml.DeleteLoggedModelRequest - // TODO: short flags - cmd.Use = "delete-logged-model MODEL_ID" cmd.Short = `Delete a logged model.` cmd.Long = `Delete a logged model. @@ -490,8 +484,6 @@ func newDeleteLoggedModelTag() *cobra.Command { var deleteLoggedModelTagReq ml.DeleteLoggedModelTagRequest - // TODO: short flags - cmd.Use = "delete-logged-model-tag MODEL_ID TAG_KEY" cmd.Short = `Delete a tag on a logged model.` cmd.Long = `Delete a tag on a logged model. @@ -549,7 +541,6 @@ func newDeleteRun() *cobra.Command { var deleteRunReq ml.DeleteRun var deleteRunJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteRunJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "delete-run RUN_ID" @@ -630,7 +621,6 @@ func newDeleteRuns() *cobra.Command { var deleteRunsReq ml.DeleteRuns var deleteRunsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteRunsJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().IntVar(&deleteRunsReq.MaxRuns, "max-runs", deleteRunsReq.MaxRuns, `An optional positive integer indicating the maximum number of runs to delete.`) @@ -724,7 +714,6 @@ func newDeleteTag() *cobra.Command { var deleteTagReq ml.DeleteTag var deleteTagJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteTagJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "delete-tag RUN_ID KEY" @@ -810,7 +799,6 @@ func newFinalizeLoggedModel() *cobra.Command { var finalizeLoggedModelReq ml.FinalizeLoggedModelRequest var finalizeLoggedModelJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&finalizeLoggedModelJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "finalize-logged-model MODEL_ID STATUS" @@ -896,8 +884,6 @@ func newGetByName() *cobra.Command { var getByNameReq ml.GetByNameRequest - // TODO: short flags - cmd.Use = "get-by-name EXPERIMENT_NAME" cmd.Short = `Get an experiment by name.` cmd.Long = `Get an experiment by name. @@ -962,8 +948,6 @@ func newGetExperiment() *cobra.Command { var getExperimentReq ml.GetExperimentRequest - // TODO: short flags - cmd.Use = "get-experiment EXPERIMENT_ID" cmd.Short = `Get an experiment.` cmd.Long = `Get an experiment. @@ -1020,8 +1004,6 @@ func newGetHistory() *cobra.Command { var getHistoryReq ml.GetHistoryRequest - // TODO: short flags - cmd.Flags().IntVar(&getHistoryReq.MaxResults, "max-results", getHistoryReq.MaxResults, `Maximum number of Metric records to return per paginated request.`) cmd.Flags().StringVar(&getHistoryReq.PageToken, "page-token", getHistoryReq.PageToken, `Token indicating the page of metric histories to fetch.`) cmd.Flags().StringVar(&getHistoryReq.RunId, "run-id", getHistoryReq.RunId, `ID of the run from which to fetch metric values.`) @@ -1080,8 +1062,6 @@ func newGetLoggedModel() *cobra.Command { var getLoggedModelReq ml.GetLoggedModelRequest - // TODO: short flags - cmd.Use = "get-logged-model MODEL_ID" cmd.Short = `Get a logged model.` cmd.Long = `Get a logged model. @@ -1136,8 +1116,6 @@ func newGetPermissionLevels() *cobra.Command { var getPermissionLevelsReq ml.GetExperimentPermissionLevelsRequest - // TODO: short flags - cmd.Use = "get-permission-levels EXPERIMENT_ID" cmd.Short = `Get experiment permission levels.` cmd.Long = `Get experiment permission levels. @@ -1194,8 +1172,6 @@ func newGetPermissions() *cobra.Command { var getPermissionsReq ml.GetExperimentPermissionsRequest - // TODO: short flags - cmd.Use = "get-permissions EXPERIMENT_ID" cmd.Short = `Get experiment permissions.` cmd.Long = `Get experiment permissions. @@ -1253,8 +1229,6 @@ func newGetRun() *cobra.Command { var getRunReq ml.GetRunRequest - // TODO: short flags - cmd.Flags().StringVar(&getRunReq.RunUuid, "run-uuid", getRunReq.RunUuid, `[Deprecated, use run_id instead] ID of the run to fetch.`) cmd.Use = "get-run RUN_ID" @@ -1318,8 +1292,6 @@ func newListArtifacts() *cobra.Command { var listArtifactsReq ml.ListArtifactsRequest - // TODO: short flags - cmd.Flags().StringVar(&listArtifactsReq.PageToken, "page-token", listArtifactsReq.PageToken, `The token indicating the page of artifact results to fetch.`) cmd.Flags().StringVar(&listArtifactsReq.Path, "path", listArtifactsReq.Path, `Filter artifacts matching this path (a relative path from the root artifact directory).`) cmd.Flags().StringVar(&listArtifactsReq.RunId, "run-id", listArtifactsReq.RunId, `ID of the run whose artifacts to list.`) @@ -1378,8 +1350,6 @@ func newListExperiments() *cobra.Command { var listExperimentsReq ml.ListExperimentsRequest - // TODO: short flags - cmd.Flags().Int64Var(&listExperimentsReq.MaxResults, "max-results", listExperimentsReq.MaxResults, `Maximum number of experiments desired.`) cmd.Flags().StringVar(&listExperimentsReq.PageToken, "page-token", listExperimentsReq.PageToken, `Token indicating the page of experiments to fetch.`) cmd.Flags().Var(&listExperimentsReq.ViewType, "view-type", `Qualifier for type of experiments to be returned. Supported values: [ACTIVE_ONLY, ALL, DELETED_ONLY]`) @@ -1433,7 +1403,6 @@ func newLogBatch() *cobra.Command { var logBatchReq ml.LogBatch var logBatchJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&logBatchJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: metrics @@ -1548,7 +1517,6 @@ func newLogInputs() *cobra.Command { var logInputsReq ml.LogInputs var logInputsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&logInputsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: datasets @@ -1632,7 +1600,6 @@ func newLogLoggedModelParams() *cobra.Command { var logLoggedModelParamsReq ml.LogLoggedModelParamsRequest var logLoggedModelParamsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&logLoggedModelParamsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: params @@ -1709,7 +1676,6 @@ func newLogMetric() *cobra.Command { var logMetricReq ml.LogMetric var logMetricJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&logMetricJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&logMetricReq.DatasetDigest, "dataset-digest", logMetricReq.DatasetDigest, `Dataset digest of the dataset associated with the metric, e.g.`) @@ -1813,7 +1779,6 @@ func newLogModel() *cobra.Command { var logModelReq ml.LogModel var logModelJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&logModelJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&logModelReq.ModelJson, "model-json", logModelReq.ModelJson, `MLmodel file in json format.`) @@ -1888,7 +1853,6 @@ func newLogOutputs() *cobra.Command { var logOutputsReq ml.LogOutputsRequest var logOutputsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&logOutputsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: models @@ -1971,7 +1935,6 @@ func newLogParam() *cobra.Command { var logParamReq ml.LogParam var logParamJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&logParamJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&logParamReq.RunId, "run-id", logParamReq.RunId, `ID of the run under which to log the param.`) @@ -2062,7 +2025,6 @@ func newRestoreExperiment() *cobra.Command { var restoreExperimentReq ml.RestoreExperiment var restoreExperimentJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&restoreExperimentJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "restore-experiment EXPERIMENT_ID" @@ -2148,7 +2110,6 @@ func newRestoreRun() *cobra.Command { var restoreRunReq ml.RestoreRun var restoreRunJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&restoreRunJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "restore-run RUN_ID" @@ -2233,7 +2194,6 @@ func newRestoreRuns() *cobra.Command { var restoreRunsReq ml.RestoreRuns var restoreRunsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&restoreRunsJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().IntVar(&restoreRunsReq.MaxRuns, "max-runs", restoreRunsReq.MaxRuns, `An optional positive integer indicating the maximum number of runs to restore.`) @@ -2327,7 +2287,6 @@ func newSearchExperiments() *cobra.Command { var searchExperimentsReq ml.SearchExperiments var searchExperimentsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&searchExperimentsJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&searchExperimentsReq.Filter, "filter", searchExperimentsReq.Filter, `String representing a SQL filter condition (e.g.`) @@ -2398,7 +2357,6 @@ func newSearchLoggedModels() *cobra.Command { var searchLoggedModelsReq ml.SearchLoggedModelsRequest var searchLoggedModelsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&searchLoggedModelsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: datasets @@ -2473,7 +2431,6 @@ func newSearchRuns() *cobra.Command { var searchRunsReq ml.SearchRuns var searchRunsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&searchRunsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: experiment_ids @@ -2547,7 +2504,6 @@ func newSetExperimentTag() *cobra.Command { var setExperimentTagReq ml.SetExperimentTag var setExperimentTagJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setExperimentTagJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "set-experiment-tag EXPERIMENT_ID KEY VALUE" @@ -2637,7 +2593,6 @@ func newSetLoggedModelTags() *cobra.Command { var setLoggedModelTagsReq ml.SetLoggedModelTagsRequest var setLoggedModelTagsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setLoggedModelTagsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: tags @@ -2709,7 +2664,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq ml.ExperimentPermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -2785,7 +2739,6 @@ func newSetTag() *cobra.Command { var setTagReq ml.SetTag var setTagJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setTagJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&setTagReq.RunId, "run-id", setTagReq.RunId, `ID of the run under which to log the tag.`) @@ -2875,7 +2828,6 @@ func newUpdateExperiment() *cobra.Command { var updateExperimentReq ml.UpdateExperiment var updateExperimentJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateExperimentJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateExperimentReq.NewName, "new-name", updateExperimentReq.NewName, `If provided, the experiment's name is changed to the new name.`) @@ -2958,7 +2910,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq ml.ExperimentPermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -3033,7 +2984,6 @@ func newUpdateRun() *cobra.Command { var updateRunReq ml.UpdateRun var updateRunJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateRunJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().Int64Var(&updateRunReq.EndTime, "end-time", updateRunReq.EndTime, `Unix timestamp in milliseconds of when the run ended.`) diff --git a/cmd/workspace/external-locations/external-locations.go b/cmd/workspace/external-locations/external-locations.go index c9a22f3fe0..eb04fcab87 100755 --- a/cmd/workspace/external-locations/external-locations.go +++ b/cmd/workspace/external-locations/external-locations.go @@ -71,7 +71,6 @@ func newCreate() *cobra.Command { var createReq catalog.CreateExternalLocation var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Comment, "comment", createReq.Comment, `User-provided free-form text description.`) @@ -169,8 +168,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteExternalLocationRequest - // TODO: short flags - cmd.Flags().BoolVar(&deleteReq.Force, "force", deleteReq.Force, `Force deletion even if there are dependent external tables or mounts.`) cmd.Use = "delete NAME" @@ -230,8 +227,6 @@ func newGet() *cobra.Command { var getReq catalog.GetExternalLocationRequest - // TODO: short flags - cmd.Flags().BoolVar(&getReq.IncludeBrowse, "include-browse", getReq.IncludeBrowse, `Whether to include external locations in the response for which the principal can only access selective metadata for.`) cmd.Use = "get NAME" @@ -292,8 +287,6 @@ func newList() *cobra.Command { var listReq catalog.ListExternalLocationsRequest - // TODO: short flags - cmd.Flags().BoolVar(&listReq.IncludeBrowse, "include-browse", listReq.IncludeBrowse, `Whether to include external locations in the response for which the principal can only access selective metadata for.`) cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of external locations to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -350,7 +343,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdateExternalLocation var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Comment, "comment", updateReq.Comment, `User-provided free-form text description.`) diff --git a/cmd/workspace/feature-store/feature-store.go b/cmd/workspace/feature-store/feature-store.go index 38850a9a98..926225680a 100755 --- a/cmd/workspace/feature-store/feature-store.go +++ b/cmd/workspace/feature-store/feature-store.go @@ -70,7 +70,6 @@ func newCreateOnlineStore() *cobra.Command { createOnlineStoreReq.OnlineStore = ml.OnlineStore{} var createOnlineStoreJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createOnlineStoreJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createOnlineStoreReq.OnlineStore.Capacity, "capacity", createOnlineStoreReq.OnlineStore.Capacity, `The capacity of the online store.`) @@ -151,8 +150,6 @@ func newDeleteOnlineStore() *cobra.Command { var deleteOnlineStoreReq ml.DeleteOnlineStoreRequest - // TODO: short flags - cmd.Use = "delete-online-store NAME" cmd.Short = `Delete an Online Feature Store.` cmd.Long = `Delete an Online Feature Store. @@ -207,8 +204,6 @@ func newGetOnlineStore() *cobra.Command { var getOnlineStoreReq ml.GetOnlineStoreRequest - // TODO: short flags - cmd.Use = "get-online-store NAME" cmd.Short = `Get an Online Feature Store.` cmd.Long = `Get an Online Feature Store. @@ -263,8 +258,6 @@ func newListOnlineStores() *cobra.Command { var listOnlineStoresReq ml.ListOnlineStoresRequest - // TODO: short flags - cmd.Flags().IntVar(&listOnlineStoresReq.PageSize, "page-size", listOnlineStoresReq.PageSize, `The maximum number of results to return.`) cmd.Flags().StringVar(&listOnlineStoresReq.PageToken, "page-token", listOnlineStoresReq.PageToken, `Pagination token to go to the next page based on a previous query.`) @@ -315,7 +308,6 @@ func newPublishTable() *cobra.Command { var publishTableReq ml.PublishTableRequest var publishTableJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&publishTableJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "publish-table SOURCE_TABLE_NAME" @@ -388,7 +380,6 @@ func newUpdateOnlineStore() *cobra.Command { updateOnlineStoreReq.OnlineStore = ml.OnlineStore{} var updateOnlineStoreJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateOnlineStoreJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateOnlineStoreReq.OnlineStore.Capacity, "capacity", updateOnlineStoreReq.OnlineStore.Capacity, `The capacity of the online store.`) diff --git a/cmd/workspace/forecasting/forecasting.go b/cmd/workspace/forecasting/forecasting.go index f414c92087..383c135a0d 100755 --- a/cmd/workspace/forecasting/forecasting.go +++ b/cmd/workspace/forecasting/forecasting.go @@ -66,7 +66,7 @@ func newCreateExperiment() *cobra.Command { cmd.Flags().BoolVar(&createExperimentSkipWait, "no-wait", createExperimentSkipWait, `do not wait to reach SUCCEEDED state`) cmd.Flags().DurationVar(&createExperimentTimeout, "timeout", 120*time.Minute, `maximum amount of time to reach SUCCEEDED state`) - // TODO: short flags + cmd.Flags().Var(&createExperimentJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createExperimentReq.CustomWeightsColumn, "custom-weights-column", createExperimentReq.CustomWeightsColumn, `The column in the training table used to customize weights for each time series.`) @@ -201,8 +201,6 @@ func newGetExperiment() *cobra.Command { var getExperimentReq ml.GetForecastingExperimentRequest - // TODO: short flags - cmd.Use = "get-experiment EXPERIMENT_ID" cmd.Short = `Get a forecasting experiment.` cmd.Long = `Get a forecasting experiment. diff --git a/cmd/workspace/functions/functions.go b/cmd/workspace/functions/functions.go index e61464d201..057a43547e 100755 --- a/cmd/workspace/functions/functions.go +++ b/cmd/workspace/functions/functions.go @@ -64,7 +64,6 @@ func newCreate() *cobra.Command { var createReq catalog.CreateFunctionRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -134,8 +133,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteFunctionRequest - // TODO: short flags - cmd.Flags().BoolVar(&deleteReq.Force, "force", deleteReq.Force, `Force deletion even if the function is notempty.`) cmd.Use = "delete NAME" @@ -212,8 +209,6 @@ func newGet() *cobra.Command { var getReq catalog.GetFunctionRequest - // TODO: short flags - cmd.Flags().BoolVar(&getReq.IncludeBrowse, "include-browse", getReq.IncludeBrowse, `Whether to include functions in the response for which the principal can only access selective metadata for.`) cmd.Use = "get NAME" @@ -291,8 +286,6 @@ func newList() *cobra.Command { var listReq catalog.ListFunctionsRequest - // TODO: short flags - cmd.Flags().BoolVar(&listReq.IncludeBrowse, "include-browse", listReq.IncludeBrowse, `Whether to include functions in the response for which the principal can only access selective metadata for.`) cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of functions to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -359,7 +352,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdateFunction var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Owner, "owner", updateReq.Owner, `Username of current owner of function.`) diff --git a/cmd/workspace/genie/genie.go b/cmd/workspace/genie/genie.go index bc17c02bff..9958925f88 100755 --- a/cmd/workspace/genie/genie.go +++ b/cmd/workspace/genie/genie.go @@ -76,7 +76,7 @@ func newCreateMessage() *cobra.Command { cmd.Flags().BoolVar(&createMessageSkipWait, "no-wait", createMessageSkipWait, `do not wait to reach COMPLETED state`) cmd.Flags().DurationVar(&createMessageTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach COMPLETED state`) - // TODO: short flags + cmd.Flags().Var(&createMessageJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create-message SPACE_ID CONVERSATION_ID CONTENT" @@ -175,8 +175,6 @@ func newExecuteMessageAttachmentQuery() *cobra.Command { var executeMessageAttachmentQueryReq dashboards.GenieExecuteMessageAttachmentQueryRequest - // TODO: short flags - cmd.Use = "execute-message-attachment-query SPACE_ID CONVERSATION_ID MESSAGE_ID ATTACHMENT_ID" cmd.Short = `Execute message attachment SQL query.` cmd.Long = `Execute message attachment SQL query. @@ -240,8 +238,6 @@ func newExecuteMessageQuery() *cobra.Command { var executeMessageQueryReq dashboards.GenieExecuteMessageQueryRequest - // TODO: short flags - cmd.Use = "execute-message-query SPACE_ID CONVERSATION_ID MESSAGE_ID" cmd.Short = `[Deprecated] Execute SQL query in a conversation message.` cmd.Long = `[Deprecated] Execute SQL query in a conversation message. @@ -305,8 +301,6 @@ func newGenerateDownloadFullQueryResult() *cobra.Command { var generateDownloadFullQueryResultReq dashboards.GenieGenerateDownloadFullQueryResultRequest - // TODO: short flags - cmd.Use = "generate-download-full-query-result SPACE_ID CONVERSATION_ID MESSAGE_ID ATTACHMENT_ID" cmd.Short = `Generate full query result download.` cmd.Long = `Generate full query result download. @@ -378,8 +372,6 @@ func newGetDownloadFullQueryResult() *cobra.Command { var getDownloadFullQueryResultReq dashboards.GenieGetDownloadFullQueryResultRequest - // TODO: short flags - cmd.Use = "get-download-full-query-result SPACE_ID CONVERSATION_ID MESSAGE_ID ATTACHMENT_ID DOWNLOAD_ID" cmd.Short = `Get download full query result.` cmd.Long = `Get download full query result. @@ -457,8 +449,6 @@ func newGetMessage() *cobra.Command { var getMessageReq dashboards.GenieGetConversationMessageRequest - // TODO: short flags - cmd.Use = "get-message SPACE_ID CONVERSATION_ID MESSAGE_ID" cmd.Short = `Get conversation message.` cmd.Long = `Get conversation message. @@ -521,8 +511,6 @@ func newGetMessageAttachmentQueryResult() *cobra.Command { var getMessageAttachmentQueryResultReq dashboards.GenieGetMessageAttachmentQueryResultRequest - // TODO: short flags - cmd.Use = "get-message-attachment-query-result SPACE_ID CONVERSATION_ID MESSAGE_ID ATTACHMENT_ID" cmd.Short = `Get message attachment SQL query result.` cmd.Long = `Get message attachment SQL query result. @@ -587,8 +575,6 @@ func newGetMessageQueryResult() *cobra.Command { var getMessageQueryResultReq dashboards.GenieGetMessageQueryResultRequest - // TODO: short flags - cmd.Use = "get-message-query-result SPACE_ID CONVERSATION_ID MESSAGE_ID" cmd.Short = `[Deprecated] Get conversation message SQL query result.` cmd.Long = `[Deprecated] Get conversation message SQL query result. @@ -654,8 +640,6 @@ func newGetMessageQueryResultByAttachment() *cobra.Command { var getMessageQueryResultByAttachmentReq dashboards.GenieGetQueryResultByAttachmentRequest - // TODO: short flags - cmd.Use = "get-message-query-result-by-attachment SPACE_ID CONVERSATION_ID MESSAGE_ID ATTACHMENT_ID" cmd.Short = `[Deprecated] Get conversation message SQL query result.` cmd.Long = `[Deprecated] Get conversation message SQL query result. @@ -723,8 +707,6 @@ func newGetSpace() *cobra.Command { var getSpaceReq dashboards.GenieGetSpaceRequest - // TODO: short flags - cmd.Use = "get-space SPACE_ID" cmd.Short = `Get Genie Space.` cmd.Long = `Get Genie Space. @@ -781,8 +763,6 @@ func newListSpaces() *cobra.Command { var listSpacesReq dashboards.GenieListSpacesRequest - // TODO: short flags - cmd.Flags().IntVar(&listSpacesReq.PageSize, "page-size", listSpacesReq.PageSize, `Maximum number of spaces to return per page.`) cmd.Flags().StringVar(&listSpacesReq.PageToken, "page-token", listSpacesReq.PageToken, `Pagination token for getting the next page of results.`) @@ -846,7 +826,7 @@ func newStartConversation() *cobra.Command { cmd.Flags().BoolVar(&startConversationSkipWait, "no-wait", startConversationSkipWait, `do not wait to reach COMPLETED state`) cmd.Flags().DurationVar(&startConversationTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach COMPLETED state`) - // TODO: short flags + cmd.Flags().Var(&startConversationJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "start-conversation SPACE_ID CONTENT" diff --git a/cmd/workspace/git-credentials/git-credentials.go b/cmd/workspace/git-credentials/git-credentials.go index d003851a05..61bcca0417 100755 --- a/cmd/workspace/git-credentials/git-credentials.go +++ b/cmd/workspace/git-credentials/git-credentials.go @@ -64,7 +64,6 @@ func newCreate() *cobra.Command { var createReq workspace.CreateCredentialsRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.GitUsername, "git-username", createReq.GitUsername, `The username or email provided with your Git provider account, depending on which provider you are using.`) @@ -153,8 +152,6 @@ func newDelete() *cobra.Command { var deleteReq workspace.DeleteCredentialsRequest - // TODO: short flags - cmd.Use = "delete CREDENTIAL_ID" cmd.Short = `Delete a credential.` cmd.Long = `Delete a credential. @@ -226,8 +223,6 @@ func newGet() *cobra.Command { var getReq workspace.GetCredentialsRequest - // TODO: short flags - cmd.Use = "get CREDENTIAL_ID" cmd.Short = `Get a credential entry.` cmd.Long = `Get a credential entry. @@ -340,7 +335,6 @@ func newUpdate() *cobra.Command { var updateReq workspace.UpdateCredentialsRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.GitUsername, "git-username", updateReq.GitUsername, `The username or email provided with your Git provider account, depending on which provider you are using.`) diff --git a/cmd/workspace/global-init-scripts/global-init-scripts.go b/cmd/workspace/global-init-scripts/global-init-scripts.go index f81a4dfbe7..ed20214985 100755 --- a/cmd/workspace/global-init-scripts/global-init-scripts.go +++ b/cmd/workspace/global-init-scripts/global-init-scripts.go @@ -67,7 +67,6 @@ func newCreate() *cobra.Command { var createReq compute.GlobalInitScriptCreateRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&createReq.Enabled, "enabled", createReq.Enabled, `Specifies whether the script is enabled.`) @@ -154,8 +153,6 @@ func newDelete() *cobra.Command { var deleteReq compute.DeleteGlobalInitScriptRequest - // TODO: short flags - cmd.Use = "delete SCRIPT_ID" cmd.Short = `Delete init script.` cmd.Long = `Delete init script. @@ -224,8 +221,6 @@ func newGet() *cobra.Command { var getReq compute.GetGlobalInitScriptRequest - // TODO: short flags - cmd.Use = "get SCRIPT_ID" cmd.Short = `Get an init script.` cmd.Long = `Get an init script. @@ -337,7 +332,6 @@ func newUpdate() *cobra.Command { var updateReq compute.GlobalInitScriptUpdateRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&updateReq.Enabled, "enabled", updateReq.Enabled, `Specifies whether the script is enabled.`) diff --git a/cmd/workspace/grants/grants.go b/cmd/workspace/grants/grants.go index 9fa89b72d5..3aabdae525 100755 --- a/cmd/workspace/grants/grants.go +++ b/cmd/workspace/grants/grants.go @@ -64,8 +64,6 @@ func newGet() *cobra.Command { var getReq catalog.GetGrantRequest - // TODO: short flags - cmd.Flags().IntVar(&getReq.MaxResults, "max-results", getReq.MaxResults, `Specifies the maximum number of privileges to return (page length).`) cmd.Flags().StringVar(&getReq.PageToken, "page-token", getReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) cmd.Flags().StringVar(&getReq.Principal, "principal", getReq.Principal, `If provided, only the permissions for the specified principal (user or group) are returned.`) @@ -128,8 +126,6 @@ func newGetEffective() *cobra.Command { var getEffectiveReq catalog.GetEffectiveRequest - // TODO: short flags - cmd.Flags().IntVar(&getEffectiveReq.MaxResults, "max-results", getEffectiveReq.MaxResults, `Specifies the maximum number of privileges to return (page length).`) cmd.Flags().StringVar(&getEffectiveReq.PageToken, "page-token", getEffectiveReq.PageToken, `Opaque token for the next page of results (pagination).`) cmd.Flags().StringVar(&getEffectiveReq.Principal, "principal", getEffectiveReq.Principal, `If provided, only the effective permissions for the specified principal (user or group) are returned.`) @@ -194,7 +190,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdatePermissions var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: changes diff --git a/cmd/workspace/groups/groups.go b/cmd/workspace/groups/groups.go index b6f6d732cc..c792c35a29 100755 --- a/cmd/workspace/groups/groups.go +++ b/cmd/workspace/groups/groups.go @@ -66,7 +66,6 @@ func newCreate() *cobra.Command { var createReq iam.Group var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.DisplayName, "display-name", createReq.DisplayName, `String that represents a human-readable group name.`) @@ -144,8 +143,6 @@ func newDelete() *cobra.Command { var deleteReq iam.DeleteGroupRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete a group.` cmd.Long = `Delete a group. @@ -214,8 +211,6 @@ func newGet() *cobra.Command { var getReq iam.GetGroupRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get group details.` cmd.Long = `Get group details. @@ -284,8 +279,6 @@ func newList() *cobra.Command { var listReq iam.ListGroupsRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.Attributes, "attributes", listReq.Attributes, `Comma-separated list of attributes to return in response.`) cmd.Flags().Int64Var(&listReq.Count, "count", listReq.Count, `Desired number of results per page.`) cmd.Flags().StringVar(&listReq.ExcludedAttributes, "excluded-attributes", listReq.ExcludedAttributes, `Comma-separated list of attributes to exclude in response.`) @@ -343,7 +336,6 @@ func newPatch() *cobra.Command { var patchReq iam.PartialUpdate var patchJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&patchJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: Operations @@ -430,7 +422,6 @@ func newUpdate() *cobra.Command { var updateReq iam.Group var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.DisplayName, "display-name", updateReq.DisplayName, `String that represents a human-readable group name.`) diff --git a/cmd/workspace/instance-pools/instance-pools.go b/cmd/workspace/instance-pools/instance-pools.go index a0db2e5ad5..7e6d69b320 100755 --- a/cmd/workspace/instance-pools/instance-pools.go +++ b/cmd/workspace/instance-pools/instance-pools.go @@ -80,7 +80,6 @@ func newCreate() *cobra.Command { var createReq compute.CreateInstancePool var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: aws_attributes @@ -184,7 +183,6 @@ func newDelete() *cobra.Command { var deleteReq compute.DeleteInstancePool var deleteJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "delete INSTANCE_POOL_ID" @@ -281,7 +279,6 @@ func newEdit() *cobra.Command { var editReq compute.EditInstancePool var editJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&editJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: map via StringToStringVar: custom_tags @@ -381,8 +378,6 @@ func newGet() *cobra.Command { var getReq compute.GetInstancePoolRequest - // TODO: short flags - cmd.Use = "get INSTANCE_POOL_ID" cmd.Short = `Get instance pool information.` cmd.Long = `Get instance pool information. @@ -451,8 +446,6 @@ func newGetPermissionLevels() *cobra.Command { var getPermissionLevelsReq compute.GetInstancePoolPermissionLevelsRequest - // TODO: short flags - cmd.Use = "get-permission-levels INSTANCE_POOL_ID" cmd.Short = `Get instance pool permission levels.` cmd.Long = `Get instance pool permission levels. @@ -521,8 +514,6 @@ func newGetPermissions() *cobra.Command { var getPermissionsReq compute.GetInstancePoolPermissionsRequest - // TODO: short flags - cmd.Use = "get-permissions INSTANCE_POOL_ID" cmd.Short = `Get instance pool permissions.` cmd.Long = `Get instance pool permissions. @@ -632,7 +623,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq compute.InstancePoolPermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -720,7 +710,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq compute.InstancePoolPermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list diff --git a/cmd/workspace/instance-profiles/instance-profiles.go b/cmd/workspace/instance-profiles/instance-profiles.go index 52090fcce2..dfbefe934f 100755 --- a/cmd/workspace/instance-profiles/instance-profiles.go +++ b/cmd/workspace/instance-profiles/instance-profiles.go @@ -63,7 +63,6 @@ func newAdd() *cobra.Command { var addReq compute.AddInstanceProfile var addJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&addJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&addReq.IamRoleArn, "iam-role-arn", addReq.IamRoleArn, `The AWS IAM role ARN of the role associated with the instance profile.`) @@ -152,7 +151,6 @@ func newEdit() *cobra.Command { var editReq compute.InstanceProfile var editJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&editJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&editReq.IamRoleArn, "iam-role-arn", editReq.IamRoleArn, `The AWS IAM role ARN of the role associated with the instance profile.`) @@ -292,7 +290,6 @@ func newRemove() *cobra.Command { var removeReq compute.RemoveInstanceProfile var removeJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&removeJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "remove INSTANCE_PROFILE_ARN" diff --git a/cmd/workspace/ip-access-lists/ip-access-lists.go b/cmd/workspace/ip-access-lists/ip-access-lists.go index 07f7010264..7ac0fe80d6 100755 --- a/cmd/workspace/ip-access-lists/ip-access-lists.go +++ b/cmd/workspace/ip-access-lists/ip-access-lists.go @@ -80,7 +80,6 @@ func newCreate() *cobra.Command { var createReq settings.CreateIpAccessList var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: ip_addresses @@ -190,8 +189,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteIpAccessListRequest - // TODO: short flags - cmd.Use = "delete IP_ACCESS_LIST_ID" cmd.Short = `Delete access list.` cmd.Long = `Delete access list. @@ -260,8 +257,6 @@ func newGet() *cobra.Command { var getReq settings.GetIpAccessListRequest - // TODO: short flags - cmd.Use = "get IP_ACCESS_LIST_ID" cmd.Short = `Get access list.` cmd.Long = `Get access list. @@ -370,7 +365,6 @@ func newReplace() *cobra.Command { var replaceReq settings.ReplaceIpAccessList var replaceJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&replaceJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: ip_addresses @@ -486,7 +480,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateIpAccessList var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&updateReq.Enabled, "enabled", updateReq.Enabled, `Specifies whether this IP access list is enabled.`) diff --git a/cmd/workspace/jobs/jobs.go b/cmd/workspace/jobs/jobs.go index c30d3c69bd..cb440706b4 100755 --- a/cmd/workspace/jobs/jobs.go +++ b/cmd/workspace/jobs/jobs.go @@ -92,7 +92,6 @@ func newCancelAllRuns() *cobra.Command { var cancelAllRunsReq jobs.CancelAllRuns var cancelAllRunsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&cancelAllRunsJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&cancelAllRunsReq.AllQueuedRuns, "all-queued-runs", cancelAllRunsReq.AllQueuedRuns, `Optional boolean parameter to cancel all queued runs.`) @@ -169,7 +168,7 @@ func newCancelRun() *cobra.Command { cmd.Flags().BoolVar(&cancelRunSkipWait, "no-wait", cancelRunSkipWait, `do not wait to reach TERMINATED or SKIPPED state`) cmd.Flags().DurationVar(&cancelRunTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach TERMINATED or SKIPPED state`) - // TODO: short flags + cmd.Flags().Var(&cancelRunJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "cancel-run RUN_ID" @@ -288,7 +287,6 @@ func newCreate() *cobra.Command { var createReq jobs.CreateJob var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -351,7 +349,6 @@ func newDelete() *cobra.Command { var deleteReq jobs.DeleteJob var deleteJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "delete JOB_ID" @@ -450,7 +447,6 @@ func newDeleteRun() *cobra.Command { var deleteRunReq jobs.DeleteRun var deleteRunJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteRunJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "delete-run RUN_ID" @@ -548,8 +544,6 @@ func newExportRun() *cobra.Command { var exportRunReq jobs.ExportRunRequest - // TODO: short flags - cmd.Flags().Var(&exportRunReq.ViewsToExport, "views-to-export", `Which views to export (CODE, DASHBOARDS, or ALL). Supported values: [ALL, CODE, DASHBOARDS]`) cmd.Use = "export-run RUN_ID" @@ -623,8 +617,6 @@ func newGet() *cobra.Command { var getReq jobs.GetJobRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.PageToken, "page-token", getReq.PageToken, `Use next_page_token returned from the previous GetJob response to request the next page of the job's array properties.`) cmd.Use = "get JOB_ID" @@ -708,8 +700,6 @@ func newGetPermissionLevels() *cobra.Command { var getPermissionLevelsReq jobs.GetJobPermissionLevelsRequest - // TODO: short flags - cmd.Use = "get-permission-levels JOB_ID" cmd.Short = `Get job permission levels.` cmd.Long = `Get job permission levels. @@ -778,8 +768,6 @@ func newGetPermissions() *cobra.Command { var getPermissionsReq jobs.GetJobPermissionsRequest - // TODO: short flags - cmd.Use = "get-permissions JOB_ID" cmd.Short = `Get job permissions.` cmd.Long = `Get job permissions. @@ -849,8 +837,6 @@ func newGetRun() *cobra.Command { var getRunReq jobs.GetRunRequest - // TODO: short flags - cmd.Flags().BoolVar(&getRunReq.IncludeHistory, "include-history", getRunReq.IncludeHistory, `Whether to include the repair history in the response.`) cmd.Flags().BoolVar(&getRunReq.IncludeResolvedValues, "include-resolved-values", getRunReq.IncludeResolvedValues, `Whether to include resolved parameter values in the response.`) cmd.Flags().StringVar(&getRunReq.PageToken, "page-token", getRunReq.PageToken, `Use next_page_token returned from the previous GetRun response to request the next page of the run's array properties.`) @@ -936,8 +922,6 @@ func newGetRunOutput() *cobra.Command { var getRunOutputReq jobs.GetRunOutputRequest - // TODO: short flags - cmd.Use = "get-run-output RUN_ID" cmd.Short = `Get the output for a single run.` cmd.Long = `Get the output for a single run. @@ -1018,8 +1002,6 @@ func newList() *cobra.Command { var listReq jobs.ListJobsRequest - // TODO: short flags - cmd.Flags().BoolVar(&listReq.ExpandTasks, "expand-tasks", listReq.ExpandTasks, `Whether to include task and cluster details in the response.`) cmd.Flags().IntVar(&listReq.Limit, "limit", listReq.Limit, `The number of jobs to return.`) cmd.Flags().StringVar(&listReq.Name, "name", listReq.Name, `A filter on the list based on the exact (case insensitive) job name.`) @@ -1074,8 +1056,6 @@ func newListRuns() *cobra.Command { var listRunsReq jobs.ListRunsRequest - // TODO: short flags - cmd.Flags().BoolVar(&listRunsReq.ActiveOnly, "active-only", listRunsReq.ActiveOnly, `If active_only is true, only active runs are included in the results; otherwise, lists both active and completed runs.`) cmd.Flags().BoolVar(&listRunsReq.CompletedOnly, "completed-only", listRunsReq.CompletedOnly, `If completed_only is true, only completed runs are included in the results; otherwise, lists both active and completed runs.`) cmd.Flags().BoolVar(&listRunsReq.ExpandTasks, "expand-tasks", listRunsReq.ExpandTasks, `Whether to include task and cluster details in the response.`) @@ -1141,7 +1121,7 @@ func newRepairRun() *cobra.Command { cmd.Flags().BoolVar(&repairRunSkipWait, "no-wait", repairRunSkipWait, `do not wait to reach TERMINATED or SKIPPED state`) cmd.Flags().DurationVar(&repairRunTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach TERMINATED or SKIPPED state`) - // TODO: short flags + cmd.Flags().Var(&repairRunJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: dbt_commands @@ -1276,7 +1256,6 @@ func newReset() *cobra.Command { var resetReq jobs.ResetJob var resetJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&resetJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "reset" @@ -1347,7 +1326,7 @@ func newRunNow() *cobra.Command { cmd.Flags().BoolVar(&runNowSkipWait, "no-wait", runNowSkipWait, `do not wait to reach TERMINATED or SKIPPED state`) cmd.Flags().DurationVar(&runNowTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach TERMINATED or SKIPPED state`) - // TODO: short flags + cmd.Flags().Var(&runNowJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: dbt_commands @@ -1479,7 +1458,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq jobs.JobPermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -1572,7 +1550,7 @@ func newSubmit() *cobra.Command { cmd.Flags().BoolVar(&submitSkipWait, "no-wait", submitSkipWait, `do not wait to reach TERMINATED or SKIPPED state`) cmd.Flags().DurationVar(&submitTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach TERMINATED or SKIPPED state`) - // TODO: short flags + cmd.Flags().Var(&submitJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -1677,7 +1655,6 @@ func newUpdate() *cobra.Command { var updateReq jobs.UpdateJob var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: fields_to_remove @@ -1780,7 +1757,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq jobs.JobPermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list diff --git a/cmd/workspace/lakeview-embedded/lakeview-embedded.go b/cmd/workspace/lakeview-embedded/lakeview-embedded.go index 06ed7f1f73..ec5b527d0a 100755 --- a/cmd/workspace/lakeview-embedded/lakeview-embedded.go +++ b/cmd/workspace/lakeview-embedded/lakeview-embedded.go @@ -51,8 +51,6 @@ func newGetPublishedDashboardTokenInfo() *cobra.Command { var getPublishedDashboardTokenInfoReq dashboards.GetPublishedDashboardTokenInfoRequest - // TODO: short flags - cmd.Flags().StringVar(&getPublishedDashboardTokenInfoReq.ExternalValue, "external-value", getPublishedDashboardTokenInfoReq.ExternalValue, `Provided external value to be included in the custom claim.`) cmd.Flags().StringVar(&getPublishedDashboardTokenInfoReq.ExternalViewerId, "external-viewer-id", getPublishedDashboardTokenInfoReq.ExternalViewerId, `Provided external viewer id to be included in the custom claim.`) diff --git a/cmd/workspace/lakeview/lakeview.go b/cmd/workspace/lakeview/lakeview.go index 54fcd4e106..e998c8545b 100755 --- a/cmd/workspace/lakeview/lakeview.go +++ b/cmd/workspace/lakeview/lakeview.go @@ -75,7 +75,6 @@ func newCreate() *cobra.Command { createReq.Dashboard = dashboards.Dashboard{} var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Dashboard.DisplayName, "display-name", createReq.Dashboard.DisplayName, `The display name of the dashboard.`) @@ -148,7 +147,6 @@ func newCreateSchedule() *cobra.Command { createScheduleReq.Schedule = dashboards.Schedule{} var createScheduleJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createScheduleJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createScheduleReq.Schedule.DisplayName, "display-name", createScheduleReq.Schedule.DisplayName, `The display name for schedule.`) @@ -225,7 +223,6 @@ func newCreateSubscription() *cobra.Command { createSubscriptionReq.Subscription = dashboards.Subscription{} var createSubscriptionJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createSubscriptionJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create-subscription DASHBOARD_ID SCHEDULE_ID" @@ -298,8 +295,6 @@ func newDeleteSchedule() *cobra.Command { var deleteScheduleReq dashboards.DeleteScheduleRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteScheduleReq.Etag, "etag", deleteScheduleReq.Etag, `The etag for the schedule.`) cmd.Use = "delete-schedule DASHBOARD_ID SCHEDULE_ID" @@ -358,8 +353,6 @@ func newDeleteSubscription() *cobra.Command { var deleteSubscriptionReq dashboards.DeleteSubscriptionRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteSubscriptionReq.Etag, "etag", deleteSubscriptionReq.Etag, `The etag for the subscription.`) cmd.Use = "delete-subscription DASHBOARD_ID SCHEDULE_ID SUBSCRIPTION_ID" @@ -420,8 +413,6 @@ func newGet() *cobra.Command { var getReq dashboards.GetDashboardRequest - // TODO: short flags - cmd.Use = "get DASHBOARD_ID" cmd.Short = `Get dashboard.` cmd.Long = `Get dashboard. @@ -478,8 +469,6 @@ func newGetPublished() *cobra.Command { var getPublishedReq dashboards.GetPublishedDashboardRequest - // TODO: short flags - cmd.Use = "get-published DASHBOARD_ID" cmd.Short = `Get published dashboard.` cmd.Long = `Get published dashboard. @@ -536,8 +525,6 @@ func newGetSchedule() *cobra.Command { var getScheduleReq dashboards.GetScheduleRequest - // TODO: short flags - cmd.Use = "get-schedule DASHBOARD_ID SCHEDULE_ID" cmd.Short = `Get dashboard schedule.` cmd.Long = `Get dashboard schedule. @@ -594,8 +581,6 @@ func newGetSubscription() *cobra.Command { var getSubscriptionReq dashboards.GetSubscriptionRequest - // TODO: short flags - cmd.Use = "get-subscription DASHBOARD_ID SCHEDULE_ID SUBSCRIPTION_ID" cmd.Short = `Get schedule subscription.` cmd.Long = `Get schedule subscription. @@ -654,8 +639,6 @@ func newList() *cobra.Command { var listReq dashboards.ListDashboardsRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, `The number of dashboards to return per page.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `A page token, received from a previous ListDashboards call.`) cmd.Flags().BoolVar(&listReq.ShowTrashed, "show-trashed", listReq.ShowTrashed, `The flag to include dashboards located in the trash.`) @@ -707,8 +690,6 @@ func newListSchedules() *cobra.Command { var listSchedulesReq dashboards.ListSchedulesRequest - // TODO: short flags - cmd.Flags().IntVar(&listSchedulesReq.PageSize, "page-size", listSchedulesReq.PageSize, `The number of schedules to return per page.`) cmd.Flags().StringVar(&listSchedulesReq.PageToken, "page-token", listSchedulesReq.PageToken, `A page token, received from a previous ListSchedules call.`) @@ -763,8 +744,6 @@ func newListSubscriptions() *cobra.Command { var listSubscriptionsReq dashboards.ListSubscriptionsRequest - // TODO: short flags - cmd.Flags().IntVar(&listSubscriptionsReq.PageSize, "page-size", listSubscriptionsReq.PageSize, `The number of subscriptions to return per page.`) cmd.Flags().StringVar(&listSubscriptionsReq.PageToken, "page-token", listSubscriptionsReq.PageToken, `A page token, received from a previous ListSubscriptions call.`) @@ -822,7 +801,6 @@ func newMigrate() *cobra.Command { var migrateReq dashboards.MigrateDashboardRequest var migrateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&migrateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&migrateReq.DisplayName, "display-name", migrateReq.DisplayName, `Display name for the new Lakeview dashboard.`) @@ -907,7 +885,6 @@ func newPublish() *cobra.Command { var publishReq dashboards.PublishRequest var publishJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&publishJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&publishReq.EmbedCredentials, "embed-credentials", publishReq.EmbedCredentials, `Flag to indicate if the publisher's credentials should be embedded in the published dashboard.`) @@ -981,8 +958,6 @@ func newTrash() *cobra.Command { var trashReq dashboards.TrashDashboardRequest - // TODO: short flags - cmd.Use = "trash DASHBOARD_ID" cmd.Short = `Trash dashboard.` cmd.Long = `Trash dashboard. @@ -1039,8 +1014,6 @@ func newUnpublish() *cobra.Command { var unpublishReq dashboards.UnpublishDashboardRequest - // TODO: short flags - cmd.Use = "unpublish DASHBOARD_ID" cmd.Short = `Unpublish dashboard.` cmd.Long = `Unpublish dashboard. @@ -1099,7 +1072,6 @@ func newUpdate() *cobra.Command { updateReq.Dashboard = dashboards.Dashboard{} var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Dashboard.DisplayName, "display-name", updateReq.Dashboard.DisplayName, `The display name of the dashboard.`) @@ -1176,7 +1148,6 @@ func newUpdateSchedule() *cobra.Command { updateScheduleReq.Schedule = dashboards.Schedule{} var updateScheduleJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateScheduleJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateScheduleReq.Schedule.DisplayName, "display-name", updateScheduleReq.Schedule.DisplayName, `The display name for schedule.`) diff --git a/cmd/workspace/libraries/libraries.go b/cmd/workspace/libraries/libraries.go index fb2b375dfd..8599ba0057 100755 --- a/cmd/workspace/libraries/libraries.go +++ b/cmd/workspace/libraries/libraries.go @@ -112,8 +112,6 @@ func newClusterStatus() *cobra.Command { var clusterStatusReq compute.ClusterStatus - // TODO: short flags - cmd.Use = "cluster-status CLUSTER_ID" cmd.Short = `Get status.` cmd.Long = `Get status. @@ -174,7 +172,6 @@ func newInstall() *cobra.Command { var installReq compute.InstallLibraries var installJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&installJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "install" @@ -240,7 +237,6 @@ func newUninstall() *cobra.Command { var uninstallReq compute.UninstallLibraries var uninstallJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&uninstallJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "uninstall" diff --git a/cmd/workspace/llm-proxy-partner-powered-workspace/llm-proxy-partner-powered-workspace.go b/cmd/workspace/llm-proxy-partner-powered-workspace/llm-proxy-partner-powered-workspace.go index 79b26167b0..7faa64c2f7 100755 --- a/cmd/workspace/llm-proxy-partner-powered-workspace/llm-proxy-partner-powered-workspace.go +++ b/cmd/workspace/llm-proxy-partner-powered-workspace/llm-proxy-partner-powered-workspace.go @@ -56,8 +56,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteLlmProxyPartnerPoweredWorkspaceRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteReq.Etag, "etag", deleteReq.Etag, `etag used for versioning.`) cmd.Use = "delete" @@ -112,8 +110,6 @@ func newGet() *cobra.Command { var getReq settings.GetLlmProxyPartnerPoweredWorkspaceRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -168,7 +164,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateLlmProxyPartnerPoweredWorkspaceRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/workspace/metastores/metastores.go b/cmd/workspace/metastores/metastores.go index fe5bfb5178..bd6a372f91 100755 --- a/cmd/workspace/metastores/metastores.go +++ b/cmd/workspace/metastores/metastores.go @@ -76,7 +76,6 @@ func newAssign() *cobra.Command { var assignReq catalog.CreateMetastoreAssignment var assignJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&assignJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "assign WORKSPACE_ID METASTORE_ID DEFAULT_CATALOG_NAME" @@ -170,7 +169,6 @@ func newCreate() *cobra.Command { var createReq catalog.CreateMetastore var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Region, "region", createReq.Region, `Cloud region which the metastore serves (e.g., us-west-2, westus).`) @@ -299,8 +297,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteMetastoreRequest - // TODO: short flags - cmd.Flags().BoolVar(&deleteReq.Force, "force", deleteReq.Force, `Force deletion even if the metastore is not empty.`) cmd.Use = "delete ID" @@ -359,8 +355,6 @@ func newGet() *cobra.Command { var getReq catalog.GetMetastoreRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get a metastore.` cmd.Long = `Get a metastore. @@ -418,8 +412,6 @@ func newList() *cobra.Command { var listReq catalog.ListMetastoresRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of metastores to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -516,8 +508,6 @@ func newUnassign() *cobra.Command { var unassignReq catalog.UnassignRequest - // TODO: short flags - cmd.Use = "unassign WORKSPACE_ID METASTORE_ID" cmd.Short = `Delete an assignment.` cmd.Long = `Delete an assignment. @@ -580,7 +570,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdateMetastore var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.DeltaSharingOrganizationName, "delta-sharing-organization-name", updateReq.DeltaSharingOrganizationName, `The organization name of a Delta Sharing entity, to be used in Databricks-to-Databricks Delta Sharing as the official name.`) @@ -662,7 +651,6 @@ func newUpdateAssignment() *cobra.Command { var updateAssignmentReq catalog.UpdateMetastoreAssignment var updateAssignmentJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateAssignmentJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateAssignmentReq.DefaultCatalogName, "default-catalog-name", updateAssignmentReq.DefaultCatalogName, `The name of the default catalog in the metastore.`) diff --git a/cmd/workspace/model-registry/model-registry.go b/cmd/workspace/model-registry/model-registry.go index a5a41d7f59..f874f3b2df 100755 --- a/cmd/workspace/model-registry/model-registry.go +++ b/cmd/workspace/model-registry/model-registry.go @@ -97,7 +97,6 @@ func newApproveTransitionRequest() *cobra.Command { var approveTransitionRequestReq ml.ApproveTransitionRequest var approveTransitionRequestJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&approveTransitionRequestJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&approveTransitionRequestReq.Comment, "comment", approveTransitionRequestReq.Comment, `User-provided comment on the action.`) @@ -208,7 +207,6 @@ func newCreateComment() *cobra.Command { var createCommentReq ml.CreateComment var createCommentJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createCommentJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create-comment NAME VERSION COMMENT" @@ -299,7 +297,6 @@ func newCreateModel() *cobra.Command { var createModelReq ml.CreateModelRequest var createModelJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createModelJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createModelReq.Description, "description", createModelReq.Description, `Optional description for registered model.`) @@ -386,7 +383,6 @@ func newCreateModelVersion() *cobra.Command { var createModelVersionReq ml.CreateModelVersionRequest var createModelVersionJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createModelVersionJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createModelVersionReq.Description, "description", createModelVersionReq.Description, `Optional description for model version.`) @@ -476,7 +472,6 @@ func newCreateTransitionRequest() *cobra.Command { var createTransitionRequestReq ml.CreateTransitionRequest var createTransitionRequestJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createTransitionRequestJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createTransitionRequestReq.Comment, "comment", createTransitionRequestReq.Comment, `User-provided comment on the action.`) @@ -579,7 +574,6 @@ func newCreateWebhook() *cobra.Command { var createWebhookReq ml.CreateRegistryWebhook var createWebhookJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createWebhookJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createWebhookReq.Description, "description", createWebhookReq.Description, `User-specified description for the webhook.`) @@ -651,8 +645,6 @@ func newDeleteComment() *cobra.Command { var deleteCommentReq ml.DeleteCommentRequest - // TODO: short flags - cmd.Use = "delete-comment ID" cmd.Short = `Delete a comment.` cmd.Long = `Delete a comment. @@ -709,8 +701,6 @@ func newDeleteModel() *cobra.Command { var deleteModelReq ml.DeleteModelRequest - // TODO: short flags - cmd.Use = "delete-model NAME" cmd.Short = `Delete a model.` cmd.Long = `Delete a model. @@ -767,8 +757,6 @@ func newDeleteModelTag() *cobra.Command { var deleteModelTagReq ml.DeleteModelTagRequest - // TODO: short flags - cmd.Use = "delete-model-tag NAME KEY" cmd.Short = `Delete a model tag.` cmd.Long = `Delete a model tag. @@ -828,8 +816,6 @@ func newDeleteModelVersion() *cobra.Command { var deleteModelVersionReq ml.DeleteModelVersionRequest - // TODO: short flags - cmd.Use = "delete-model-version NAME VERSION" cmd.Short = `Delete a model version.` cmd.Long = `Delete a model version. @@ -888,8 +874,6 @@ func newDeleteModelVersionTag() *cobra.Command { var deleteModelVersionTagReq ml.DeleteModelVersionTagRequest - // TODO: short flags - cmd.Use = "delete-model-version-tag NAME VERSION KEY" cmd.Short = `Delete a model version tag.` cmd.Long = `Delete a model version tag. @@ -951,8 +935,6 @@ func newDeleteTransitionRequest() *cobra.Command { var deleteTransitionRequestReq ml.DeleteTransitionRequestRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteTransitionRequestReq.Comment, "comment", deleteTransitionRequestReq.Comment, `User-provided comment on the action.`) cmd.Use = "delete-transition-request NAME VERSION STAGE CREATOR" @@ -1031,8 +1013,6 @@ func newDeleteWebhook() *cobra.Command { var deleteWebhookReq ml.DeleteWebhookRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteWebhookReq.Id, "id", deleteWebhookReq.Id, `Webhook ID required to delete a registry webhook.`) cmd.Use = "delete-webhook" @@ -1089,7 +1069,6 @@ func newGetLatestVersions() *cobra.Command { var getLatestVersionsReq ml.GetLatestVersionsRequest var getLatestVersionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&getLatestVersionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: stages @@ -1168,8 +1147,6 @@ func newGetModel() *cobra.Command { var getModelReq ml.GetModelRequest - // TODO: short flags - cmd.Use = "get-model NAME" cmd.Short = `Get model.` cmd.Long = `Get model. @@ -1230,8 +1207,6 @@ func newGetModelVersion() *cobra.Command { var getModelVersionReq ml.GetModelVersionRequest - // TODO: short flags - cmd.Use = "get-model-version NAME VERSION" cmd.Short = `Get a model version.` cmd.Long = `Get a model version. @@ -1290,8 +1265,6 @@ func newGetModelVersionDownloadUri() *cobra.Command { var getModelVersionDownloadUriReq ml.GetModelVersionDownloadUriRequest - // TODO: short flags - cmd.Use = "get-model-version-download-uri NAME VERSION" cmd.Short = `Get a model version URI.` cmd.Long = `Get a model version URI. @@ -1350,8 +1323,6 @@ func newGetPermissionLevels() *cobra.Command { var getPermissionLevelsReq ml.GetRegisteredModelPermissionLevelsRequest - // TODO: short flags - cmd.Use = "get-permission-levels REGISTERED_MODEL_ID" cmd.Short = `Get registered model permission levels.` cmd.Long = `Get registered model permission levels. @@ -1408,8 +1379,6 @@ func newGetPermissions() *cobra.Command { var getPermissionsReq ml.GetRegisteredModelPermissionsRequest - // TODO: short flags - cmd.Use = "get-permissions REGISTERED_MODEL_ID" cmd.Short = `Get registered model permissions.` cmd.Long = `Get registered model permissions. @@ -1467,8 +1436,6 @@ func newListModels() *cobra.Command { var listModelsReq ml.ListModelsRequest - // TODO: short flags - cmd.Flags().IntVar(&listModelsReq.MaxResults, "max-results", listModelsReq.MaxResults, `Maximum number of registered models desired.`) cmd.Flags().StringVar(&listModelsReq.PageToken, "page-token", listModelsReq.PageToken, `Pagination token to go to the next page based on a previous query.`) @@ -1521,8 +1488,6 @@ func newListTransitionRequests() *cobra.Command { var listTransitionRequestsReq ml.ListTransitionRequestsRequest - // TODO: short flags - cmd.Use = "list-transition-requests NAME VERSION" cmd.Short = `List transition requests.` cmd.Long = `List transition requests. @@ -1578,8 +1543,6 @@ func newListWebhooks() *cobra.Command { var listWebhooksReq ml.ListWebhooksRequest - // TODO: short flags - // TODO: array: events cmd.Flags().StringVar(&listWebhooksReq.ModelName, "model-name", listWebhooksReq.ModelName, `If not specified, all webhooks associated with the specified events are listed, regardless of their associated model.`) cmd.Flags().StringVar(&listWebhooksReq.PageToken, "page-token", listWebhooksReq.PageToken, `Token indicating the page of artifact results to fetch.`) @@ -1635,7 +1598,6 @@ func newRejectTransitionRequest() *cobra.Command { var rejectTransitionRequestReq ml.RejectTransitionRequest var rejectTransitionRequestJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&rejectTransitionRequestJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&rejectTransitionRequestReq.Comment, "comment", rejectTransitionRequestReq.Comment, `User-provided comment on the action.`) @@ -1738,7 +1700,6 @@ func newRenameModel() *cobra.Command { var renameModelReq ml.RenameModelRequest var renameModelJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&renameModelJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&renameModelReq.NewName, "new-name", renameModelReq.NewName, `If provided, updates the name for this registered_model.`) @@ -1820,8 +1781,6 @@ func newSearchModelVersions() *cobra.Command { var searchModelVersionsReq ml.SearchModelVersionsRequest - // TODO: short flags - cmd.Flags().StringVar(&searchModelVersionsReq.Filter, "filter", searchModelVersionsReq.Filter, `String filter condition, like "name='my-model-name'".`) cmd.Flags().IntVar(&searchModelVersionsReq.MaxResults, "max-results", searchModelVersionsReq.MaxResults, `Maximum number of models desired.`) // TODO: array: order_by @@ -1875,8 +1834,6 @@ func newSearchModels() *cobra.Command { var searchModelsReq ml.SearchModelsRequest - // TODO: short flags - cmd.Flags().StringVar(&searchModelsReq.Filter, "filter", searchModelsReq.Filter, `String filter condition, like "name LIKE 'my-model-name'".`) cmd.Flags().IntVar(&searchModelsReq.MaxResults, "max-results", searchModelsReq.MaxResults, `Maximum number of models desired.`) // TODO: array: order_by @@ -1931,7 +1888,6 @@ func newSetModelTag() *cobra.Command { var setModelTagReq ml.SetModelTagRequest var setModelTagJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setModelTagJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "set-model-tag NAME KEY VALUE" @@ -2025,7 +1981,6 @@ func newSetModelVersionTag() *cobra.Command { var setModelVersionTagReq ml.SetModelVersionTagRequest var setModelVersionTagJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setModelVersionTagJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "set-model-version-tag NAME VERSION KEY VALUE" @@ -2123,7 +2078,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq ml.RegisteredModelPermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -2199,7 +2153,6 @@ func newTestRegistryWebhook() *cobra.Command { var testRegistryWebhookReq ml.TestRegistryWebhookRequest var testRegistryWebhookJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&testRegistryWebhookJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().Var(&testRegistryWebhookReq.Event, "event", `If event is specified, the test trigger uses the specified event. Supported values: [ @@ -2297,7 +2250,6 @@ func newTransitionStage() *cobra.Command { var transitionStageReq ml.TransitionModelVersionStageDatabricks var transitionStageJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&transitionStageJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&transitionStageReq.Comment, "comment", transitionStageReq.Comment, `User-provided comment on the action.`) @@ -2412,7 +2364,6 @@ func newUpdateComment() *cobra.Command { var updateCommentReq ml.UpdateComment var updateCommentJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateCommentJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update-comment ID COMMENT" @@ -2497,7 +2448,6 @@ func newUpdateModel() *cobra.Command { var updateModelReq ml.UpdateModelRequest var updateModelJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateModelJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateModelReq.Description, "description", updateModelReq.Description, `If provided, updates the description for this registered_model.`) @@ -2580,7 +2530,6 @@ func newUpdateModelVersion() *cobra.Command { var updateModelVersionReq ml.UpdateModelVersionRequest var updateModelVersionJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateModelVersionJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateModelVersionReq.Description, "description", updateModelVersionReq.Description, `If provided, updates the description for this registered_model.`) @@ -2667,7 +2616,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq ml.RegisteredModelPermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -2742,7 +2690,6 @@ func newUpdateWebhook() *cobra.Command { var updateWebhookReq ml.UpdateRegistryWebhook var updateWebhookJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateWebhookJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateWebhookReq.Description, "description", updateWebhookReq.Description, `User-specified description for the webhook.`) diff --git a/cmd/workspace/model-versions/model-versions.go b/cmd/workspace/model-versions/model-versions.go index 773eb4c8be..2d47df8da6 100755 --- a/cmd/workspace/model-versions/model-versions.go +++ b/cmd/workspace/model-versions/model-versions.go @@ -64,8 +64,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteModelVersionRequest - // TODO: short flags - cmd.Use = "delete FULL_NAME VERSION" cmd.Short = `Delete a Model Version.` cmd.Long = `Delete a Model Version. @@ -133,8 +131,6 @@ func newGet() *cobra.Command { var getReq catalog.GetModelVersionRequest - // TODO: short flags - cmd.Flags().BoolVar(&getReq.IncludeAliases, "include-aliases", getReq.IncludeAliases, `Whether to include aliases associated with the model version in the response.`) cmd.Flags().BoolVar(&getReq.IncludeBrowse, "include-browse", getReq.IncludeBrowse, `Whether to include model versions in the response for which the principal can only access selective metadata for.`) @@ -204,8 +200,6 @@ func newGetByAlias() *cobra.Command { var getByAliasReq catalog.GetByAliasRequest - // TODO: short flags - cmd.Flags().BoolVar(&getByAliasReq.IncludeAliases, "include-aliases", getByAliasReq.IncludeAliases, `Whether to include aliases associated with the model version in the response.`) cmd.Use = "get-by-alias FULL_NAME ALIAS" @@ -271,8 +265,6 @@ func newList() *cobra.Command { var listReq catalog.ListModelVersionsRequest - // TODO: short flags - cmd.Flags().BoolVar(&listReq.IncludeBrowse, "include-browse", listReq.IncludeBrowse, `Whether to include model versions in the response for which the principal can only access selective metadata for.`) cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of model versions to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -344,7 +336,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdateModelVersionRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Comment, "comment", updateReq.Comment, `The comment attached to the model version.`) diff --git a/cmd/workspace/notification-destinations/notification-destinations.go b/cmd/workspace/notification-destinations/notification-destinations.go index 84945ef240..785fc7559f 100755 --- a/cmd/workspace/notification-destinations/notification-destinations.go +++ b/cmd/workspace/notification-destinations/notification-destinations.go @@ -61,7 +61,6 @@ func newCreate() *cobra.Command { var createReq settings.CreateNotificationDestinationRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: config @@ -131,8 +130,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteNotificationDestinationRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete a notification destination.` cmd.Long = `Delete a notification destination. @@ -186,8 +183,6 @@ func newGet() *cobra.Command { var getReq settings.GetNotificationDestinationRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get a notification destination.` cmd.Long = `Get a notification destination. @@ -241,8 +236,6 @@ func newList() *cobra.Command { var listReq settings.ListNotificationDestinationsRequest - // TODO: short flags - cmd.Flags().Int64Var(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -295,7 +288,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateNotificationDestinationRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: config diff --git a/cmd/workspace/online-tables/online-tables.go b/cmd/workspace/online-tables/online-tables.go index 4d2540c05d..3fd6a5d8b5 100755 --- a/cmd/workspace/online-tables/online-tables.go +++ b/cmd/workspace/online-tables/online-tables.go @@ -65,7 +65,7 @@ func newCreate() *cobra.Command { cmd.Flags().BoolVar(&createSkipWait, "no-wait", createSkipWait, `do not wait to reach ACTIVE state`) cmd.Flags().DurationVar(&createTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach ACTIVE state`) - // TODO: short flags + cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Table.Name, "name", createReq.Table.Name, `Full three-part (catalog, schema, table) name of the table.`) @@ -149,8 +149,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteOnlineTableRequest - // TODO: short flags - cmd.Use = "delete NAME" cmd.Short = `Delete an Online Table.` cmd.Long = `Delete an Online Table. @@ -209,8 +207,6 @@ func newGet() *cobra.Command { var getReq catalog.GetOnlineTableRequest - // TODO: short flags - cmd.Use = "get NAME" cmd.Short = `Get an Online Table.` cmd.Long = `Get an Online Table. diff --git a/cmd/workspace/permission-migration/permission-migration.go b/cmd/workspace/permission-migration/permission-migration.go index f18428fff0..f56a0ed6f8 100755 --- a/cmd/workspace/permission-migration/permission-migration.go +++ b/cmd/workspace/permission-migration/permission-migration.go @@ -59,7 +59,6 @@ func newMigratePermissions() *cobra.Command { var migratePermissionsReq iam.MigratePermissionsRequest var migratePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&migratePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().IntVar(&migratePermissionsReq.Size, "size", migratePermissionsReq.Size, `The maximum number of permissions that will be migrated.`) diff --git a/cmd/workspace/permissions/permissions.go b/cmd/workspace/permissions/permissions.go index 5c2292dcb9..699e0bb6c6 100755 --- a/cmd/workspace/permissions/permissions.go +++ b/cmd/workspace/permissions/permissions.go @@ -85,8 +85,6 @@ func newGet() *cobra.Command { var getReq iam.GetPermissionRequest - // TODO: short flags - cmd.Use = "get REQUEST_OBJECT_TYPE REQUEST_OBJECT_ID" cmd.Short = `Get object permissions.` cmd.Long = `Get object permissions. @@ -150,8 +148,6 @@ func newGetPermissionLevels() *cobra.Command { var getPermissionLevelsReq iam.GetPermissionLevelsRequest - // TODO: short flags - cmd.Use = "get-permission-levels REQUEST_OBJECT_TYPE REQUEST_OBJECT_ID" cmd.Short = `Get object permission levels.` cmd.Long = `Get object permission levels. @@ -215,7 +211,6 @@ func newSet() *cobra.Command { var setReq iam.SetObjectPermissions var setJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -297,7 +292,6 @@ func newUpdate() *cobra.Command { var updateReq iam.UpdateObjectPermissions var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list diff --git a/cmd/workspace/pipelines/pipelines.go b/cmd/workspace/pipelines/pipelines.go index 6d14ad7dbd..a9278128cc 100755 --- a/cmd/workspace/pipelines/pipelines.go +++ b/cmd/workspace/pipelines/pipelines.go @@ -82,7 +82,6 @@ func newCreate() *cobra.Command { var createReq pipelines.CreatePipeline var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -147,8 +146,6 @@ func newDelete() *cobra.Command { var deleteReq pipelines.DeletePipelineRequest - // TODO: short flags - cmd.Use = "delete PIPELINE_ID" cmd.Short = `Delete a pipeline.` cmd.Long = `Delete a pipeline. @@ -215,8 +212,6 @@ func newGet() *cobra.Command { var getReq pipelines.GetPipelineRequest - // TODO: short flags - cmd.Use = "get PIPELINE_ID" cmd.Short = `Get a pipeline.` cmd.Long = `Get a pipeline.` @@ -280,8 +275,6 @@ func newGetPermissionLevels() *cobra.Command { var getPermissionLevelsReq pipelines.GetPipelinePermissionLevelsRequest - // TODO: short flags - cmd.Use = "get-permission-levels PIPELINE_ID" cmd.Short = `Get pipeline permission levels.` cmd.Long = `Get pipeline permission levels. @@ -350,8 +343,6 @@ func newGetPermissions() *cobra.Command { var getPermissionsReq pipelines.GetPipelinePermissionsRequest - // TODO: short flags - cmd.Use = "get-permissions PIPELINE_ID" cmd.Short = `Get pipeline permissions.` cmd.Long = `Get pipeline permissions. @@ -421,8 +412,6 @@ func newGetUpdate() *cobra.Command { var getUpdateReq pipelines.GetUpdateRequest - // TODO: short flags - cmd.Use = "get-update PIPELINE_ID UPDATE_ID" cmd.Short = `Get a pipeline update.` cmd.Long = `Get a pipeline update. @@ -481,8 +470,6 @@ func newListPipelineEvents() *cobra.Command { var listPipelineEventsReq pipelines.ListPipelineEventsRequest - // TODO: short flags - cmd.Flags().StringVar(&listPipelineEventsReq.Filter, "filter", listPipelineEventsReq.Filter, `Criteria to select a subset of results, expressed using a SQL-like syntax.`) cmd.Flags().IntVar(&listPipelineEventsReq.MaxResults, "max-results", listPipelineEventsReq.MaxResults, `Max number of entries to return in a single page.`) // TODO: array: order_by @@ -553,8 +540,6 @@ func newListPipelines() *cobra.Command { var listPipelinesReq pipelines.ListPipelinesRequest - // TODO: short flags - cmd.Flags().StringVar(&listPipelinesReq.Filter, "filter", listPipelinesReq.Filter, `Select a subset of results based on the specified criteria.`) cmd.Flags().IntVar(&listPipelinesReq.MaxResults, "max-results", listPipelinesReq.MaxResults, `The maximum number of entries to return in a single page.`) // TODO: array: order_by @@ -608,8 +593,6 @@ func newListUpdates() *cobra.Command { var listUpdatesReq pipelines.ListUpdatesRequest - // TODO: short flags - cmd.Flags().IntVar(&listUpdatesReq.MaxResults, "max-results", listUpdatesReq.MaxResults, `Max number of entries to return in a single page.`) cmd.Flags().StringVar(&listUpdatesReq.PageToken, "page-token", listUpdatesReq.PageToken, `Page token returned by previous call.`) cmd.Flags().StringVar(&listUpdatesReq.UntilUpdateId, "until-update-id", listUpdatesReq.UntilUpdateId, `If present, returns updates until and including this update_id.`) @@ -683,7 +666,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq pipelines.PipelinePermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -771,7 +753,6 @@ func newStartUpdate() *cobra.Command { var startUpdateReq pipelines.StartUpdate var startUpdateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&startUpdateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().Var(&startUpdateReq.Cause, "cause", `What triggered this update. Supported values: [ @@ -871,7 +852,6 @@ func newStop() *cobra.Command { cmd.Flags().BoolVar(&stopSkipWait, "no-wait", stopSkipWait, `do not wait to reach IDLE state`) cmd.Flags().DurationVar(&stopTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach IDLE state`) - // TODO: short flags cmd.Use = "stop PIPELINE_ID" cmd.Short = `Stop a pipeline.` @@ -952,7 +932,6 @@ func newUpdate() *cobra.Command { var updateReq pipelines.EditPipeline var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&updateReq.AllowDuplicateNames, "allow-duplicate-names", updateReq.AllowDuplicateNames, `If false, deployment will fail if name has changed and conflicts the name of another pipeline.`) @@ -1067,7 +1046,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq pipelines.PipelinePermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list diff --git a/cmd/workspace/policy-compliance-for-clusters/policy-compliance-for-clusters.go b/cmd/workspace/policy-compliance-for-clusters/policy-compliance-for-clusters.go index ad24e83a44..922a904288 100755 --- a/cmd/workspace/policy-compliance-for-clusters/policy-compliance-for-clusters.go +++ b/cmd/workspace/policy-compliance-for-clusters/policy-compliance-for-clusters.go @@ -66,7 +66,6 @@ func newEnforceCompliance() *cobra.Command { var enforceComplianceReq compute.EnforceClusterComplianceRequest var enforceComplianceJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&enforceComplianceJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&enforceComplianceReq.ValidateOnly, "validate-only", enforceComplianceReq.ValidateOnly, `If set, previews the changes that would be made to a cluster to enforce compliance but does not update the cluster.`) @@ -160,8 +159,6 @@ func newGetCompliance() *cobra.Command { var getComplianceReq compute.GetClusterComplianceRequest - // TODO: short flags - cmd.Use = "get-compliance CLUSTER_ID" cmd.Short = `Get cluster policy compliance.` cmd.Long = `Get cluster policy compliance. @@ -219,8 +216,6 @@ func newListCompliance() *cobra.Command { var listComplianceReq compute.ListClusterCompliancesRequest - // TODO: short flags - cmd.Flags().IntVar(&listComplianceReq.PageSize, "page-size", listComplianceReq.PageSize, `Use this field to specify the maximum number of results to be returned by the server.`) cmd.Flags().StringVar(&listComplianceReq.PageToken, "page-token", listComplianceReq.PageToken, `A page token that can be used to navigate to the next page or previous page as returned by next_page_token or prev_page_token.`) diff --git a/cmd/workspace/policy-compliance-for-jobs/policy-compliance-for-jobs.go b/cmd/workspace/policy-compliance-for-jobs/policy-compliance-for-jobs.go index 9de9733957..784be7c5ab 100755 --- a/cmd/workspace/policy-compliance-for-jobs/policy-compliance-for-jobs.go +++ b/cmd/workspace/policy-compliance-for-jobs/policy-compliance-for-jobs.go @@ -69,7 +69,6 @@ func newEnforceCompliance() *cobra.Command { var enforceComplianceReq jobs.EnforcePolicyComplianceRequest var enforceComplianceJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&enforceComplianceJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&enforceComplianceReq.ValidateOnly, "validate-only", enforceComplianceReq.ValidateOnly, `If set, previews changes made to the job to comply with its policy, but does not update the job.`) @@ -157,8 +156,6 @@ func newGetCompliance() *cobra.Command { var getComplianceReq jobs.GetPolicyComplianceRequest - // TODO: short flags - cmd.Use = "get-compliance JOB_ID" cmd.Short = `Get job policy compliance.` cmd.Long = `Get job policy compliance. @@ -220,8 +217,6 @@ func newListCompliance() *cobra.Command { var listComplianceReq jobs.ListJobComplianceRequest - // TODO: short flags - cmd.Flags().IntVar(&listComplianceReq.PageSize, "page-size", listComplianceReq.PageSize, `Use this field to specify the maximum number of results to be returned by the server.`) cmd.Flags().StringVar(&listComplianceReq.PageToken, "page-token", listComplianceReq.PageToken, `A page token that can be used to navigate to the next page or previous page as returned by next_page_token or prev_page_token.`) diff --git a/cmd/workspace/policy-families/policy-families.go b/cmd/workspace/policy-families/policy-families.go index 0f37eee92d..7af92490f6 100755 --- a/cmd/workspace/policy-families/policy-families.go +++ b/cmd/workspace/policy-families/policy-families.go @@ -60,8 +60,6 @@ func newGet() *cobra.Command { var getReq compute.GetPolicyFamilyRequest - // TODO: short flags - cmd.Flags().Int64Var(&getReq.Version, "version", getReq.Version, `The version number for the family to fetch.`) cmd.Use = "get POLICY_FAMILY_ID" @@ -121,8 +119,6 @@ func newList() *cobra.Command { var listReq compute.ListPolicyFamiliesRequest - // TODO: short flags - cmd.Flags().Int64Var(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of policy families to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `A token that can be used to get the next page of results.`) diff --git a/cmd/workspace/provider-exchange-filters/provider-exchange-filters.go b/cmd/workspace/provider-exchange-filters/provider-exchange-filters.go index 50147653bd..7b808c4ee8 100755 --- a/cmd/workspace/provider-exchange-filters/provider-exchange-filters.go +++ b/cmd/workspace/provider-exchange-filters/provider-exchange-filters.go @@ -58,7 +58,6 @@ func newCreate() *cobra.Command { var createReq marketplace.CreateExchangeFilterRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -122,8 +121,6 @@ func newDelete() *cobra.Command { var deleteReq marketplace.DeleteExchangeFilterRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete an exchange filter.` cmd.Long = `Delete an exchange filter. @@ -189,8 +186,6 @@ func newList() *cobra.Command { var listReq marketplace.ListExchangeFiltersRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -245,7 +240,6 @@ func newUpdate() *cobra.Command { var updateReq marketplace.UpdateExchangeFilterRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update ID" diff --git a/cmd/workspace/provider-exchanges/provider-exchanges.go b/cmd/workspace/provider-exchanges/provider-exchanges.go index 79625e820b..94210836c8 100755 --- a/cmd/workspace/provider-exchanges/provider-exchanges.go +++ b/cmd/workspace/provider-exchanges/provider-exchanges.go @@ -64,7 +64,6 @@ func newAddListingToExchange() *cobra.Command { var addListingToExchangeReq marketplace.AddExchangeForListingRequest var addListingToExchangeJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&addListingToExchangeJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "add-listing-to-exchange LISTING_ID EXCHANGE_ID" @@ -145,7 +144,6 @@ func newCreate() *cobra.Command { var createReq marketplace.CreateExchangeRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -209,8 +207,6 @@ func newDelete() *cobra.Command { var deleteReq marketplace.DeleteExchangeRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete an exchange.` cmd.Long = `Delete an exchange. @@ -264,8 +260,6 @@ func newDeleteListingFromExchange() *cobra.Command { var deleteListingFromExchangeReq marketplace.RemoveExchangeForListingRequest - // TODO: short flags - cmd.Use = "delete-listing-from-exchange ID" cmd.Short = `Remove an exchange for listing.` cmd.Long = `Remove an exchange for listing. @@ -319,8 +313,6 @@ func newGet() *cobra.Command { var getReq marketplace.GetExchangeRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get an exchange.` cmd.Long = `Get an exchange.` @@ -372,8 +364,6 @@ func newList() *cobra.Command { var listReq marketplace.ListExchangesRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -425,8 +415,6 @@ func newListExchangesForListing() *cobra.Command { var listExchangesForListingReq marketplace.ListExchangesForListingRequest - // TODO: short flags - cmd.Flags().IntVar(&listExchangesForListingReq.PageSize, "page-size", listExchangesForListingReq.PageSize, ``) cmd.Flags().StringVar(&listExchangesForListingReq.PageToken, "page-token", listExchangesForListingReq.PageToken, ``) @@ -480,8 +468,6 @@ func newListListingsForExchange() *cobra.Command { var listListingsForExchangeReq marketplace.ListListingsForExchangeRequest - // TODO: short flags - cmd.Flags().IntVar(&listListingsForExchangeReq.PageSize, "page-size", listListingsForExchangeReq.PageSize, ``) cmd.Flags().StringVar(&listListingsForExchangeReq.PageToken, "page-token", listListingsForExchangeReq.PageToken, ``) @@ -536,7 +522,6 @@ func newUpdate() *cobra.Command { var updateReq marketplace.UpdateExchangeRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update ID" diff --git a/cmd/workspace/provider-files/provider-files.go b/cmd/workspace/provider-files/provider-files.go index fa0ba4b1a2..08434c3cac 100755 --- a/cmd/workspace/provider-files/provider-files.go +++ b/cmd/workspace/provider-files/provider-files.go @@ -59,7 +59,6 @@ func newCreate() *cobra.Command { var createReq marketplace.CreateFileRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.DisplayName, "display-name", createReq.DisplayName, ``) @@ -126,8 +125,6 @@ func newDelete() *cobra.Command { var deleteReq marketplace.DeleteFileRequest - // TODO: short flags - cmd.Use = "delete FILE_ID" cmd.Short = `Delete a file.` cmd.Long = `Delete a file. @@ -193,8 +190,6 @@ func newGet() *cobra.Command { var getReq marketplace.GetFileRequest - // TODO: short flags - cmd.Use = "get FILE_ID" cmd.Short = `Get a file.` cmd.Long = `Get a file. @@ -261,7 +256,6 @@ func newList() *cobra.Command { var listReq marketplace.ListFilesRequest var listJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&listJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) diff --git a/cmd/workspace/provider-listings/provider-listings.go b/cmd/workspace/provider-listings/provider-listings.go index 4f858b2860..5bac5d5c7d 100755 --- a/cmd/workspace/provider-listings/provider-listings.go +++ b/cmd/workspace/provider-listings/provider-listings.go @@ -60,7 +60,6 @@ func newCreate() *cobra.Command { var createReq marketplace.CreateListingRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -124,8 +123,6 @@ func newDelete() *cobra.Command { var deleteReq marketplace.DeleteListingRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete a listing.` cmd.Long = `Delete a listing. @@ -191,8 +188,6 @@ func newGet() *cobra.Command { var getReq marketplace.GetListingRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get a listing.` cmd.Long = `Get a listing. @@ -258,8 +253,6 @@ func newList() *cobra.Command { var listReq marketplace.GetListingsRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -312,7 +305,6 @@ func newUpdate() *cobra.Command { var updateReq marketplace.UpdateListingRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update ID" diff --git a/cmd/workspace/provider-personalization-requests/provider-personalization-requests.go b/cmd/workspace/provider-personalization-requests/provider-personalization-requests.go index e62462d78f..da94fb0cb3 100755 --- a/cmd/workspace/provider-personalization-requests/provider-personalization-requests.go +++ b/cmd/workspace/provider-personalization-requests/provider-personalization-requests.go @@ -56,8 +56,6 @@ func newList() *cobra.Command { var listReq marketplace.ListAllPersonalizationRequestsRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -111,7 +109,6 @@ func newUpdate() *cobra.Command { var updateReq marketplace.UpdatePersonalizationRequestRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Reason, "reason", updateReq.Reason, ``) diff --git a/cmd/workspace/provider-provider-analytics-dashboards/provider-provider-analytics-dashboards.go b/cmd/workspace/provider-provider-analytics-dashboards/provider-provider-analytics-dashboards.go index 9cfd4fabd4..809256d7af 100755 --- a/cmd/workspace/provider-provider-analytics-dashboards/provider-provider-analytics-dashboards.go +++ b/cmd/workspace/provider-provider-analytics-dashboards/provider-provider-analytics-dashboards.go @@ -179,7 +179,6 @@ func newUpdate() *cobra.Command { var updateReq marketplace.UpdateProviderAnalyticsDashboardRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().Int64Var(&updateReq.Version, "version", updateReq.Version, `this is the version of the dashboard template we want to update our user to current expectation is that it should be equal to latest version of the dashboard template.`) diff --git a/cmd/workspace/provider-providers/provider-providers.go b/cmd/workspace/provider-providers/provider-providers.go index 7f5d61a579..872b998730 100755 --- a/cmd/workspace/provider-providers/provider-providers.go +++ b/cmd/workspace/provider-providers/provider-providers.go @@ -59,7 +59,6 @@ func newCreate() *cobra.Command { var createReq marketplace.CreateProviderRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -123,8 +122,6 @@ func newDelete() *cobra.Command { var deleteReq marketplace.DeleteProviderRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete provider.` cmd.Long = `Delete provider. @@ -190,8 +187,6 @@ func newGet() *cobra.Command { var getReq marketplace.GetProviderRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get provider.` cmd.Long = `Get provider. @@ -257,8 +252,6 @@ func newList() *cobra.Command { var listReq marketplace.ListProvidersRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -311,7 +304,6 @@ func newUpdate() *cobra.Command { var updateReq marketplace.UpdateProviderRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update ID" diff --git a/cmd/workspace/providers/providers.go b/cmd/workspace/providers/providers.go index 5228982aec..08c3549588 100755 --- a/cmd/workspace/providers/providers.go +++ b/cmd/workspace/providers/providers.go @@ -63,7 +63,6 @@ func newCreate() *cobra.Command { var createReq sharing.CreateProvider var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Comment, "comment", createReq.Comment, `Description about the provider.`) @@ -155,8 +154,6 @@ func newDelete() *cobra.Command { var deleteReq sharing.DeleteProviderRequest - // TODO: short flags - cmd.Use = "delete NAME" cmd.Short = `Delete a provider.` cmd.Long = `Delete a provider. @@ -226,8 +223,6 @@ func newGet() *cobra.Command { var getReq sharing.GetProviderRequest - // TODO: short flags - cmd.Use = "get NAME" cmd.Short = `Get a provider.` cmd.Long = `Get a provider. @@ -298,8 +293,6 @@ func newList() *cobra.Command { var listReq sharing.ListProvidersRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.DataProviderGlobalMetastoreId, "data-provider-global-metastore-id", listReq.DataProviderGlobalMetastoreId, `If not provided, all providers will be returned.`) cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of providers to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -355,8 +348,6 @@ func newListProviderShareAssets() *cobra.Command { var listProviderShareAssetsReq sharing.ListProviderShareAssetsRequest - // TODO: short flags - cmd.Flags().IntVar(&listProviderShareAssetsReq.FunctionMaxResults, "function-max-results", listProviderShareAssetsReq.FunctionMaxResults, `Maximum number of functions to return.`) cmd.Flags().IntVar(&listProviderShareAssetsReq.NotebookMaxResults, "notebook-max-results", listProviderShareAssetsReq.NotebookMaxResults, `Maximum number of notebooks to return.`) cmd.Flags().IntVar(&listProviderShareAssetsReq.TableMaxResults, "table-max-results", listProviderShareAssetsReq.TableMaxResults, `Maximum number of tables to return.`) @@ -421,8 +412,6 @@ func newListShares() *cobra.Command { var listSharesReq sharing.ListSharesRequest - // TODO: short flags - cmd.Flags().IntVar(&listSharesReq.MaxResults, "max-results", listSharesReq.MaxResults, `Maximum number of shares to return.`) cmd.Flags().StringVar(&listSharesReq.PageToken, "page-token", listSharesReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -494,7 +483,6 @@ func newUpdate() *cobra.Command { var updateReq sharing.UpdateProvider var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Comment, "comment", updateReq.Comment, `Description about the provider.`) diff --git a/cmd/workspace/quality-monitor-v2/quality-monitor-v2.go b/cmd/workspace/quality-monitor-v2/quality-monitor-v2.go index ea0175fdd5..689dccd4c8 100755 --- a/cmd/workspace/quality-monitor-v2/quality-monitor-v2.go +++ b/cmd/workspace/quality-monitor-v2/quality-monitor-v2.go @@ -60,7 +60,6 @@ func newCreateQualityMonitor() *cobra.Command { createQualityMonitorReq.QualityMonitor = qualitymonitorv2.QualityMonitor{} var createQualityMonitorJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createQualityMonitorJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: anomaly_detection_config @@ -146,8 +145,6 @@ func newDeleteQualityMonitor() *cobra.Command { var deleteQualityMonitorReq qualitymonitorv2.DeleteQualityMonitorRequest - // TODO: short flags - cmd.Use = "delete-quality-monitor OBJECT_TYPE OBJECT_ID" cmd.Short = `Delete a quality monitor.` cmd.Long = `Delete a quality monitor. @@ -206,8 +203,6 @@ func newGetQualityMonitor() *cobra.Command { var getQualityMonitorReq qualitymonitorv2.GetQualityMonitorRequest - // TODO: short flags - cmd.Use = "get-quality-monitor OBJECT_TYPE OBJECT_ID" cmd.Short = `Read a quality monitor.` cmd.Long = `Read a quality monitor. @@ -266,8 +261,6 @@ func newListQualityMonitor() *cobra.Command { var listQualityMonitorReq qualitymonitorv2.ListQualityMonitorRequest - // TODO: short flags - cmd.Flags().IntVar(&listQualityMonitorReq.PageSize, "page-size", listQualityMonitorReq.PageSize, ``) cmd.Flags().StringVar(&listQualityMonitorReq.PageToken, "page-token", listQualityMonitorReq.PageToken, ``) @@ -321,7 +314,6 @@ func newUpdateQualityMonitor() *cobra.Command { updateQualityMonitorReq.QualityMonitor = qualitymonitorv2.QualityMonitor{} var updateQualityMonitorJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateQualityMonitorJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: anomaly_detection_config diff --git a/cmd/workspace/quality-monitors/quality-monitors.go b/cmd/workspace/quality-monitors/quality-monitors.go index f9759af14d..740fe228ef 100755 --- a/cmd/workspace/quality-monitors/quality-monitors.go +++ b/cmd/workspace/quality-monitors/quality-monitors.go @@ -69,8 +69,6 @@ func newCancelRefresh() *cobra.Command { var cancelRefreshReq catalog.CancelRefreshRequest - // TODO: short flags - cmd.Use = "cancel-refresh TABLE_NAME REFRESH_ID" cmd.Short = `Cancel refresh.` cmd.Long = `Cancel refresh. @@ -142,7 +140,6 @@ func newCreate() *cobra.Command { var createReq catalog.CreateMonitor var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.BaselineTableName, "baseline-table-name", createReq.BaselineTableName, `Name of the baseline table from which drift metrics are computed from.`) @@ -250,8 +247,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteQualityMonitorRequest - // TODO: short flags - cmd.Use = "delete TABLE_NAME" cmd.Short = `Delete a table monitor.` cmd.Long = `Delete a table monitor. @@ -320,8 +315,6 @@ func newGet() *cobra.Command { var getReq catalog.GetQualityMonitorRequest - // TODO: short flags - cmd.Use = "get TABLE_NAME" cmd.Short = `Get a table monitor.` cmd.Long = `Get a table monitor. @@ -389,8 +382,6 @@ func newGetRefresh() *cobra.Command { var getRefreshReq catalog.GetRefreshRequest - // TODO: short flags - cmd.Use = "get-refresh TABLE_NAME REFRESH_ID" cmd.Short = `Get refresh.` cmd.Long = `Get refresh. @@ -458,8 +449,6 @@ func newListRefreshes() *cobra.Command { var listRefreshesReq catalog.ListRefreshesRequest - // TODO: short flags - cmd.Use = "list-refreshes TABLE_NAME" cmd.Short = `List refreshes.` cmd.Long = `List refreshes. @@ -527,7 +516,6 @@ func newRegenerateDashboard() *cobra.Command { var regenerateDashboardReq catalog.RegenerateDashboardRequest var regenerateDashboardJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(®enerateDashboardJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(®enerateDashboardReq.WarehouseId, "warehouse-id", regenerateDashboardReq.WarehouseId, `Optional argument to specify the warehouse for dashboard regeneration.`) @@ -613,8 +601,6 @@ func newRunRefresh() *cobra.Command { var runRefreshReq catalog.RunRefreshRequest - // TODO: short flags - cmd.Use = "run-refresh TABLE_NAME" cmd.Short = `Queue a metric refresh for a monitor.` cmd.Long = `Queue a metric refresh for a monitor. @@ -682,7 +668,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdateMonitor var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.BaselineTableName, "baseline-table-name", updateReq.BaselineTableName, `Name of the baseline table from which drift metrics are computed from.`) diff --git a/cmd/workspace/queries-legacy/queries-legacy.go b/cmd/workspace/queries-legacy/queries-legacy.go index c94c52eb08..458eb7db32 100755 --- a/cmd/workspace/queries-legacy/queries-legacy.go +++ b/cmd/workspace/queries-legacy/queries-legacy.go @@ -68,7 +68,6 @@ func newCreate() *cobra.Command { var createReq sql.QueryPostContent var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -145,8 +144,6 @@ func newDelete() *cobra.Command { var deleteReq sql.DeleteQueriesLegacyRequest - // TODO: short flags - cmd.Use = "delete QUERY_ID" cmd.Short = `Delete a query.` cmd.Long = `Delete a query. @@ -219,8 +216,6 @@ func newGet() *cobra.Command { var getReq sql.GetQueriesLegacyRequest - // TODO: short flags - cmd.Use = "get QUERY_ID" cmd.Short = `Get a query definition.` cmd.Long = `Get a query definition. @@ -292,8 +287,6 @@ func newList() *cobra.Command { var listReq sql.ListQueriesLegacyRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.Order, "order", listReq.Order, `Name of query attribute to order by.`) cmd.Flags().IntVar(&listReq.Page, "page", listReq.Page, `Page number to retrieve.`) cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, `Number of queries to return per page.`) @@ -356,8 +349,6 @@ func newRestore() *cobra.Command { var restoreReq sql.RestoreQueriesLegacyRequest - // TODO: short flags - cmd.Use = "restore QUERY_ID" cmd.Short = `Restore a query.` cmd.Long = `Restore a query. @@ -430,7 +421,6 @@ func newUpdate() *cobra.Command { var updateReq sql.QueryEditContent var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.DataSourceId, "data-source-id", updateReq.DataSourceId, `Data source ID maps to the ID of the data source used by the resource and is distinct from the warehouse ID.`) diff --git a/cmd/workspace/queries/queries.go b/cmd/workspace/queries/queries.go index 68cb941a6f..3cca60bdb3 100755 --- a/cmd/workspace/queries/queries.go +++ b/cmd/workspace/queries/queries.go @@ -63,7 +63,6 @@ func newCreate() *cobra.Command { var createReq sql.CreateQueryRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&createReq.AutoResolveDisplayName, "auto-resolve-display-name", createReq.AutoResolveDisplayName, `If true, automatically resolve query display name conflicts.`) @@ -133,8 +132,6 @@ func newDelete() *cobra.Command { var deleteReq sql.TrashQueryRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete a query.` cmd.Long = `Delete a query. @@ -203,8 +200,6 @@ func newGet() *cobra.Command { var getReq sql.GetQueryRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get a query.` cmd.Long = `Get a query. @@ -270,8 +265,6 @@ func newList() *cobra.Command { var listReq sql.ListQueriesRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.PageSize, "page-size", listReq.PageSize, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -325,8 +318,6 @@ func newListVisualizations() *cobra.Command { var listVisualizationsReq sql.ListVisualizationsForQueryRequest - // TODO: short flags - cmd.Flags().IntVar(&listVisualizationsReq.PageSize, "page-size", listVisualizationsReq.PageSize, ``) cmd.Flags().StringVar(&listVisualizationsReq.PageToken, "page-token", listVisualizationsReq.PageToken, ``) @@ -396,7 +387,6 @@ func newUpdate() *cobra.Command { var updateReq sql.UpdateQueryRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&updateReq.AutoResolveDisplayName, "auto-resolve-display-name", updateReq.AutoResolveDisplayName, `If true, automatically resolve alert display name conflicts.`) diff --git a/cmd/workspace/query-history/query-history.go b/cmd/workspace/query-history/query-history.go index f37690589f..8854a0b236 100755 --- a/cmd/workspace/query-history/query-history.go +++ b/cmd/workspace/query-history/query-history.go @@ -52,8 +52,6 @@ func newList() *cobra.Command { var listReq sql.ListQueryHistoryRequest - // TODO: short flags - // TODO: complex arg: filter_by cmd.Flags().BoolVar(&listReq.IncludeMetrics, "include-metrics", listReq.IncludeMetrics, `Whether to include the query metrics with each query.`) cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Limit the number of results returned in one page.`) diff --git a/cmd/workspace/query-visualizations-legacy/query-visualizations-legacy.go b/cmd/workspace/query-visualizations-legacy/query-visualizations-legacy.go index c46ad0cb0a..f6281872ba 100755 --- a/cmd/workspace/query-visualizations-legacy/query-visualizations-legacy.go +++ b/cmd/workspace/query-visualizations-legacy/query-visualizations-legacy.go @@ -67,7 +67,6 @@ func newCreate() *cobra.Command { var createReq sql.CreateQueryVisualizationsLegacyRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -136,8 +135,6 @@ func newDelete() *cobra.Command { var deleteReq sql.DeleteQueryVisualizationsLegacyRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Remove visualization.` cmd.Long = `Remove visualization. @@ -200,7 +197,6 @@ func newUpdate() *cobra.Command { var updateReq sql.LegacyVisualization var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update ID" diff --git a/cmd/workspace/query-visualizations/query-visualizations.go b/cmd/workspace/query-visualizations/query-visualizations.go index 607daa0172..6bf80f27cf 100755 --- a/cmd/workspace/query-visualizations/query-visualizations.go +++ b/cmd/workspace/query-visualizations/query-visualizations.go @@ -62,7 +62,6 @@ func newCreate() *cobra.Command { var createReq sql.CreateVisualizationRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: visualization @@ -131,8 +130,6 @@ func newDelete() *cobra.Command { var deleteReq sql.DeleteVisualizationRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Remove a visualization.` cmd.Long = `Remove a visualization. @@ -187,7 +184,6 @@ func newUpdate() *cobra.Command { var updateReq sql.UpdateVisualizationRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: visualization diff --git a/cmd/workspace/recipient-activation/recipient-activation.go b/cmd/workspace/recipient-activation/recipient-activation.go index 880fdd8e91..65cd29868c 100755 --- a/cmd/workspace/recipient-activation/recipient-activation.go +++ b/cmd/workspace/recipient-activation/recipient-activation.go @@ -61,8 +61,6 @@ func newGetActivationUrlInfo() *cobra.Command { var getActivationUrlInfoReq sharing.GetActivationUrlInfoRequest - // TODO: short flags - cmd.Use = "get-activation-url-info ACTIVATION_URL" cmd.Short = `Get a share activation URL.` cmd.Long = `Get a share activation URL. @@ -119,8 +117,6 @@ func newRetrieveToken() *cobra.Command { var retrieveTokenReq sharing.RetrieveTokenRequest - // TODO: short flags - cmd.Use = "retrieve-token ACTIVATION_URL" cmd.Short = `Get an access token.` cmd.Long = `Get an access token. diff --git a/cmd/workspace/recipient-federation-policies/recipient-federation-policies.go b/cmd/workspace/recipient-federation-policies/recipient-federation-policies.go index 10585afba3..017e3f34de 100755 --- a/cmd/workspace/recipient-federation-policies/recipient-federation-policies.go +++ b/cmd/workspace/recipient-federation-policies/recipient-federation-policies.go @@ -85,7 +85,6 @@ func newCreate() *cobra.Command { createReq.Policy = sharing.FederationPolicy{} var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Policy.Comment, "comment", createReq.Policy.Comment, `Description of the policy.`) @@ -186,8 +185,6 @@ func newDelete() *cobra.Command { var deleteReq sharing.DeleteFederationPolicyRequest - // TODO: short flags - cmd.Use = "delete RECIPIENT_NAME NAME" cmd.Short = `Delete recipient federation policy.` cmd.Long = `Delete recipient federation policy. @@ -248,8 +245,6 @@ func newGetFederationPolicy() *cobra.Command { var getFederationPolicyReq sharing.GetFederationPolicyRequest - // TODO: short flags - cmd.Use = "get-federation-policy RECIPIENT_NAME NAME" cmd.Short = `Get recipient federation policy.` cmd.Long = `Get recipient federation policy. @@ -311,8 +306,6 @@ func newList() *cobra.Command { var listReq sharing.ListFederationPoliciesRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, ``) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, ``) @@ -374,7 +367,6 @@ func newUpdate() *cobra.Command { updateReq.Policy = sharing.FederationPolicy{} var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.UpdateMask, "update-mask", updateReq.UpdateMask, `The field mask specifies which fields of the policy to update.`) diff --git a/cmd/workspace/recipients/recipients.go b/cmd/workspace/recipients/recipients.go index 1864707766..df2fc1d932 100755 --- a/cmd/workspace/recipients/recipients.go +++ b/cmd/workspace/recipients/recipients.go @@ -77,7 +77,6 @@ func newCreate() *cobra.Command { var createReq sharing.CreateRecipient var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Comment, "comment", createReq.Comment, `Description about the recipient.`) @@ -175,8 +174,6 @@ func newDelete() *cobra.Command { var deleteReq sharing.DeleteRecipientRequest - // TODO: short flags - cmd.Use = "delete NAME" cmd.Short = `Delete a share recipient.` cmd.Long = `Delete a share recipient. @@ -234,8 +231,6 @@ func newGet() *cobra.Command { var getReq sharing.GetRecipientRequest - // TODO: short flags - cmd.Use = "get NAME" cmd.Short = `Get a share recipient.` cmd.Long = `Get a share recipient. @@ -294,8 +289,6 @@ func newList() *cobra.Command { var listReq sharing.ListRecipientsRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.DataRecipientGlobalMetastoreId, "data-recipient-global-metastore-id", listReq.DataRecipientGlobalMetastoreId, `If not provided, all recipients will be returned.`) cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of recipients to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -352,7 +345,6 @@ func newRotateToken() *cobra.Command { var rotateTokenReq sharing.RotateRecipientToken var rotateTokenJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&rotateTokenJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "rotate-token NAME EXISTING_TOKEN_EXPIRE_IN_SECONDS" @@ -441,8 +433,6 @@ func newSharePermissions() *cobra.Command { var sharePermissionsReq sharing.SharePermissionsRequest - // TODO: short flags - cmd.Flags().IntVar(&sharePermissionsReq.MaxResults, "max-results", sharePermissionsReq.MaxResults, `Maximum number of permissions to return.`) cmd.Flags().StringVar(&sharePermissionsReq.PageToken, "page-token", sharePermissionsReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -504,7 +494,6 @@ func newUpdate() *cobra.Command { var updateReq sharing.UpdateRecipient var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Comment, "comment", updateReq.Comment, `Description about the recipient.`) diff --git a/cmd/workspace/registered-models/registered-models.go b/cmd/workspace/registered-models/registered-models.go index b327444e60..f98ce48fdc 100755 --- a/cmd/workspace/registered-models/registered-models.go +++ b/cmd/workspace/registered-models/registered-models.go @@ -89,7 +89,6 @@ func newCreate() *cobra.Command { var createReq catalog.CreateRegisteredModelRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Comment, "comment", createReq.Comment, `The comment attached to the registered model.`) @@ -191,8 +190,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteRegisteredModelRequest - // TODO: short flags - cmd.Use = "delete FULL_NAME" cmd.Short = `Delete a Registered Model.` cmd.Long = `Delete a Registered Model. @@ -267,8 +264,6 @@ func newDeleteAlias() *cobra.Command { var deleteAliasReq catalog.DeleteAliasRequest - // TODO: short flags - cmd.Use = "delete-alias FULL_NAME ALIAS" cmd.Short = `Delete a Registered Model Alias.` cmd.Long = `Delete a Registered Model Alias. @@ -332,8 +327,6 @@ func newGet() *cobra.Command { var getReq catalog.GetRegisteredModelRequest - // TODO: short flags - cmd.Flags().BoolVar(&getReq.IncludeAliases, "include-aliases", getReq.IncludeAliases, `Whether to include registered model aliases in the response.`) cmd.Flags().BoolVar(&getReq.IncludeBrowse, "include-browse", getReq.IncludeBrowse, `Whether to include registered models in the response for which the principal can only access selective metadata for.`) @@ -410,8 +403,6 @@ func newList() *cobra.Command { var listReq catalog.ListRegisteredModelsRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.CatalogName, "catalog-name", listReq.CatalogName, `The identifier of the catalog under which to list registered models.`) cmd.Flags().BoolVar(&listReq.IncludeBrowse, "include-browse", listReq.IncludeBrowse, `Whether to include registered models in the response for which the principal can only access selective metadata for.`) cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Max number of registered models to return.`) @@ -478,7 +469,6 @@ func newSetAlias() *cobra.Command { var setAliasReq catalog.SetRegisteredModelAliasRequest var setAliasJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setAliasJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "set-alias FULL_NAME ALIAS VERSION_NUM" @@ -571,7 +561,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdateRegisteredModelRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Comment, "comment", updateReq.Comment, `The comment attached to the registered model.`) diff --git a/cmd/workspace/repos/repos.go b/cmd/workspace/repos/repos.go index 547afb97f1..9c36e0a737 100755 --- a/cmd/workspace/repos/repos.go +++ b/cmd/workspace/repos/repos.go @@ -72,7 +72,6 @@ func newCreate() *cobra.Command { var createReq workspace.CreateRepoRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Path, "path", createReq.Path, `Desired path for the repo in the workspace.`) @@ -164,8 +163,6 @@ func newDelete() *cobra.Command { var deleteReq workspace.DeleteRepoRequest - // TODO: short flags - cmd.Use = "delete REPO_ID" cmd.Short = `Delete a repo.` cmd.Long = `Delete a repo. @@ -237,8 +234,6 @@ func newGet() *cobra.Command { var getReq workspace.GetRepoRequest - // TODO: short flags - cmd.Use = "get REPO_ID" cmd.Short = `Get a repo.` cmd.Long = `Get a repo. @@ -310,8 +305,6 @@ func newGetPermissionLevels() *cobra.Command { var getPermissionLevelsReq workspace.GetRepoPermissionLevelsRequest - // TODO: short flags - cmd.Use = "get-permission-levels REPO_ID" cmd.Short = `Get repo permission levels.` cmd.Long = `Get repo permission levels. @@ -380,8 +373,6 @@ func newGetPermissions() *cobra.Command { var getPermissionsReq workspace.GetRepoPermissionsRequest - // TODO: short flags - cmd.Use = "get-permissions REPO_ID" cmd.Short = `Get repo permissions.` cmd.Long = `Get repo permissions. @@ -451,8 +442,6 @@ func newList() *cobra.Command { var listReq workspace.ListReposRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.NextPageToken, "next-page-token", listReq.NextPageToken, `Token used to get the next page of results.`) cmd.Flags().StringVar(&listReq.PathPrefix, "path-prefix", listReq.PathPrefix, `Filters repos that have paths starting with the given path prefix.`) @@ -506,7 +495,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq workspace.RepoPermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -594,7 +582,6 @@ func newUpdate() *cobra.Command { var updateReq workspace.UpdateRepoRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Branch, "branch", updateReq.Branch, `Branch that the local version of the repo is checked out to.`) @@ -686,7 +673,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq workspace.RepoPermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list diff --git a/cmd/workspace/resource-quotas/resource-quotas.go b/cmd/workspace/resource-quotas/resource-quotas.go index 992fee623d..61101d0526 100755 --- a/cmd/workspace/resource-quotas/resource-quotas.go +++ b/cmd/workspace/resource-quotas/resource-quotas.go @@ -59,8 +59,6 @@ func newGetQuota() *cobra.Command { var getQuotaReq catalog.GetQuotaRequest - // TODO: short flags - cmd.Use = "get-quota PARENT_SECURABLE_TYPE PARENT_FULL_NAME QUOTA_NAME" cmd.Short = `Get information for a single resource quota.` cmd.Long = `Get information for a single resource quota. @@ -126,8 +124,6 @@ func newListQuotas() *cobra.Command { var listQuotasReq catalog.ListQuotasRequest - // TODO: short flags - cmd.Flags().IntVar(&listQuotasReq.MaxResults, "max-results", listQuotasReq.MaxResults, `The number of quotas to return.`) cmd.Flags().StringVar(&listQuotasReq.PageToken, "page-token", listQuotasReq.PageToken, `Opaque token for the next page of results.`) diff --git a/cmd/workspace/restrict-workspace-admins/restrict-workspace-admins.go b/cmd/workspace/restrict-workspace-admins/restrict-workspace-admins.go index d10be8e12b..77cb09a28e 100755 --- a/cmd/workspace/restrict-workspace-admins/restrict-workspace-admins.go +++ b/cmd/workspace/restrict-workspace-admins/restrict-workspace-admins.go @@ -63,8 +63,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteRestrictWorkspaceAdminsSettingRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteReq.Etag, "etag", deleteReq.Etag, `etag used for versioning.`) cmd.Use = "delete" @@ -122,8 +120,6 @@ func newGet() *cobra.Command { var getReq settings.GetRestrictWorkspaceAdminsSettingRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -178,7 +174,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateRestrictWorkspaceAdminsSettingRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/workspace/schemas/schemas.go b/cmd/workspace/schemas/schemas.go index 9c3425d6b1..88de79d7ea 100755 --- a/cmd/workspace/schemas/schemas.go +++ b/cmd/workspace/schemas/schemas.go @@ -63,7 +63,6 @@ func newCreate() *cobra.Command { var createReq catalog.CreateSchema var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Comment, "comment", createReq.Comment, `User-provided free-form text description.`) @@ -153,8 +152,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteSchemaRequest - // TODO: short flags - cmd.Flags().BoolVar(&deleteReq.Force, "force", deleteReq.Force, `Force deletion even if the schema is not empty.`) cmd.Use = "delete FULL_NAME" @@ -214,8 +211,6 @@ func newGet() *cobra.Command { var getReq catalog.GetSchemaRequest - // TODO: short flags - cmd.Flags().BoolVar(&getReq.IncludeBrowse, "include-browse", getReq.IncludeBrowse, `Whether to include schemas in the response for which the principal can only access selective metadata for.`) cmd.Use = "get FULL_NAME" @@ -276,8 +271,6 @@ func newList() *cobra.Command { var listReq catalog.ListSchemasRequest - // TODO: short flags - cmd.Flags().BoolVar(&listReq.IncludeBrowse, "include-browse", listReq.IncludeBrowse, `Whether to include schemas in the response for which the principal can only access selective metadata for.`) cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of schemas to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -340,7 +333,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdateSchema var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Comment, "comment", updateReq.Comment, `User-provided free-form text description.`) diff --git a/cmd/workspace/secrets/secrets.go b/cmd/workspace/secrets/secrets.go index 2e882ad94e..fff209e13c 100755 --- a/cmd/workspace/secrets/secrets.go +++ b/cmd/workspace/secrets/secrets.go @@ -75,7 +75,6 @@ func newCreateScope() *cobra.Command { var createScopeReq workspace.CreateScope var createScopeJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createScopeJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: backend_azure_keyvault @@ -161,7 +160,6 @@ func newDeleteAcl() *cobra.Command { var deleteAclReq workspace.DeleteAcl var deleteAclJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteAclJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "delete-acl SCOPE PRINCIPAL" @@ -251,7 +249,6 @@ func newDeleteScope() *cobra.Command { var deleteScopeReq workspace.DeleteScope var deleteScopeJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteScopeJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "delete-scope SCOPE" @@ -336,7 +333,6 @@ func newDeleteSecret() *cobra.Command { var deleteSecretReq workspace.DeleteSecret var deleteSecretJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteSecretJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "delete-secret SCOPE KEY" @@ -425,8 +421,6 @@ func newGetAcl() *cobra.Command { var getAclReq workspace.GetAclRequest - // TODO: short flags - cmd.Use = "get-acl SCOPE PRINCIPAL" cmd.Short = `Get secret ACL details.` cmd.Long = `Get secret ACL details. @@ -490,8 +484,6 @@ func newGetSecret() *cobra.Command { var getSecretReq workspace.GetSecretRequest - // TODO: short flags - cmd.Use = "get-secret SCOPE KEY" cmd.Short = `Get a secret.` cmd.Long = `Get a secret. @@ -561,8 +553,6 @@ func newListAcls() *cobra.Command { var listAclsReq workspace.ListAclsRequest - // TODO: short flags - cmd.Use = "list-acls SCOPE" cmd.Short = `Lists ACLs.` cmd.Long = `Lists ACLs. @@ -663,8 +653,6 @@ func newListSecrets() *cobra.Command { var listSecretsReq workspace.ListSecretsRequest - // TODO: short flags - cmd.Use = "list-secrets SCOPE" cmd.Short = `List secret keys.` cmd.Long = `List secret keys. @@ -726,7 +714,6 @@ func newPutAcl() *cobra.Command { var putAclReq workspace.PutAcl var putAclJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&putAclJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "put-acl SCOPE PRINCIPAL PERMISSION" diff --git a/cmd/workspace/service-principals/service-principals.go b/cmd/workspace/service-principals/service-principals.go index a7c25f93a4..628d7fd49d 100755 --- a/cmd/workspace/service-principals/service-principals.go +++ b/cmd/workspace/service-principals/service-principals.go @@ -65,7 +65,6 @@ func newCreate() *cobra.Command { var createReq iam.ServicePrincipal var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&createReq.Active, "active", createReq.Active, `If this user is active.`) @@ -142,8 +141,6 @@ func newDelete() *cobra.Command { var deleteReq iam.DeleteServicePrincipalRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete a service principal.` cmd.Long = `Delete a service principal. @@ -212,8 +209,6 @@ func newGet() *cobra.Command { var getReq iam.GetServicePrincipalRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get service principal details.` cmd.Long = `Get service principal details. @@ -283,8 +278,6 @@ func newList() *cobra.Command { var listReq iam.ListServicePrincipalsRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.Attributes, "attributes", listReq.Attributes, `Comma-separated list of attributes to return in response.`) cmd.Flags().Int64Var(&listReq.Count, "count", listReq.Count, `Desired number of results per page.`) cmd.Flags().StringVar(&listReq.ExcludedAttributes, "excluded-attributes", listReq.ExcludedAttributes, `Comma-separated list of attributes to exclude in response.`) @@ -342,7 +335,6 @@ func newPatch() *cobra.Command { var patchReq iam.PartialUpdate var patchJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&patchJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: Operations @@ -430,7 +422,6 @@ func newUpdate() *cobra.Command { var updateReq iam.ServicePrincipal var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&updateReq.Active, "active", updateReq.Active, `If this user is active.`) diff --git a/cmd/workspace/serving-endpoints/serving-endpoints.go b/cmd/workspace/serving-endpoints/serving-endpoints.go index 29f94f6036..3542d92c53 100755 --- a/cmd/workspace/serving-endpoints/serving-endpoints.go +++ b/cmd/workspace/serving-endpoints/serving-endpoints.go @@ -86,8 +86,6 @@ func newBuildLogs() *cobra.Command { var buildLogsReq serving.BuildLogsRequest - // TODO: short flags - cmd.Use = "build-logs NAME SERVED_MODEL_NAME" cmd.Short = `Get build logs for a served model.` cmd.Long = `Get build logs for a served model. @@ -154,7 +152,7 @@ func newCreate() *cobra.Command { cmd.Flags().BoolVar(&createSkipWait, "no-wait", createSkipWait, `do not wait to reach NOT_UPDATING state`) cmd.Flags().DurationVar(&createTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach NOT_UPDATING state`) - // TODO: short flags + cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: ai_gateway @@ -260,7 +258,7 @@ func newCreateProvisionedThroughputEndpoint() *cobra.Command { cmd.Flags().BoolVar(&createProvisionedThroughputEndpointSkipWait, "no-wait", createProvisionedThroughputEndpointSkipWait, `do not wait to reach NOT_UPDATING state`) cmd.Flags().DurationVar(&createProvisionedThroughputEndpointTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach NOT_UPDATING state`) - // TODO: short flags + cmd.Flags().Var(&createProvisionedThroughputEndpointJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: ai_gateway @@ -339,8 +337,6 @@ func newDelete() *cobra.Command { var deleteReq serving.DeleteServingEndpointRequest - // TODO: short flags - cmd.Use = "delete NAME" cmd.Short = `Delete a serving endpoint.` cmd.Long = `Delete a serving endpoint.` @@ -392,8 +388,6 @@ func newExportMetrics() *cobra.Command { var exportMetricsReq serving.ExportMetricsRequest - // TODO: short flags - cmd.Use = "export-metrics NAME" cmd.Short = `Get metrics of a serving endpoint.` cmd.Long = `Get metrics of a serving endpoint. @@ -453,8 +447,6 @@ func newGet() *cobra.Command { var getReq serving.GetServingEndpointRequest - // TODO: short flags - cmd.Use = "get NAME" cmd.Short = `Get a single serving endpoint.` cmd.Long = `Get a single serving endpoint. @@ -511,8 +503,6 @@ func newGetOpenApi() *cobra.Command { var getOpenApiReq serving.GetOpenApiRequest - // TODO: short flags - cmd.Use = "get-open-api NAME" cmd.Short = `Get the schema for a serving endpoint.` cmd.Long = `Get the schema for a serving endpoint. @@ -573,8 +563,6 @@ func newGetPermissionLevels() *cobra.Command { var getPermissionLevelsReq serving.GetServingEndpointPermissionLevelsRequest - // TODO: short flags - cmd.Use = "get-permission-levels SERVING_ENDPOINT_ID" cmd.Short = `Get serving endpoint permission levels.` cmd.Long = `Get serving endpoint permission levels. @@ -631,8 +619,6 @@ func newGetPermissions() *cobra.Command { var getPermissionsReq serving.GetServingEndpointPermissionsRequest - // TODO: short flags - cmd.Use = "get-permissions SERVING_ENDPOINT_ID" cmd.Short = `Get serving endpoint permissions.` cmd.Long = `Get serving endpoint permissions. @@ -690,8 +676,6 @@ func newHttpRequest() *cobra.Command { var httpRequestReq serving.ExternalFunctionRequest - // TODO: short flags - cmd.Flags().StringVar(&httpRequestReq.Headers, "headers", httpRequestReq.Headers, `Additional headers for the request.`) cmd.Flags().StringVar(&httpRequestReq.Json, "json", httpRequestReq.Json, `The JSON payload to send in the request body.`) cmd.Flags().StringVar(&httpRequestReq.Params, "params", httpRequestReq.Params, `Query parameters for the request.`) @@ -800,8 +784,6 @@ func newLogs() *cobra.Command { var logsReq serving.LogsRequest - // TODO: short flags - cmd.Use = "logs NAME SERVED_MODEL_NAME" cmd.Short = `Get the latest logs for a served model.` cmd.Long = `Get the latest logs for a served model. @@ -863,7 +845,6 @@ func newPatch() *cobra.Command { var patchReq serving.PatchServingEndpointTags var patchJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&patchJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: add_tags @@ -940,7 +921,6 @@ func newPut() *cobra.Command { var putReq serving.PutRequest var putJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&putJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: rate_limits @@ -1015,7 +995,6 @@ func newPutAiGateway() *cobra.Command { var putAiGatewayReq serving.PutAiGatewayRequest var putAiGatewayJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&putAiGatewayJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: fallback_config @@ -1096,7 +1075,6 @@ func newQuery() *cobra.Command { var queryReq serving.QueryEndpointInput var queryJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&queryJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: dataframe_records @@ -1180,7 +1158,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq serving.ServingEndpointPermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -1261,7 +1238,7 @@ func newUpdateConfig() *cobra.Command { cmd.Flags().BoolVar(&updateConfigSkipWait, "no-wait", updateConfigSkipWait, `do not wait to reach NOT_UPDATING state`) cmd.Flags().DurationVar(&updateConfigTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach NOT_UPDATING state`) - // TODO: short flags + cmd.Flags().Var(&updateConfigJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: auto_capture_config @@ -1354,7 +1331,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq serving.ServingEndpointPermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -1434,7 +1410,7 @@ func newUpdateProvisionedThroughputEndpointConfig() *cobra.Command { cmd.Flags().BoolVar(&updateProvisionedThroughputEndpointConfigSkipWait, "no-wait", updateProvisionedThroughputEndpointConfigSkipWait, `do not wait to reach NOT_UPDATING state`) cmd.Flags().DurationVar(&updateProvisionedThroughputEndpointConfigTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach NOT_UPDATING state`) - // TODO: short flags + cmd.Flags().Var(&updateProvisionedThroughputEndpointConfigJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update-provisioned-throughput-endpoint-config NAME" diff --git a/cmd/workspace/shares/shares.go b/cmd/workspace/shares/shares.go index 687aa17acc..4a5aa282b1 100755 --- a/cmd/workspace/shares/shares.go +++ b/cmd/workspace/shares/shares.go @@ -65,7 +65,6 @@ func newCreate() *cobra.Command { var createReq sharing.CreateShare var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Comment, "comment", createReq.Comment, `User-provided free-form text description.`) @@ -150,8 +149,6 @@ func newDelete() *cobra.Command { var deleteReq sharing.DeleteShareRequest - // TODO: short flags - cmd.Use = "delete NAME" cmd.Short = `Delete a share.` cmd.Long = `Delete a share. @@ -209,8 +206,6 @@ func newGet() *cobra.Command { var getReq sharing.GetShareRequest - // TODO: short flags - cmd.Flags().BoolVar(&getReq.IncludeSharedData, "include-shared-data", getReq.IncludeSharedData, `Query for data to include in the share.`) cmd.Use = "get NAME" @@ -270,8 +265,6 @@ func newList() *cobra.Command { var listReq sharing.ListSharesRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of shares to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -325,8 +318,6 @@ func newSharePermissions() *cobra.Command { var sharePermissionsReq sharing.SharePermissionsRequest - // TODO: short flags - cmd.Flags().IntVar(&sharePermissionsReq.MaxResults, "max-results", sharePermissionsReq.MaxResults, `Maximum number of permissions to return.`) cmd.Flags().StringVar(&sharePermissionsReq.PageToken, "page-token", sharePermissionsReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -388,7 +379,6 @@ func newUpdate() *cobra.Command { var updateReq sharing.UpdateShare var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Comment, "comment", updateReq.Comment, `User-provided free-form text description.`) @@ -482,7 +472,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq sharing.UpdateSharePermissions var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: changes diff --git a/cmd/workspace/sql-results-download/sql-results-download.go b/cmd/workspace/sql-results-download/sql-results-download.go index b807a767a2..e96170fbea 100755 --- a/cmd/workspace/sql-results-download/sql-results-download.go +++ b/cmd/workspace/sql-results-download/sql-results-download.go @@ -54,8 +54,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteSqlResultsDownloadRequest - // TODO: short flags - cmd.Flags().StringVar(&deleteReq.Etag, "etag", deleteReq.Etag, `etag used for versioning.`) cmd.Use = "delete" @@ -109,8 +107,6 @@ func newGet() *cobra.Command { var getReq settings.GetSqlResultsDownloadRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) cmd.Use = "get" @@ -165,7 +161,6 @@ func newUpdate() *cobra.Command { var updateReq settings.UpdateSqlResultsDownloadRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update" diff --git a/cmd/workspace/storage-credentials/storage-credentials.go b/cmd/workspace/storage-credentials/storage-credentials.go index 47d487e86e..483a0155e6 100755 --- a/cmd/workspace/storage-credentials/storage-credentials.go +++ b/cmd/workspace/storage-credentials/storage-credentials.go @@ -72,7 +72,6 @@ func newCreate() *cobra.Command { var createReq catalog.CreateStorageCredential var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: aws_iam_role @@ -165,8 +164,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteStorageCredentialRequest - // TODO: short flags - cmd.Flags().BoolVar(&deleteReq.Force, "force", deleteReq.Force, `Force an update even if there are dependent external locations or external tables (when purpose is **STORAGE**) or dependent services (when purpose is **SERVICE**).`) cmd.Use = "delete NAME" @@ -226,8 +223,6 @@ func newGet() *cobra.Command { var getReq catalog.GetStorageCredentialRequest - // TODO: short flags - cmd.Use = "get NAME" cmd.Short = `Get a credential.` cmd.Long = `Get a credential. @@ -286,8 +281,6 @@ func newList() *cobra.Command { var listReq catalog.ListStorageCredentialsRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of storage credentials to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -344,7 +337,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdateStorageCredential var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: aws_iam_role @@ -432,7 +424,6 @@ func newValidate() *cobra.Command { var validateReq catalog.ValidateStorageCredential var validateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&validateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: aws_iam_role diff --git a/cmd/workspace/system-schemas/system-schemas.go b/cmd/workspace/system-schemas/system-schemas.go index f9d9197b1d..e88ee60489 100755 --- a/cmd/workspace/system-schemas/system-schemas.go +++ b/cmd/workspace/system-schemas/system-schemas.go @@ -56,8 +56,6 @@ func newDisable() *cobra.Command { var disableReq catalog.DisableRequest - // TODO: short flags - cmd.Use = "disable METASTORE_ID SCHEMA_NAME" cmd.Short = `Disable a system schema.` cmd.Long = `Disable a system schema. @@ -118,7 +116,6 @@ func newEnable() *cobra.Command { var enableReq catalog.EnableRequest var enableJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&enableJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&enableReq.CatalogName, "catalog-name", enableReq.CatalogName, `the catalog for which the system schema is to enabled in.`) @@ -194,8 +191,6 @@ func newList() *cobra.Command { var listReq catalog.ListSystemSchemasRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of schemas to return.`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) diff --git a/cmd/workspace/table-constraints/table-constraints.go b/cmd/workspace/table-constraints/table-constraints.go index d5e60e2b01..0034037fcb 100755 --- a/cmd/workspace/table-constraints/table-constraints.go +++ b/cmd/workspace/table-constraints/table-constraints.go @@ -68,7 +68,6 @@ func newCreate() *cobra.Command { var createReq catalog.CreateTableConstraint var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "create" @@ -141,8 +140,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteTableConstraintRequest - // TODO: short flags - cmd.Use = "delete FULL_NAME CONSTRAINT_NAME CASCADE" cmd.Short = `Delete a table constraint.` cmd.Long = `Delete a table constraint. diff --git a/cmd/workspace/tables/tables.go b/cmd/workspace/tables/tables.go index 7b980a6169..c1068fc691 100755 --- a/cmd/workspace/tables/tables.go +++ b/cmd/workspace/tables/tables.go @@ -67,8 +67,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteTableRequest - // TODO: short flags - cmd.Use = "delete FULL_NAME" cmd.Short = `Delete a table.` cmd.Long = `Delete a table. @@ -141,8 +139,6 @@ func newExists() *cobra.Command { var existsReq catalog.ExistsRequest - // TODO: short flags - cmd.Use = "exists FULL_NAME" cmd.Short = `Get boolean reflecting if table exists.` cmd.Long = `Get boolean reflecting if table exists. @@ -218,8 +214,6 @@ func newGet() *cobra.Command { var getReq catalog.GetTableRequest - // TODO: short flags - cmd.Flags().BoolVar(&getReq.IncludeBrowse, "include-browse", getReq.IncludeBrowse, `Whether to include tables in the response for which the principal can only access selective metadata for.`) cmd.Flags().BoolVar(&getReq.IncludeDeltaMetadata, "include-delta-metadata", getReq.IncludeDeltaMetadata, `Whether delta metadata should be included in the response.`) cmd.Flags().BoolVar(&getReq.IncludeManifestCapabilities, "include-manifest-capabilities", getReq.IncludeManifestCapabilities, `Whether to include a manifest containing capabilities the table has.`) @@ -298,8 +292,6 @@ func newList() *cobra.Command { var listReq catalog.ListTablesRequest - // TODO: short flags - cmd.Flags().BoolVar(&listReq.IncludeBrowse, "include-browse", listReq.IncludeBrowse, `Whether to include tables in the response for which the principal can only access selective metadata for.`) cmd.Flags().BoolVar(&listReq.IncludeDeltaMetadata, "include-delta-metadata", listReq.IncludeDeltaMetadata, `Whether delta metadata should be included in the response.`) cmd.Flags().BoolVar(&listReq.IncludeManifestCapabilities, "include-manifest-capabilities", listReq.IncludeManifestCapabilities, `Whether to include a manifest containing capabilities the table has.`) @@ -369,8 +361,6 @@ func newListSummaries() *cobra.Command { var listSummariesReq catalog.ListSummariesRequest - // TODO: short flags - cmd.Flags().BoolVar(&listSummariesReq.IncludeManifestCapabilities, "include-manifest-capabilities", listSummariesReq.IncludeManifestCapabilities, `Whether to include a manifest containing capabilities the table has.`) cmd.Flags().IntVar(&listSummariesReq.MaxResults, "max-results", listSummariesReq.MaxResults, `Maximum number of summaries for tables to return.`) cmd.Flags().StringVar(&listSummariesReq.PageToken, "page-token", listSummariesReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -453,7 +443,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdateTableRequest var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Owner, "owner", updateReq.Owner, ``) diff --git a/cmd/workspace/temporary-table-credentials/temporary-table-credentials.go b/cmd/workspace/temporary-table-credentials/temporary-table-credentials.go index a3b4e79de8..130737ff0b 100755 --- a/cmd/workspace/temporary-table-credentials/temporary-table-credentials.go +++ b/cmd/workspace/temporary-table-credentials/temporary-table-credentials.go @@ -68,7 +68,6 @@ func newGenerateTemporaryTableCredentials() *cobra.Command { var generateTemporaryTableCredentialsReq catalog.GenerateTemporaryTableCredentialRequest var generateTemporaryTableCredentialsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&generateTemporaryTableCredentialsJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().Var(&generateTemporaryTableCredentialsReq.Operation, "operation", `The operation performed against the table data, either READ or READ_WRITE. Supported values: [READ, READ_WRITE]`) diff --git a/cmd/workspace/token-management/token-management.go b/cmd/workspace/token-management/token-management.go index 6d6a54dad3..f7a02d091c 100755 --- a/cmd/workspace/token-management/token-management.go +++ b/cmd/workspace/token-management/token-management.go @@ -64,7 +64,6 @@ func newCreateOboToken() *cobra.Command { var createOboTokenReq settings.CreateOboTokenRequest var createOboTokenJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createOboTokenJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createOboTokenReq.Comment, "comment", createOboTokenReq.Comment, `Comment that describes the purpose of the token.`) @@ -162,8 +161,6 @@ func newDelete() *cobra.Command { var deleteReq settings.DeleteTokenManagementRequest - // TODO: short flags - cmd.Use = "delete TOKEN_ID" cmd.Short = `Delete a token.` cmd.Long = `Delete a token. @@ -232,8 +229,6 @@ func newGet() *cobra.Command { var getReq settings.GetTokenManagementRequest - // TODO: short flags - cmd.Use = "get TOKEN_ID" cmd.Short = `Get token info.` cmd.Long = `Get token info. @@ -387,8 +382,6 @@ func newList() *cobra.Command { var listReq settings.ListTokenManagementRequest - // TODO: short flags - cmd.Flags().Int64Var(&listReq.CreatedById, "created-by-id", listReq.CreatedById, `User ID of the user that created the token.`) cmd.Flags().StringVar(&listReq.CreatedByUsername, "created-by-username", listReq.CreatedByUsername, `Username of the user that created the token.`) @@ -441,7 +434,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq settings.TokenPermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -513,7 +505,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq settings.TokenPermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list diff --git a/cmd/workspace/tokens/tokens.go b/cmd/workspace/tokens/tokens.go index cae8eab72e..52d3390efb 100755 --- a/cmd/workspace/tokens/tokens.go +++ b/cmd/workspace/tokens/tokens.go @@ -58,7 +58,6 @@ func newCreate() *cobra.Command { var createReq settings.CreateTokenRequest var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Comment, "comment", createReq.Comment, `Optional description to attach to the token.`) @@ -132,7 +131,6 @@ func newDelete() *cobra.Command { var deleteReq settings.RevokeTokenRequest var deleteJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "delete TOKEN_ID" diff --git a/cmd/workspace/users/users.go b/cmd/workspace/users/users.go index 03d924d2a9..da1c58df99 100755 --- a/cmd/workspace/users/users.go +++ b/cmd/workspace/users/users.go @@ -74,7 +74,6 @@ func newCreate() *cobra.Command { var createReq iam.User var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&createReq.Active, "active", createReq.Active, `If this user is active.`) @@ -154,8 +153,6 @@ func newDelete() *cobra.Command { var deleteReq iam.DeleteUserRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete a user.` cmd.Long = `Delete a user. @@ -225,8 +222,6 @@ func newGet() *cobra.Command { var getReq iam.GetUserRequest - // TODO: short flags - cmd.Flags().StringVar(&getReq.Attributes, "attributes", getReq.Attributes, `Comma-separated list of attributes to return in response.`) cmd.Flags().IntVar(&getReq.Count, "count", getReq.Count, `Desired number of results per page.`) cmd.Flags().StringVar(&getReq.ExcludedAttributes, "excluded-attributes", getReq.ExcludedAttributes, `Comma-separated list of attributes to exclude in response.`) @@ -388,8 +383,6 @@ func newList() *cobra.Command { var listReq iam.ListUsersRequest - // TODO: short flags - cmd.Flags().StringVar(&listReq.Attributes, "attributes", listReq.Attributes, `Comma-separated list of attributes to return in response.`) cmd.Flags().Int64Var(&listReq.Count, "count", listReq.Count, `Desired number of results per page.`) cmd.Flags().StringVar(&listReq.ExcludedAttributes, "excluded-attributes", listReq.ExcludedAttributes, `Comma-separated list of attributes to exclude in response.`) @@ -447,7 +440,6 @@ func newPatch() *cobra.Command { var patchReq iam.PartialUpdate var patchJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&patchJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: Operations @@ -535,7 +527,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq iam.PasswordPermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -607,7 +598,6 @@ func newUpdate() *cobra.Command { var updateReq iam.User var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&updateReq.Active, "active", updateReq.Active, `If this user is active.`) @@ -703,7 +693,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq iam.PasswordPermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list diff --git a/cmd/workspace/vector-search-endpoints/vector-search-endpoints.go b/cmd/workspace/vector-search-endpoints/vector-search-endpoints.go index f8b848bbae..f74775a03f 100755 --- a/cmd/workspace/vector-search-endpoints/vector-search-endpoints.go +++ b/cmd/workspace/vector-search-endpoints/vector-search-endpoints.go @@ -66,7 +66,7 @@ func newCreateEndpoint() *cobra.Command { cmd.Flags().BoolVar(&createEndpointSkipWait, "no-wait", createEndpointSkipWait, `do not wait to reach ONLINE state`) cmd.Flags().DurationVar(&createEndpointTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach ONLINE state`) - // TODO: short flags + cmd.Flags().Var(&createEndpointJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createEndpointReq.BudgetPolicyId, "budget-policy-id", createEndpointReq.BudgetPolicyId, `The budget policy id to be applied.`) @@ -175,8 +175,6 @@ func newDeleteEndpoint() *cobra.Command { var deleteEndpointReq vectorsearch.DeleteEndpointRequest - // TODO: short flags - cmd.Use = "delete-endpoint ENDPOINT_NAME" cmd.Short = `Delete an endpoint.` cmd.Long = `Delete an endpoint. @@ -233,8 +231,6 @@ func newGetEndpoint() *cobra.Command { var getEndpointReq vectorsearch.GetEndpointRequest - // TODO: short flags - cmd.Use = "get-endpoint ENDPOINT_NAME" cmd.Short = `Get an endpoint.` cmd.Long = `Get an endpoint. @@ -291,8 +287,6 @@ func newListEndpoints() *cobra.Command { var listEndpointsReq vectorsearch.ListEndpointsRequest - // TODO: short flags - cmd.Flags().StringVar(&listEndpointsReq.PageToken, "page-token", listEndpointsReq.PageToken, `Token for pagination.`) cmd.Use = "list-endpoints" @@ -344,7 +338,6 @@ func newUpdateEndpointBudgetPolicy() *cobra.Command { var updateEndpointBudgetPolicyReq vectorsearch.PatchEndpointBudgetPolicyRequest var updateEndpointBudgetPolicyJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateEndpointBudgetPolicyJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update-endpoint-budget-policy ENDPOINT_NAME BUDGET_POLICY_ID" @@ -427,7 +420,6 @@ func newUpdateEndpointCustomTags() *cobra.Command { var updateEndpointCustomTagsReq vectorsearch.UpdateEndpointCustomTagsRequest var updateEndpointCustomTagsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateEndpointCustomTagsJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "update-endpoint-custom-tags ENDPOINT_NAME" diff --git a/cmd/workspace/vector-search-indexes/vector-search-indexes.go b/cmd/workspace/vector-search-indexes/vector-search-indexes.go index 37be0bfe3d..9e88ed1ebd 100755 --- a/cmd/workspace/vector-search-indexes/vector-search-indexes.go +++ b/cmd/workspace/vector-search-indexes/vector-search-indexes.go @@ -72,7 +72,6 @@ func newCreateIndex() *cobra.Command { var createIndexReq vectorsearch.CreateVectorIndexRequest var createIndexJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createIndexJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: delta_sync_index_spec @@ -177,7 +176,6 @@ func newDeleteDataVectorIndex() *cobra.Command { var deleteDataVectorIndexReq vectorsearch.DeleteDataVectorIndexRequest var deleteDataVectorIndexJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteDataVectorIndexJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "delete-data-vector-index INDEX_NAME" @@ -251,8 +249,6 @@ func newDeleteIndex() *cobra.Command { var deleteIndexReq vectorsearch.DeleteIndexRequest - // TODO: short flags - cmd.Use = "delete-index INDEX_NAME" cmd.Short = `Delete an index.` cmd.Long = `Delete an index. @@ -307,8 +303,6 @@ func newGetIndex() *cobra.Command { var getIndexReq vectorsearch.GetIndexRequest - // TODO: short flags - cmd.Use = "get-index INDEX_NAME" cmd.Short = `Get an index.` cmd.Long = `Get an index. @@ -363,8 +357,6 @@ func newListIndexes() *cobra.Command { var listIndexesReq vectorsearch.ListIndexesRequest - // TODO: short flags - cmd.Flags().StringVar(&listIndexesReq.PageToken, "page-token", listIndexesReq.PageToken, `Token for pagination.`) cmd.Use = "list-indexes ENDPOINT_NAME" @@ -421,7 +413,6 @@ func newQueryIndex() *cobra.Command { var queryIndexReq vectorsearch.QueryVectorIndexRequest var queryIndexJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&queryIndexJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: columns_to_rerank @@ -503,7 +494,6 @@ func newQueryNextPage() *cobra.Command { var queryNextPageReq vectorsearch.QueryVectorIndexNextPageRequest var queryNextPageJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&queryNextPageJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&queryNextPageReq.EndpointName, "endpoint-name", queryNextPageReq.EndpointName, `Name of the endpoint.`) @@ -579,7 +569,6 @@ func newScanIndex() *cobra.Command { var scanIndexReq vectorsearch.ScanVectorIndexRequest var scanIndexJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&scanIndexJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&scanIndexReq.LastPrimaryKey, "last-primary-key", scanIndexReq.LastPrimaryKey, `Primary key of the last entry returned in the previous scan.`) @@ -654,8 +643,6 @@ func newSyncIndex() *cobra.Command { var syncIndexReq vectorsearch.SyncIndexRequest - // TODO: short flags - cmd.Use = "sync-index INDEX_NAME" cmd.Short = `Synchronize an index.` cmd.Long = `Synchronize an index. @@ -713,7 +700,6 @@ func newUpsertDataVectorIndex() *cobra.Command { var upsertDataVectorIndexReq vectorsearch.UpsertDataVectorIndexRequest var upsertDataVectorIndexJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&upsertDataVectorIndexJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "upsert-data-vector-index INDEX_NAME INPUTS_JSON" diff --git a/cmd/workspace/volumes/volumes.go b/cmd/workspace/volumes/volumes.go index ecb18762f0..1310f4da11 100755 --- a/cmd/workspace/volumes/volumes.go +++ b/cmd/workspace/volumes/volumes.go @@ -66,7 +66,6 @@ func newCreate() *cobra.Command { var createReq catalog.CreateVolumeRequestContent var createJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&createReq.Comment, "comment", createReq.Comment, `The comment attached to the volume.`) @@ -187,8 +186,6 @@ func newDelete() *cobra.Command { var deleteReq catalog.DeleteVolumeRequest - // TODO: short flags - cmd.Use = "delete NAME" cmd.Short = `Delete a Volume.` cmd.Long = `Delete a Volume. @@ -261,8 +258,6 @@ func newList() *cobra.Command { var listReq catalog.ListVolumesRequest - // TODO: short flags - cmd.Flags().BoolVar(&listReq.IncludeBrowse, "include-browse", listReq.IncludeBrowse, `Whether to include volumes in the response for which the principal can only access selective metadata for.`) cmd.Flags().IntVar(&listReq.MaxResults, "max-results", listReq.MaxResults, `Maximum number of volumes to return (page length).`) cmd.Flags().StringVar(&listReq.PageToken, "page-token", listReq.PageToken, `Opaque token returned by a previous request.`) @@ -332,8 +327,6 @@ func newRead() *cobra.Command { var readReq catalog.ReadVolumeRequest - // TODO: short flags - cmd.Flags().BoolVar(&readReq.IncludeBrowse, "include-browse", readReq.IncludeBrowse, `Whether to include volumes in the response for which the principal can only access selective metadata for.`) cmd.Use = "read NAME" @@ -410,7 +403,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdateVolumeRequestContent var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&updateReq.Comment, "comment", updateReq.Comment, `The comment attached to the volume.`) diff --git a/cmd/workspace/warehouses/warehouses.go b/cmd/workspace/warehouses/warehouses.go index c5dd43c385..5a1a532512 100755 --- a/cmd/workspace/warehouses/warehouses.go +++ b/cmd/workspace/warehouses/warehouses.go @@ -75,7 +75,7 @@ func newCreate() *cobra.Command { cmd.Flags().BoolVar(&createSkipWait, "no-wait", createSkipWait, `do not wait to reach RUNNING state`) cmd.Flags().DurationVar(&createTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach RUNNING state`) - // TODO: short flags + cmd.Flags().Var(&createJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().IntVar(&createReq.AutoStopMins, "auto-stop-mins", createReq.AutoStopMins, `The amount of time in minutes that a SQL warehouse must be idle (i.e., no RUNNING queries) before it is automatically stopped.`) @@ -175,8 +175,6 @@ func newDelete() *cobra.Command { var deleteReq sql.DeleteWarehouseRequest - // TODO: short flags - cmd.Use = "delete ID" cmd.Short = `Delete a warehouse.` cmd.Long = `Delete a warehouse. @@ -251,7 +249,7 @@ func newEdit() *cobra.Command { cmd.Flags().BoolVar(&editSkipWait, "no-wait", editSkipWait, `do not wait to reach RUNNING state`) cmd.Flags().DurationVar(&editTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach RUNNING state`) - // TODO: short flags + cmd.Flags().Var(&editJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().IntVar(&editReq.AutoStopMins, "auto-stop-mins", editReq.AutoStopMins, `The amount of time in minutes that a SQL warehouse must be idle (i.e., no RUNNING queries) before it is automatically stopped.`) @@ -367,8 +365,6 @@ func newGet() *cobra.Command { var getReq sql.GetWarehouseRequest - // TODO: short flags - cmd.Use = "get ID" cmd.Short = `Get warehouse info.` cmd.Long = `Get warehouse info. @@ -437,8 +433,6 @@ func newGetPermissionLevels() *cobra.Command { var getPermissionLevelsReq sql.GetWarehousePermissionLevelsRequest - // TODO: short flags - cmd.Use = "get-permission-levels WAREHOUSE_ID" cmd.Short = `Get SQL warehouse permission levels.` cmd.Long = `Get SQL warehouse permission levels. @@ -507,8 +501,6 @@ func newGetPermissions() *cobra.Command { var getPermissionsReq sql.GetWarehousePermissionsRequest - // TODO: short flags - cmd.Use = "get-permissions WAREHOUSE_ID" cmd.Short = `Get SQL warehouse permissions.` cmd.Long = `Get SQL warehouse permissions. @@ -621,8 +613,6 @@ func newList() *cobra.Command { var listReq sql.ListWarehousesRequest - // TODO: short flags - cmd.Flags().IntVar(&listReq.RunAsUserId, "run-as-user-id", listReq.RunAsUserId, `Service Principal which will be used to fetch the list of warehouses.`) cmd.Use = "list" @@ -674,7 +664,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq sql.WarehousePermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -762,7 +751,6 @@ func newSetWorkspaceWarehouseConfig() *cobra.Command { var setWorkspaceWarehouseConfigReq sql.SetWorkspaceWarehouseConfigRequest var setWorkspaceWarehouseConfigJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setWorkspaceWarehouseConfigJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: complex arg: channel @@ -845,7 +833,6 @@ func newStart() *cobra.Command { cmd.Flags().BoolVar(&startSkipWait, "no-wait", startSkipWait, `do not wait to reach RUNNING state`) cmd.Flags().DurationVar(&startTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach RUNNING state`) - // TODO: short flags cmd.Use = "start ID" cmd.Short = `Start a warehouse.` @@ -939,7 +926,6 @@ func newStop() *cobra.Command { cmd.Flags().BoolVar(&stopSkipWait, "no-wait", stopSkipWait, `do not wait to reach STOPPED state`) cmd.Flags().DurationVar(&stopTimeout, "timeout", 20*time.Minute, `maximum amount of time to reach STOPPED state`) - // TODO: short flags cmd.Use = "stop ID" cmd.Short = `Stop a warehouse.` @@ -1029,7 +1015,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq sql.WarehousePermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list diff --git a/cmd/workspace/workspace-bindings/workspace-bindings.go b/cmd/workspace/workspace-bindings/workspace-bindings.go index 82ad7712d8..5cb1802442 100755 --- a/cmd/workspace/workspace-bindings/workspace-bindings.go +++ b/cmd/workspace/workspace-bindings/workspace-bindings.go @@ -73,8 +73,6 @@ func newGet() *cobra.Command { var getReq catalog.GetWorkspaceBindingRequest - // TODO: short flags - cmd.Use = "get NAME" cmd.Short = `Get catalog workspace bindings.` cmd.Long = `Get catalog workspace bindings. @@ -132,8 +130,6 @@ func newGetBindings() *cobra.Command { var getBindingsReq catalog.GetBindingsRequest - // TODO: short flags - cmd.Flags().IntVar(&getBindingsReq.MaxResults, "max-results", getBindingsReq.MaxResults, `Maximum number of workspace bindings to return.`) cmd.Flags().StringVar(&getBindingsReq.PageToken, "page-token", getBindingsReq.PageToken, `Opaque pagination token to go to next page based on previous query.`) @@ -195,7 +191,6 @@ func newUpdate() *cobra.Command { var updateReq catalog.UpdateWorkspaceBindings var updateJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: assign_workspaces @@ -271,7 +266,6 @@ func newUpdateBindings() *cobra.Command { var updateBindingsReq catalog.UpdateWorkspaceBindingsParameters var updateBindingsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updateBindingsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: add diff --git a/cmd/workspace/workspace-conf/workspace-conf.go b/cmd/workspace/workspace-conf/workspace-conf.go index b05e96da07..69b6ab2d8c 100755 --- a/cmd/workspace/workspace-conf/workspace-conf.go +++ b/cmd/workspace/workspace-conf/workspace-conf.go @@ -55,8 +55,6 @@ func newGetStatus() *cobra.Command { var getStatusReq settings.GetStatusRequest - // TODO: short flags - cmd.Use = "get-status KEYS" cmd.Short = `Check configuration status.` cmd.Long = `Check configuration status. @@ -111,7 +109,6 @@ func newSetStatus() *cobra.Command { var setStatusReq settings.WorkspaceConf var setStatusJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setStatusJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "set-status" diff --git a/cmd/workspace/workspace/workspace.go b/cmd/workspace/workspace/workspace.go index 211a0185b7..c7339ab0e8 100755 --- a/cmd/workspace/workspace/workspace.go +++ b/cmd/workspace/workspace/workspace.go @@ -68,7 +68,6 @@ func newDelete() *cobra.Command { var deleteReq workspace.Delete var deleteJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&deleteJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().BoolVar(&deleteReq.Recursive, "recursive", deleteReq.Recursive, `The flag that specifies whether to delete the object recursively.`) @@ -172,8 +171,6 @@ func newExport() *cobra.Command { var exportReq workspace.ExportRequest - // TODO: short flags - cmd.Flags().Var(&exportReq.Format, "format", `This specifies the format of the exported file. Supported values: [ AUTO, DBC, @@ -260,8 +257,6 @@ func newGetPermissionLevels() *cobra.Command { var getPermissionLevelsReq workspace.GetWorkspaceObjectPermissionLevelsRequest - // TODO: short flags - cmd.Use = "get-permission-levels WORKSPACE_OBJECT_TYPE WORKSPACE_OBJECT_ID" cmd.Short = `Get workspace object permission levels.` cmd.Long = `Get workspace object permission levels. @@ -320,8 +315,6 @@ func newGetPermissions() *cobra.Command { var getPermissionsReq workspace.GetWorkspaceObjectPermissionsRequest - // TODO: short flags - cmd.Use = "get-permissions WORKSPACE_OBJECT_TYPE WORKSPACE_OBJECT_ID" cmd.Short = `Get workspace object permissions.` cmd.Long = `Get workspace object permissions. @@ -381,8 +374,6 @@ func newGetStatus() *cobra.Command { var getStatusReq workspace.GetStatusRequest - // TODO: short flags - cmd.Use = "get-status PATH" cmd.Short = `Get status.` cmd.Long = `Get status. @@ -441,7 +432,6 @@ func newImport() *cobra.Command { var importReq workspace.Import var importJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&importJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Flags().StringVar(&importReq.Content, "content", importReq.Content, `The base64-encoded content.`) @@ -540,8 +530,6 @@ func newList() *cobra.Command { var listReq workspace.ListWorkspaceRequest - // TODO: short flags - cmd.Flags().Int64Var(&listReq.NotebooksModifiedAfter, "notebooks-modified-after", listReq.NotebooksModifiedAfter, `UTC timestamp in milliseconds.`) cmd.Use = "list PATH" @@ -600,7 +588,6 @@ func newMkdirs() *cobra.Command { var mkdirsReq workspace.Mkdirs var mkdirsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&mkdirsJson, "json", `either inline JSON string or @path/to/file.json with request body`) cmd.Use = "mkdirs PATH" @@ -703,7 +690,6 @@ func newSetPermissions() *cobra.Command { var setPermissionsReq workspace.WorkspaceObjectPermissionsRequest var setPermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&setPermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list @@ -781,7 +767,6 @@ func newUpdatePermissions() *cobra.Command { var updatePermissionsReq workspace.WorkspaceObjectPermissionsRequest var updatePermissionsJson flags.JsonFlag - // TODO: short flags cmd.Flags().Var(&updatePermissionsJson, "json", `either inline JSON string or @path/to/file.json with request body`) // TODO: array: access_control_list