Add fs ls command for dbfs #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
andrewnester
reviewed
Jun 5, 2023
andrewnester
reviewed
Jun 5, 2023
andrewnester
reviewed
Jun 5, 2023
andrewnester
requested changes
Jun 5, 2023
cmd/fs/ls_output.go
Outdated
| ModTime time.Time `json:"last_modified"` | ||
| } | ||
|
|
||
| func toLsOutput(f fs.DirEntry) (*lsOutput, error) { |
There was a problem hiding this comment.
I would make it a method of fs.DirEntry instead, for better readability
There was a problem hiding this comment.
We cannot define methods on structs defined in external packages right?
pietern
reviewed
Jun 5, 2023
pietern
reviewed
Jun 5, 2023
cmd/fs/ls.go
Outdated
| {{end}} | ||
| `)) | ||
| } | ||
| return cmdio.Render(ctx, jsonDirEntries) |
There was a problem hiding this comment.
Please specify the template here as well. Now this command it taking two different approaches for rendering a template based on the mode which is weird to the uninitiated reader.
There was a problem hiding this comment.
Is there a significance for storing templates in the annotations in the first place?
cc: @nfx
There was a problem hiding this comment.
It has to be done for autogenerated commands because assignment of the annotations field happens in a different file from where the command is defined. Means a stable way to associate metadata with the command instance.
pietern
approved these changes
Jun 5, 2023
internal/ls_test.go
Outdated
| @@ -0,0 +1,104 @@ | |||
| package internal | |||
There was a problem hiding this comment.
Could you name this file fs_ls_test.go to disambiguate from (potential) other ls tests?
There was a problem hiding this comment.
What are the other potential ls tests possible? did you have anything specific in mind?
|
integration test run: https://github.com/databricks/eng-dev-ecosystem/actions/runs/5178919118 |
Merged
pietern
added a commit
that referenced
this pull request
Jun 12, 2023
## Changes CLI: * Add directory tracking to sync ([#425](#425)). * Add fs cat command for dbfs files ([#430](#430)). * Add fs ls command for dbfs ([#429](#429)). * Add fs mkdirs command for dbfs ([#432](#432)). * Add fs rm command for dbfs ([#433](#433)). * Add installation instructions ([#458](#458)). * Add new line to cmdio JSON rendering ([#443](#443)). * Add profile on `databricks auth login` ([#423](#423)). * Add readable console logger ([#370](#370)). * Add workspace export-dir command ([#449](#449)). * Added secrets input prompt for secrets put-secret command ([#413](#413)). * Added spinner when loading command prompts ([#420](#420)). * Better error message if can not load prompts ([#437](#437)). * Changed service template to correctly handle required positional arguments ([#405](#405)). * Do not generate prompts for certain commands ([#438](#438)). * Do not prompt for List methods ([#411](#411)). * Do not use FgWhite and FgBlack for terminal output ([#435](#435)). * Skip path translation of job task for jobs with a Git source ([#404](#404)). * Tweak profile prompt ([#454](#454)). * Update with the latest Go SDK ([#457](#457)). * Use cmdio in version command for `--output` flag ([#419](#419)). Bundles: * Check for nil environment before accessing it ([#453](#453)). Dependencies: * Bump github.com/hashicorp/terraform-json from 0.16.0 to 0.17.0 ([#459](#459)). * Bump github.com/mattn/go-isatty from 0.0.18 to 0.0.19 ([#412](#412)). Internal: * Add Mkdir and ReadDir functions to filer.Filer interface ([#414](#414)). * Add Stat function to filer.Filer interface ([#421](#421)). * Add check for path is a directory in filer.ReadDir ([#426](#426)). * Add fs.FS adapter for the filer interface ([#422](#422)). * Add implementation of filer.Filer for local filesystem ([#460](#460)). * Allow equivalence checking of filer errors to fs errors ([#416](#416)). * Fix locker integration test ([#417](#417)). * Implement DBFS filer ([#139](#139)). * Include recursive deletion in filer interface ([#442](#442)). * Make filer.Filer return fs.DirEntry from ReadDir ([#415](#415)). * Speed up sync integration tests ([#428](#428)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Manually and integration tests