Fixed ignoring required positional parameters when --json flag is provided #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgyucht
reviewed
Jun 29, 2023
| patchReq.Id = args[0] | ||
| args = append(args, id) | ||
| } | ||
| if len(args) != 1 { |
There was a problem hiding this comment.
This will break I believe?
There was a problem hiding this comment.
@mgyucht no, why? This is a general logic for prompts. If no args provided it will go to the condition on line 284 and ask user to choose group ID from the list and append it to args on line 296 so len(args) == 1
Or if customer provided positional argument, the prompt condition will be skipped
There was a problem hiding this comment.
My mistake, didn't realize args itself was modified in that block.
mgyucht
approved these changes
Jul 3, 2023
pietern
reviewed
Jul 3, 2023
andrewnester
force-pushed
the
fix-missing-required-param-with-json
branch
from
9de3679
to
2772621
Compare
Merged
pietern
added a commit
that referenced
this pull request
Jul 10, 2023
## Changes CLI: * Fix secrets put-secret command ([#545](#545)). * Fixed ignoring required positional parameters when --json flag is provided ([#535](#535)). * Update cp help message to not require file scheme ([#554](#554)). Bundles: * Fix: bundle destroy fails when bundle.tf.json file is deleted ([#519](#519)). * Fixed error reporting when included invalid files in include section ([#543](#543)). * Make top level workspace optional in JSON schema ([#562](#562)). * Propagate TF_CLI_CONFIG_FILE env variable ([#555](#555)). * Update Terraform provider schema structs ([#563](#563)). * Update inline JSON schema documentation ([#557](#557)). Dependencies: * Bump Go SDK to v0.12.0 ([#540](#540)). * Bump github.com/hashicorp/terraform-json from 0.17.0 to 0.17.1 ([#541](#541)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When there are positional required parameters in the command which can't be unmarshalled from JSON, we should require them despite the fact
--jsonflag is provided.The reason is that for some of the command, for example,
databricks groups patch IDthese arguments are actually path arguments in API and can't be set as part of--jsonbody provided.Original change which introduced this ignore logic is here: #405
Fixes #533, #537
Note: Code generation is based on the change in this PR: databricks/databricks-sdk-go#536
Tests
cli groups patch 123 --json {...}works correctlyBackward compatibility tests with previous changes from #405
cli clusters events --json '{"cluster_id": "1029-xxxx"}'- works, returns list of eventscli clusters events 1029-xxxx- works, returns list of eventscli clusters events- works, first prompts for Cluster ID and then returns the list of events