From 3bfa7a97afe897cdc73c58864431fe1ebdc7c120 Mon Sep 17 00:00:00 2001 From: Jacky Hu Date: Tue, 17 Oct 2023 10:36:11 -0700 Subject: [PATCH 1/3] Add GocCloud domain into AWS domains Signed-off-by: Jacky Hu --- src/databricks/sql/auth/endpoint.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/databricks/sql/auth/endpoint.py b/src/databricks/sql/auth/endpoint.py index e24f9d751..08401f004 100644 --- a/src/databricks/sql/auth/endpoint.py +++ b/src/databricks/sql/auth/endpoint.py @@ -23,7 +23,7 @@ class CloudType(Enum): AZURE = "azure" -DATABRICKS_AWS_DOMAINS = [".cloud.databricks.com", ".dev.databricks.com"] +DATABRICKS_AWS_DOMAINS = [".cloud.databricks.com", ".dev.databricks.com", ".cloud.databricks.us"] DATABRICKS_AZURE_DOMAINS = [ ".azuredatabricks.net", ".databricks.azure.cn", From 98f51d83b9213c66f44244c63b86d27ab2944e62 Mon Sep 17 00:00:00 2001 From: Jacky Hu Date: Tue, 17 Oct 2023 11:08:17 -0700 Subject: [PATCH 2/3] Format fix Signed-off-by: Jacky Hu --- src/databricks/sql/auth/endpoint.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/databricks/sql/auth/endpoint.py b/src/databricks/sql/auth/endpoint.py index 08401f004..d9501638e 100644 --- a/src/databricks/sql/auth/endpoint.py +++ b/src/databricks/sql/auth/endpoint.py @@ -23,7 +23,11 @@ class CloudType(Enum): AZURE = "azure" -DATABRICKS_AWS_DOMAINS = [".cloud.databricks.com", ".dev.databricks.com", ".cloud.databricks.us"] +DATABRICKS_AWS_DOMAINS = [ + ".cloud.databricks.com", + ".dev.databricks.com", + ".cloud.databricks.us", +] DATABRICKS_AZURE_DOMAINS = [ ".azuredatabricks.net", ".databricks.azure.cn", From c7b88f10b39a3c3e3d8ef131bea9458191379ae5 Mon Sep 17 00:00:00 2001 From: Jacky Hu Date: Tue, 17 Oct 2023 11:18:53 -0700 Subject: [PATCH 3/3] Address review comments Signed-off-by: Jacky Hu --- src/databricks/sql/auth/endpoint.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/databricks/sql/auth/endpoint.py b/src/databricks/sql/auth/endpoint.py index d9501638e..c0ce0f9db 100644 --- a/src/databricks/sql/auth/endpoint.py +++ b/src/databricks/sql/auth/endpoint.py @@ -25,9 +25,10 @@ class CloudType(Enum): DATABRICKS_AWS_DOMAINS = [ ".cloud.databricks.com", - ".dev.databricks.com", ".cloud.databricks.us", + ".dev.databricks.com", ] + DATABRICKS_AZURE_DOMAINS = [ ".azuredatabricks.net", ".databricks.azure.cn",