Implement Series.item #1502
Merged
Implement Series.item #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1502 +/- ##
==========================================
- Coverage 93.93% 93.90% -0.04%
==========================================
Files 36 36
Lines 8445 8448 +3
==========================================
Hits 7933 7933
- Misses 512 515 +3
Continue to review full report at Codecov.
|
HyukjinKwon
reviewed
May 18, 2020
HyukjinKwon
reviewed
May 18, 2020
HyukjinKwon
approved these changes
May 18, 2020
HyukjinKwon
reviewed
May 18, 2020
ueshin
reviewed
May 19, 2020
Comment on lines
+4753
to
+4756
| item_top_two = self[:2] | ||
| if len(item_top_two) != 1: | ||
| raise ValueError("can only convert an array of size 1 to a Python scalar") | ||
| return item_top_two[0] |
There was a problem hiding this comment.
Seems like this still runs Spark jobs twice? We should explicitly call to_pandas() or collect()?
There was a problem hiding this comment.
Ah, I'll check and fix it. Thanks !
There was a problem hiding this comment.
@HyukjinKwon
Yeah, I should have considered much more carefully.
Thanks for reminding me once again, @HyukjinKwon ! I must keep that in mind.
HyukjinKwon
pushed a commit
that referenced
this pull request
May 21, 2020
According to the comment #1502 (comment), fixed `Series.item` to run a Spark job not twice, once.
rising-star92
added a commit
to rising-star92/databricks-koalas
that referenced
this pull request
Jan 27, 2023
According to the comment databricks/koalas#1502 (comment), fixed `Series.item` to run a Spark job not twice, once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes
Series.item