Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a short JDBC user guide #2148

Merged
merged 3 commits into from Apr 13, 2021
Merged

Conversation

HyukjinKwon
Copy link
Member

Screen Shot 2021-04-12 at 5 04 07 PMScreen Shot 2021-04-12 at 5 05 00 PM

Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM, pending tests.

"spark.jars",
"{}/sqlite-jdbc-3.34.0.jar".format(os.getcwd()))
.config(
"spark.driver.extraClassPath",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to set spark.executor.extraClassPath as well?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not:

Extra classpath entries to prepend to the classpath of executors. This exists primarily for backwards-compatibility with older versions of Spark. Users typically should not need to set this option.

https://spark.apache.org/docs/latest/configuration.html#runtime-environment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it might still be needed if the older versions of Spark includes 2.4?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay to just leave it ... I referred to https://spark.apache.org/docs/3.1.1/sql-data-sources-jdbc.html#content.

@codecov-io
Copy link

Codecov Report

Merging #2148 (de853ab) into master (697414b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2148   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          60       60           
  Lines       13707    13707           
=======================================
  Hits        13071    13071           
  Misses        636      636           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697414b...de853ab. Read the comment docs.

@xinrong-meng xinrong-meng self-requested a review April 13, 2021 02:21
@xinrong-meng
Copy link
Contributor

LGTM, thanks!

@ueshin
Copy link
Collaborator

ueshin commented Apr 13, 2021

Thanks! merging.

@ueshin ueshin merged commit c574be2 into databricks:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants