New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a short JDBC user guide #2148
Conversation
HyukjinKwon
commented
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM, pending tests.
"spark.jars", | ||
"{}/sqlite-jdbc-3.34.0.jar".format(os.getcwd())) | ||
.config( | ||
"spark.driver.extraClassPath", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to set spark.executor.extraClassPath
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not:
Extra classpath entries to prepend to the classpath of executors. This exists primarily for backwards-compatibility with older versions of Spark. Users typically should not need to set this option.
https://spark.apache.org/docs/latest/configuration.html#runtime-environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it might still be needed if the older versions of Spark
includes 2.4
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okay to just leave it ... I referred to https://spark.apache.org/docs/3.1.1/sql-data-sources-jdbc.html#content.
Codecov Report
@@ Coverage Diff @@
## master #2148 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 60 60
Lines 13707 13707
=======================================
Hits 13071 13071
Misses 636 636 Continue to review full report at Codecov.
|
LGTM, thanks! |
Thanks! merging. |