Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for values with self-closing tags #303

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
6 participants
@HyukjinKwon
Copy link
Member

commented May 13, 2018

Same for #285 but I resolved conflicts here. Should credit to him.

Closes #285
Closes #156
Closes #92
Closes #190
Closes #276

Add support for values with self-closing tags
Signed-off-by: Anton Alexandrov <afalexandrov@luxoft.com>
@HyukjinKwon

This comment has been minimized.

Copy link
Member Author

commented May 13, 2018

@BioQwer, I am sorry for the late response. It was LGTM. I manually resolved the conflict here. Few differences are I a little bit cleaned up and removed the change about allowing empty attribute prefixes. Maybe, we can do this in another PR.

It's quite core change so it took me a while to double check. Mind taking another look before merging it in?

@HyukjinKwon

This comment has been minimized.

Copy link
Member Author

commented May 13, 2018

BTW, let me try to prepare the release only after the current open PRs. It's been delayed again and again.

@codecov-io

This comment has been minimized.

Copy link

commented May 13, 2018

Codecov Report

Merging #303 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   88.46%   88.54%   +0.07%     
==========================================
  Files          14       14              
  Lines         728      733       +5     
  Branches       99       93       -6     
==========================================
+ Hits          644      649       +5     
  Misses         84       84
Impacted Files Coverage Δ
...cala/com/databricks/spark/xml/XmlInputFormat.scala 94.4% <100%> (+0.18%) ⬆️
...la/com/databricks/spark/xml/util/InferSchema.scala 87.14% <100%> (ø) ⬆️
...m/databricks/spark/xml/parsers/StaxXmlParser.scala 97.08% <100%> (ø) ⬆️
...abricks/spark/xml/parsers/StaxXmlParserUtils.scala 97.87% <100%> (+0.04%) ⬆️
...in/scala/com/databricks/spark/xml/XmlOptions.scala 97.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e29c5...382b75b. Read the comment docs.

@HyukjinKwon HyukjinKwon merged commit 2dbcd38 into databricks:master May 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@oshribr

This comment has been minimized.

Copy link

commented Jul 16, 2018

where can i find the last build, with this fixed?

@BioQwer

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2018

@oshribr you can get here , build with this fixes.
it's my builds

@hunzinker

This comment has been minimized.

Copy link

commented Aug 15, 2018

Hi - Thanks for the great work! What's the timeline for uploading the artifact for build 0.4.2 to maven?

@ankit57

This comment has been minimized.

Copy link

commented Sep 19, 2018

Hi, I still do not see 0.4.2 on maven. Is there any ETA to it?

@HyukjinKwon

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2018

It's currently blocked by #321

We should fix the tests before the release

cefn added a commit to cefn/spark-xml that referenced this pull request Jul 2, 2019

self-closing tag support : no longer accurate
There is a comment "At the moment, rows containing self closing xml tags are not supported." which may no longer be true as per... databricks#303

HyukjinKwon added a commit that referenced this pull request Jul 2, 2019

self-closing tag support : no longer accurate (#394)
There is a comment "At the moment, rows containing self closing xml tags are not supported." which may no longer be true as per... #303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.