Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-closing tag support : no longer accurate #394

Merged
merged 1 commit into from Jul 2, 2019

Conversation

Projects
None yet
4 participants
@cefn
Copy link
Contributor

commented Jul 2, 2019

There is a comment "At the moment, rows containing self closing xml tags are not supported." which may no longer be true as per... #303

self-closing tag support : no longer accurate
There is a comment "At the moment, rows containing self closing xml tags are not supported." which may no longer be true as per... #303
@codecov-io

This comment has been minimized.

Copy link

commented Jul 2, 2019

Codecov Report

Merging #394 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   87.78%   87.78%           
=======================================
  Files          14       14           
  Lines         745      745           
  Branches       64       64           
=======================================
  Hits          654      654           
  Misses         91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff88df...07beefc. Read the comment docs.

@HyukjinKwon

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Oh, nice!

@HyukjinKwon HyukjinKwon merged commit 41d0d17 into databricks:master Jul 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ydalal927

This comment has been minimized.

Copy link

commented Jul 16, 2019

Does this change resolves issues with self closing tags without any values such as <abc//> or <StudentID//>

@HyukjinKwon

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Yea, I think that's fixed at #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.