From d3aacda6d8472830433c1b0e123179f3727cc25f Mon Sep 17 00:00:00 2001 From: ravi-databricks <37003292+ravi-databricks@users.noreply.github.com> Date: Tue, 30 Apr 2024 12:28:47 -0700 Subject: [PATCH] Changed dbfs.create to mkdirs for CLI --- src/cli.py | 2 +- tests/test_cli.py | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/cli.py b/src/cli.py index 05d5604..6f7e2ab 100644 --- a/src/cli.py +++ b/src/cli.py @@ -153,7 +153,7 @@ def onboard(self, cmd: OnboardCommand): """Perform the onboarding process.""" self.update_ws_onboarding_paths(cmd) if not self._ws.dbfs.exists(cmd.dbfs_path + "/dltmeta_conf/"): - self._ws.dbfs.create(path=cmd.dbfs_path + "/dltmeta_conf/", overwrite=True) + self._ws.dbfs.mkdirs(f"{cmd.dbfs_path}/dltmeta_conf/") ob_file = open(cmd.onboarding_file_path, "rb") onboarding_filename = os.path.basename(cmd.onboarding_file_path) self._ws.dbfs.upload(cmd.dbfs_path + f"/dltmeta_conf/{onboarding_filename}", ob_file, overwrite=True) diff --git a/tests/test_cli.py b/tests/test_cli.py index c675a95..b09f84f 100644 --- a/tests/test_cli.py +++ b/tests/test_cli.py @@ -47,7 +47,7 @@ def test_onboard(self, mock_workspace_client): mock_workspace_client.dbfs = mock_dbfs mock_workspace_client.jobs = mock_jobs mock_workspace_client.dbfs.exists.return_value = False - mock_workspace_client.dbfs.create.return_value = None + mock_workspace_client.dbfs.mkdirs.return_value = None mock_workspace_client.dbfs.upload.return_value = None mock_workspace_client.dbfs.copy.return_value = None mock_workspace_client.jobs.create.return_value = MagicMock(job_id="job_id") @@ -59,10 +59,7 @@ def test_onboard(self, mock_workspace_client): dltmeta.onboard(self.onboard_cmd) mock_workspace_client.dbfs.exists.assert_called_once_with('/dbfs/dltmeta_conf/') - mock_workspace_client.dbfs.create.assert_called_once_with( - path="/dbfs/dltmeta_conf/", - overwrite=True - ) + mock_workspace_client.dbfs.mkdirs.assert_called_once_with("/dbfs/dltmeta_conf/") mock_workspace_client.dbfs.upload.assert_called_once() print(mock_workspace_client.dbfs.copy.call_args_list) mock_workspace_client.dbfs.copy.assert_called_once_with(