Skip to content

Enhance KeyValueStoreSolver to support MetricExpression filters and u…#9

Merged
tombonfert merged 2 commits into
mainfrom
feature/kvs_container_metric_filter
May 12, 2026
Merged

Enhance KeyValueStoreSolver to support MetricExpression filters and u…#9
tombonfert merged 2 commits into
mainfrom
feature/kvs_container_metric_filter

Conversation

@tombonfert
Copy link
Copy Markdown
Collaborator

…pdate documentation

  • Added support for MetricExpression filters in KeyValueStoreSolver's filter_container_metrics method.
  • Updated the report validation to reflect that KeyValueStoreSolver now supports both tag and metric filters.
  • Modified tests to ensure proper functionality of new metric filtering capabilities and updated container_metrics column mappings.

Summary

Changes

Test Plan

  • Unit tests added/updated
  • Manual testing completed
  • Documentation updated (if applicable)

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No new linter warnings introduced

…pdate documentation

* Added support for MetricExpression filters in KeyValueStoreSolver's filter_container_metrics method.
* Updated the report validation to reflect that KeyValueStoreSolver now supports both tag and metric filters.
* Modified tests to ensure proper functionality of new metric filtering capabilities and updated container_metrics column mappings.
@tombonfert tombonfert requested a review from a team as a code owner May 11, 2026 19:13
@tombonfert tombonfert requested a review from adefabian May 11, 2026 19:14
MaximHammer
MaximHammer previously approved these changes May 11, 2026
Comment thread src/mda_query_engine/analyze/query/solvers/key_value_store_solver.py Outdated
@tombonfert tombonfert requested review from MaximHammer and removed request for adefabian May 11, 2026 21:15
@tombonfert tombonfert merged commit 99b5e80 into main May 12, 2026
@tombonfert tombonfert deleted the feature/kvs_container_metric_filter branch May 12, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants