From 97615fdeb5010407286445bd63560fdb288a5bb9 Mon Sep 17 00:00:00 2001 From: Jonas Rutishauser Date: Fri, 25 Oct 2019 18:46:48 +0200 Subject: [PATCH] fix issues in --reset-values and --reuse-values on helm v3 Correction of #159 --- cmd/helm3.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/helm3.go b/cmd/helm3.go index fdc893cb..c53454fc 100644 --- a/cmd/helm3.go +++ b/cmd/helm3.go @@ -65,7 +65,7 @@ func (d *diffCmd) template() ([]byte, error) { // Helm automatically enable --reuse-values when there's no --set, --set-string, --set-values, --set-file present. // Let's simulate that in helm-diff. // See https://medium.com/@kcatstack/understand-helm-upgrade-flags-reset-values-reuse-values-6e58ac8f127e - shouldDefaultReusingValues := len(d.values) > 0 && len(d.stringValues) > 0 && len(d.valueFiles) > 0 && len(d.fileValues) > 0 + shouldDefaultReusingValues := len(d.values) == 0 && len(d.stringValues) == 0 && len(d.valueFiles) == 0 && len(d.fileValues) == 0 if (d.reuseValues || shouldDefaultReusingValues) && !d.resetValues { tmpfile, err := ioutil.TempFile("", "existing-values") if err != nil {