Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos in page front matter #72

Merged
merged 1 commit into from Nov 21, 2021

Conversation

tobyhodges
Copy link
Member

" and . were misordered in the front matter of a few pages, causing the pages to build with title, objectives, key points etc missing. (See https://datacarpentry.org/python-ecology-lesson-es/01-short-introduction-to-Python/index.html as an example.)

This PR fixes these errors to get the pages displaying correctly again.

@orchid00
Copy link
Contributor

hi @tobyhodges long ago you sent this PR. Thanks for that, how do we fix failed checks before merging?

@tobyhodges
Copy link
Member Author

I think the answer to the failing checks is to bring in the latest changes to the lesson template. The template now uses GitHub Actions instead of Travis to check and build the lesson site. That is best kept for a separate Pull Request, which I am happy to put in if you like?

Regardless, I have built and checked this branch locally and I believe this PR can be merged without fear of a broken lesson site.

@raynamharris
Copy link
Contributor

LGTM. Thanks @tobyhodges and @orchid00

@zkamvar zkamvar mentioned this pull request Jun 3, 2021
Copy link
Contributor

@vinisalazar vinisalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobyhodges thank you for the contribution. I just built this PR's branch locally and everything seems to be fine.

@orchid00 @raynamharris is it okay for me to merge this? It would also help with #75, which in turn will help with fixing the failed Travis checks.

Thanks,
Vini

@raynamharris
Copy link
Contributor

Looks good to me. Okay to merge this one and update the styles. Thank you!

@vinisalazar vinisalazar merged commit 4744471 into datacarpentry:gh-pages Nov 21, 2021
zkamvar pushed a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants