Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata 4.5 - Add field to dataset DB for new publisher_obj #1018

Merged
merged 5 commits into from
Oct 4, 2023

Conversation

svogt0511
Copy link
Contributor

@svogt0511 svogt0511 commented Oct 4, 2023

Purpose

Add rails db migration for metadata-4.5 to add the publisher_obj field to the dataset.

Related to: #1005

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@svogt0511 svogt0511 self-assigned this Oct 4, 2023
@svogt0511 svogt0511 merged commit ba6e112 into master Oct 4, 2023
11 checks passed
@svogt0511 svogt0511 deleted the schema-4.5-r1 branch October 4, 2023 18:36
@svogt0511 svogt0511 restored the schema-4.5-r1 branch October 4, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants