Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap API defaults are broken #189

Closed
jontonsoup opened this issue Feb 17, 2017 · 1 comment
Closed

wrap API defaults are broken #189

jontonsoup opened this issue Feb 17, 2017 · 1 comment
Labels

Comments

@jontonsoup
Copy link

It appears that the wrap api defaults do not work with the UI.

I need to do this for it to work:

@tracer.wrap(name=DATADOG_SETTINGS["TRACER_SERVICE_NAME"],service=DATADOG_SETTINGS["TRACER_SERVICE_NAME"], resource="FUNCTION_NAME")
@palazzem palazzem added the bug label Feb 20, 2017
@palazzem
Copy link

Actually it mostly depends on the instrumented code. If the tracer.wrap() isn't added to a function that is already part of a trace, some fields like the service may not have a value. In that case the agent is going to drop that trace.

Here I think that the wrap() decorator is working correctly as expected. What we did (and what we're continuing to do) is providing better defaults in general.

Because the issue here is not completely related to the wrap API, I'm going to close that issue for the moment! Thanks for reporting that (and sorry for a so late answer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants