Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand SV local names #635

Closed
robosoul opened this issue Jan 19, 2023 · 7 comments
Closed

Expand SV local names #635

robosoul opened this issue Jan 19, 2023 · 7 comments

Comments

@robosoul
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Current sv list of first names (male and female) as well as last names is incomplete.

% grep 'female_first_name' sv.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
      13

% grep '[^a-z]male_first_name' sv.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
      14

% grep 'last_name' sv.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
      13

List of Swedish first/last names on wiki is more complete, around 200 first names, and 600 last names.

Describe the solution you'd like
Expand the female_first_name, male_first_name and last_name collections for sv locale.

@snuyanzin
Copy link
Collaborator

thanks for the issue
however we are all volunteers here and there is none of maintainers covering all the locales.
So PR and help would be more fruitful.

@robosoul
Copy link
Contributor Author

Hi @snuyanzin - Thanks for your reply. I am aware, I contributed to original java faker project, and I plan to support locales as I go (for my needs). I just thought it's better to have a ticket open before starting with the work :) PR coming in a few days ;) Cheers, Luka

@snuyanzin
Copy link
Collaborator

ok, great
looking forward for the PRs

@bodiam
Copy link
Contributor

bodiam commented Jan 19, 2023

Hi, I commented the same at the other issue before I saw this issue. Thanks for reporting it, and happy to accept any PRs related to these Locales!

@robosoul
Copy link
Contributor Author

All good guys, I'm use to opening ticket first, and then start working. Sorry for the confusion ;)

@robosoul
Copy link
Contributor Author

@bodiam and @snuyanzin - can you pls assign all 3 tickets to me. Can't do it by myself (I'm not a collaborator). thanks

robosoul added a commit to robosoul/datafaker that referenced this issue Jan 19, 2023
@robosoul
Copy link
Contributor Author

@bodiam and @snuyanzin - here's the PR: #638

bodiam pushed a commit that referenced this issue Jan 19, 2023
@bodiam bodiam closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants