Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand NO local names #636

Closed
robosoul opened this issue Jan 19, 2023 · 1 comment
Closed

Expand NO local names #636

robosoul opened this issue Jan 19, 2023 · 1 comment

Comments

@robosoul
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There are no first/last name collections for locale no.

Describe the solution you'd like
Create name section (for no locale) with following collections:

no:
  faker:
    name:
      female_first_name: []
      male_first_name: []
      last_name: []
      prefix: []
      name_with_middle:
        - "#{prefix} #{first_name} #{last_name} #{last_name}"
        - "#{first_name} #{last_name} #{last_name}"
        - "#{first_name} #{last_name} #{last_name}"
        - "#{first_name} #{last_name} #{last_name}"
        - "#{first_name} #{last_name} #{last_name}"
      first_name:
        - "#{female_first_name}"
        - "#{male_first_name}"

      title:
        descriptor: []
        level: []
        job: []
      name:
        - "#{first_name} #{last_name}"
        - "#{prefix} #{first_name} #{last_name}"

Describe alternatives you've considered
Created local file that I plan to move to this repo.

robosoul added a commit to robosoul/datafaker that referenced this issue Jan 19, 2023
@robosoul
Copy link
Contributor Author

@bodiam here's the PR: #639

bodiam pushed a commit that referenced this issue Jan 19, 2023
@bodiam bodiam closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants