Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable merge of male/female names into first_names list #644

Closed
robosoul opened this issue Jan 20, 2023 · 0 comments
Closed

Reusable merge of male/female names into first_names list #644

robosoul opened this issue Jan 20, 2023 · 0 comments

Comments

@robosoul
Copy link
Contributor

Is your feature request related to a problem? Please describe.
For following locales:

  • src/main/resources/en-PH.yml
  • src/main/resources/fi-FI.yml
  • src/main/resources/nb-NO.yml

Male and female first names are simply copy/pasted to first_name list. Example from en-PH:

      male_first_name: [Michael, Christian, Jeffrey, Jayson, Richard, Ryan, Jonathan, Joseph, Alvin, Marvin, Joel, Christopher, Julius, Angelo, Emmanuel]
      female_first_name: [Michelle, Jennifer, Catherine, Mary Grace, Angelica, Maricel, Rowena, Joan, Jocelyn, Mary Ann, Jessica, Arlene, Melanie, Mary Jane, Janice, Rosemarie, Christine, Marjorie, Analyn, Josephine]
      first_name: [Michael, Christian, Jeffrey, Jayson, Richard, Ryan, Jonathan, Joseph, Alvin, Marvin, Joel, Christopher, Julius, Angelo, Emmanuel, Michelle, Jennifer, Catherine, Mary Grace, Angelica, Maricel, Rowena, Joan, Jocelyn, Mary Ann, Jessica, Arlene, Melanie, Mary Jane, Janice, Rosemarie, Christine, Marjorie, Analyn, Josephine]     

Describe the solution you'd like
We should use most common (reusable) approach, where first_name is combo (not copy/pasted) of male_first_name and female_first_name values:

      first_name:
        - "#{male_first_name}"
        - "#{female_first_name}"

Describe alternatives you've considered
/

Additional context
/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants